From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21399C07E95 for ; Wed, 7 Jul 2021 12:49:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6DA261CB9 for ; Wed, 7 Jul 2021 12:49:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6DA261CB9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39222 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m16z8-0006B5-LW for qemu-devel@archiver.kernel.org; Wed, 07 Jul 2021 08:49:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52572) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m16xb-0004oX-6B for qemu-devel@nongnu.org; Wed, 07 Jul 2021 08:47:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:42996) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m16xX-0006tH-VI for qemu-devel@nongnu.org; Wed, 07 Jul 2021 08:47:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625662043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fUlZjCkvGoOXeGMfo5mhHUEH12j4GUSxsOSw8ajw6VE=; b=TDZAQy5cwBShifhsJh91686IcIM++PdlUZ90CpgFCGcqiZnxC3hXwnDYqJ4cHYok8RLgP9 3oJzfoIBqIQ7ZLAuz85iDygLxsFySMEBu9/dxGgsi/eYqNeFflBEUiQNQ7kPtNMMAvH9L7 kfTQFdWNAyDv3XpOtMobhAXn9uoQzlk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-460-kzlGhj7zM6WbMOe0gL3M2g-1; Wed, 07 Jul 2021 08:47:21 -0400 X-MC-Unique: kzlGhj7zM6WbMOe0gL3M2g-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E305719057A1 for ; Wed, 7 Jul 2021 12:47:20 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-104.ams2.redhat.com [10.36.112.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 506045D9F0; Wed, 7 Jul 2021 12:47:17 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id DCC051132B52; Wed, 7 Jul 2021 14:47:15 +0200 (CEST) From: Markus Armbruster To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= Subject: Re: [PATCH 11/18] crypto: rename des-rfb cipher to just des References: <20210706095924.764117-1-berrange@redhat.com> <20210706095924.764117-12-berrange@redhat.com> Date: Wed, 07 Jul 2021 14:47:15 +0200 In-Reply-To: <20210706095924.764117-12-berrange@redhat.com> ("Daniel P. =?utf-8?Q?Berrang=C3=A9=22's?= message of "Tue, 6 Jul 2021 10:59:17 +0100") Message-ID: <87eecaffzg.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.439, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Markus Armbruster , Eric Blake , qemu-devel@nongnu.org, Gerd Hoffmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Daniel P. Berrang=C3=A9 writes: > Currently the crypto layer exposes support for a 'des-rfb' > algorithm which is just normal single-DES, with the bits > in each key byte reversed. This special key munging is > required by the RFB protocol password authentication > mechanism. > > Since the crypto layer is generic shared code, it makes > more sense to do the key byte munging in the VNC server > code, and expose normal single-DES support. > > Signed-off-by: Daniel P. Berrang=C3=A9 > --- [...] > diff --git a/qapi/crypto.json b/qapi/crypto.json > index 7116ae9a46..6b3fadabac 100644 > --- a/qapi/crypto.json > +++ b/qapi/crypto.json > @@ -66,7 +66,7 @@ > # @aes-128: AES with 128 bit / 16 byte keys > # @aes-192: AES with 192 bit / 24 byte keys > # @aes-256: AES with 256 bit / 32 byte keys > -# @des-rfb: RFB specific variant of single DES. Do not use except in VNC= . > +# @des: DES with 56 bit / 8 byte keys. Do not use except in VNC. > # @3des: 3DES(EDE) with 192 bit / 24 byte keys (since 2.9) > # @cast5-128: Cast5 with 128 bit / 16 byte keys > # @serpent-128: Serpent with 128 bit / 16 byte keys > @@ -80,7 +80,7 @@ > { 'enum': 'QCryptoCipherAlgorithm', > 'prefix': 'QCRYPTO_CIPHER_ALG', > 'data': ['aes-128', 'aes-192', 'aes-256', > - 'des-rfb', '3des', > + 'des', '3des', > 'cast5-128', > 'serpent-128', 'serpent-192', 'serpent-256', > 'twofish-128', 'twofish-192', 'twofish-256']} Is enum value "des-rfb" part of any external interface? [...]