From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FCFDC433B4 for ; Mon, 17 May 2021 13:44:51 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8EFD611BD for ; Mon, 17 May 2021 13:44:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8EFD611BD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:Cc:To: From:Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/2zacKXCK0hxs9OrFD1XYfwmYuaPmStMWYmlgmQxFQY=; b=a2gPv2SXOcrtoCGmhMeTkt5nv LYPjxypcWkgyUZF7k6ouelIWnSdbHamu26mcnx7Mw5rLoKnGXeWOOHs8DQc5V1bvbtb+yWVS7p5d5 /kHoHJ7FVJZSekVi/gipTjHUvVDt2RzH1JT3cDrDUT16GM0mWcvBu2esDHqGz6KudF4WcX6/Cwtzf 0oF10+yGXuLNOBvv1fZCvF+/nUGURokYtGFJdogQZw7PO15wYrQNyu4zbfXv2wSAhBvoHuXrtOdWe SvLJ9udqT3b42Fbz7LXy2Ln8FOWr/KrKVQLF4ExhMk5bZaFIjiw/UE8FNMI5Kj6rkbA4x2c+5Qorv nOSHfOUqQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lidY3-00F7Ua-J7; Mon, 17 May 2021 13:44:44 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lidVv-00F7Ia-5f; Mon, 17 May 2021 13:42:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Subject:Cc:To:From: Message-ID:Date:Sender:Reply-To:Content-ID:Content-Description; bh=tar0YP1erk1H9y06ox3BwB8G/cI+kvFKfW/bopFxcPw=; b=ywyCbPi1eygmKq8wPl2cNZOq8X EFKRlLYFo5+qbES2Juiszf/S4Mqj/WUl0W/ofamMbDUDgWrXF+YP54JkzU7TIjYKU/KSGgUaePniK tAIHP94Hhv3+sP35+9BtWjTJqIqMCp001iIHt9wXKTGXwwZQCh6ne7CkHWfRNhAAoZQPbMpPOuvCf odXyzwY78moVT+V32xh9KQYYkmgtfZGFMnnFMxjSdG1mq9/z4v4d/LGc+yqv3177O8Xyz79E2hVZZ svAbFIizB+DOZTBepBrLy4Le0YMbkk0tSpAUMhuGAwaYnhOfiqeNDPfu0BUoK8UOQpTItRPUhTtK/ 6TuY02Rg==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lidVq-00Do9E-35; Mon, 17 May 2021 13:42:29 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9B702611BD; Mon, 17 May 2021 13:42:25 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lidVn-001odN-Hc; Mon, 17 May 2021 14:42:23 +0100 Date: Mon, 17 May 2021 14:42:22 +0100 Message-ID: <87eee5v5mp.wl-maz@kernel.org> From: Marc Zyngier To: Andreas =?UTF-8?B?RsOkcmJlcg==?= Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring Subject: Re: [PATCH 0/9] arm64: dts: rockchip: Initial Toybrick TB-RK1808M0 support In-Reply-To: References: <20210516230551.12469-1-afaerber@suse.de> <87im3hvikv.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: afaerber@suse.de, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210517_064226_199264_6398623B X-CRM114-Status: GOOD ( 56.05 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org QW5kcmVhcywKCk9uIE1vbiwgMTcgTWF5IDIwMjEgMTM6MjI6MjcgKzAxMDAsCkFuZHJlYXMgRsOk cmJlciA8YWZhZXJiZXJAc3VzZS5kZT4gd3JvdGU6Cj4gCj4gSGkgTWFyYywKPiAKPiBPbiAxNy4w NS4yMSAxMTowMiwgTWFyYyBaeW5naWVyIHdyb3RlOgo+ID4gT24gTW9uLCAxNyBNYXkgMjAyMSAw MDowNTo0MiArMDEwMCwKPiA+IEFuZHJlYXMgRsOkcmJlciA8YWZhZXJiZXJAc3VzZS5kZT4gd3Jv dGU6Cj4gPj4gUGF0Y2hlcyBhcmUgYmFzZWQgb24gdGhlIHNoaXBwaW5nIHRveWJyaWNrLmR0YiBm aWxlLgo+IAo+ID4+IGh0dHA6Ly90LnJvY2stY2hpcHMuY29tL2VuL3dpa2kucGhwP21vZD12aWV3 JmlkPTExMCBnaXZlcyBpbnN0cnVjdGlvbnMgZm9yCj4gCj4gPj4gY29tcGlsaW5nIHNvdXJjZXMs IGJ1dCBubyBzb3VyY2UgZG93bmxvYWQgb3IgbGluayBpcyBhY3R1YWxseSBwcm92aWRlZC4KPiAK PiA+PiAKPiAKPiA+PiBJIGVuY291bnRlcmVkIGEgaGFuZzogZWFybHljb24gcmV2ZWFsZWQgaXQg YmVpbmcgcmVsYXRlZCB0byBLVk0gYW5kCj4gPj4gdkdJQy4gIERpc2FibGluZyBLVk0gaW4gS2Nv bmZpZyB3b3JrcyBhcm91bmQgaXQsIGFzIGRvZXMgcmVtb3ZpbmcKPiA+PiB0aGUgdkdJQyBpcnEg aW4gRFQuICBJJ3ZlIGFscmVhZHkgdHJpZWQgbG93IGFuZCBoaWdoIGZvciB0aGUgdkdJQwo+ID4+ IGludGVycnVwdCwgc28gbm8gY2x1ZSB3aGF0IG1pZ2h0IGNhdXNlIGl0LiBPbiBhbiBtUENJZSBj YXJkIHdpdGggMQo+ID4+IEdpQiBvZiBSQU0gSSBmaWd1cmVkIEtWTSBpcyBub3QgZ29pbmcgdG8g YmUgYSBtYWpvciB1c2UgY2FzZSwgc28gaWYKPiA+PiB3ZSBmaW5kIG5vIG90aGVyIHNvbHV0aW9u LCB3ZSBjb3VsZCBqdXN0IGRlbGV0ZSB0aGUgaW50ZXJydXB0cwo+ID4+IHByb3BlcnR5IGluIGl0 cyAuZHRzLCBhcyBkZW1vbnN0cmF0ZWQgaGVyZS4KPiA+IAo+ID4gSSB0aGluayB5b3UgZmlndXJl ZCBpdCBvdXQgd3JvbmcsCj4gCj4gRGlkIEk/IEkgaWRlbnRpZmllZCB0aGF0IGFuIGlzc3VlIHJl c3VsdGluZyBpbiBubyBzZXJpYWwgY29uc29sZSB3YXMKPiBkZXBlbmRlbnQgb24gQ09ORklHX0tW TSBiZWluZyBlbmFibGVkIGFuZCBzcGVjaWZpY2FsbHkgdG8gdGhlIHZHSUMKPiBpbnRlcnJ1cHQg YmVpbmcgc3BlY2lmaWVkIGluIG15IERULiBUaGF0J3MgYWxsIEkgc2FpZC4KCkkgZ3Vlc3Mgd2Ug aGF2ZSBhIGRpZmZlcmVudCB3YXkgdG8gYXBwcm9hY2ggdGhlc2UgaXNzdWVzLiBSYXRoZXIgdGhh bgpkaXNhYmxpbmcgYSBmZWF0dXJlLCBJIHdvdWxkIGhhdmUgcmVhY2hlZCBvdXQgdG8gbmFycm93 IHRoZSBwcm9ibGVtCmRvd24gKmJlZm9yZSogcG9zdGluZyBhIHNlcmllcy4KCj4gSSBuZXZlciBj bGFpbWVkIEtWTSBjb2RlIHdhcyB0byBibGFtZSwgeW91IHNob3VsZCBrbm93IG1lIGJldHRlciBi eQo+IG5vdyEKCk1heWJlIGl0ICppcyogdG8gYmxhbWUsIGFuZCBJJ2QgcmVhbGx5IGxpa2UgdG8g a25vdy4KCj4gPiBmb3IgYSBudW1iZXIgb2YgcmVhc29uczoKPiA+IAo+ID4gLSBLVk0gaGFuZ2lu ZyBpcyB1c3VhbGx5IGEgc2lnbiB0aGF0IHlvdSBoYXZlIGRlc2NyaWJlZCB0aGUgcGxhdGZvcm0K PiA+ICAgdGhlIHdyb25nIHdheS4gRWl0aGVyIHlvdSBhcmUgc3RlcHBpbmcgb3ZlciByZXNlcnZl ZCBtZW1vcnkgcmVnaW9ucywKPiA+ICAgb3IgeW91IGhhdmUgYmFkbHkgZGVzY3JpYmVkIHRoZSBH SUMgaXRzZWxmLgo+IAo+IFRoaXMgd2hvbGUgc2VyaWVzIGlzIGFib3V0IGEgbmV3IERUIGhhcmR3 YXJlIGRlc2NyaXB0aW9uLCBzbyB5ZXMsIHRoYXQKPiBpcyB0aGUgbW9zdCBsaWtlbHkgc291cmNl IG9mIHRoZSBwcm9ibGVtIEknbSBvYnNlcnZpbmcuIFdpdGhvdXQgZnVydGhlcgo+IGhpbnRzIGhv dyB0byB2ZXJpZnkgd2hhdCBtYXkgY2F1c2UgaXQsIHlvdSdyZSBqdXN0IHN0YXRpbmcgdGhlIG9i dmlvdXMuCj4KPiBUaGUgb25seSAvcmVzZXJ2ZWQtbWVtb3J5IGVudHJpZXMgaW4gdGhlIHNoaXBw aW5nIERUQiBhcmUgZHJtLWxvZ28gb2YKPiBzaXplIDAgYW5kIHJhbW9vcHMgLSB0aGUgbGF0dGVy IEkgY291bGQgdHJ5IHRvIHRlc3QsIGJ1dCBJJ2QgYXNzdW1lIHRoYXQKPiB0byBqdXN0IGJlIGEg c29mdHdhcmUgY29udmVudGlvbiB0aGF0IGZvciBsYWNrIG9mIG9vcHMgc2hvdWxkIG5vdCBhZmZl Y3QKPiBLVk0gaGVyZT8KPiAKPiBBbmQgd2h5IHdvdWxkIHJlc2VydmVkIG1lbW9yeSBhZmZlY3Qg dGhlIHZHSUMgYnV0IG5vIG90aGVyIGRyaXZlciBkb2luZwo+IGFsbG9jYXRpb25zPyBBbnkgd2F5 IHRvIG5hcnJvdyBpdCBkb3duLCBkb2VzIHZHSUMgYWxsb2NhdGUgc3BlY2lhbGx5PwoKTm90IGFu IGV4aXN0aW5nIHJlc2VydmVkIG1lbW9yeSwgYnV0IGluc3RlYWQgdGhlIGxhY2sgb2YgYSByZXNl cnZlZAptZW1vcnkgZGVzY3JpcHRpb24gaW4gdGhlIERULCBvbiB3aGljaCBLVk0gd291bGQgaGFw cGlseSBzdGVwIGFzIHBhcnQKb2YgaXRzIG93biBhbGxvY2F0aW9ucy4gSGF2aW5nIGEgd29ya2lu ZyB2R0lDIGFkZHMgYSBzdWJzdGFudGlhbAphbW91bnQgb2YgY29kZSBwYXRocyBhbmQgKHN1cnBy aXNlISkgaW50ZXJydXB0IGhhbmRsaW5nLgoKPiBPbmx5IG90aGVyIGlzc3VlIEknbSBzZWVpbmcg aXMgRGViaWFuIGZhaWxpbmcgdG8gbW91bnQgcGFydGl0aW9ucyB0aGF0IEkKPiBjaGVja2VkIEkg ZG8gaGF2ZSBkcml2ZXJzIGJ1aWx0IGluIGZvciBhbmQgZW5kcyB1cCBmYWlsaW5nIHRvIHByb3Zp ZGUgYW4KPiBlbWVyZ2VuY3kgc2hlbGwuIEluIG9yZGVyIHRvIGJvb3QgYSBjbGVhbiBvcGVuU1VT RSByb290ZnMgZm9yIGNvbXBhcmlzb24KPiBJJ2QgZmlyc3QgbmVlZCB0byBmaWd1cmUgb3V0IGFk ZGluZyBhbnkgVVNCIGhvc3Qgbm9kZXMgYW5kIGNsb2Nrcy4KPiAKPiA+IAo+ID4gLSBJdCBjb3Vs ZCBhbHNvIGJlIGEgYnVnIGluIEtWTSwgd2hpY2ggd2lsbCBuZWVkIHRvIGJlIGZpeGVkLiBJZgo+ ID4gICB0aGF0J3MgYmVjYXVzZSB0aGUgSFcgaXMgYnJva2VuLCB3ZSBuZWVkIHRvIGJlIGFibGUg dG8gZGV0ZWN0IGl0Lgo+ID4gCj4gPiAtIFlvdSBjYW5ub3QgYmUgcHJlc2NyaXB0aXZlIG9mIHdo YXQgYSB1c2VyIGlzIGdvaW5nIHRvIHJ1bi4gUGVvcGxlCj4gPiAgIGhhdmUgYmVlbiBydW5uaW5n IEtWTSBvbiBzeXN0ZW1zIHdpdGggbGVzcyBtZW1vcnkgdGhhbiB0aGF0Lgo+ID4gCj4gPiBTbyBu bywgd2UgZG9uJ3QgcGFwZXIgb3ZlciB0aGVzZSBpc3N1ZXMuCj4gCj4gQXMgeW91IGNhbiBzZWUg aW4gcGF0Y2ggMywgaXQgZG9lcyBpbmNsdWRlIHRoZSB2R0lDIGludGVycnVwdCwgc28gdGhhdAo+ IGFueW9uZSB3aXRoIGFjY2VzcyB0byB0aGUgVEItOTZBSW9UIG9yIGFueSBFVkIgY2FuIHRlc3Qg S1ZNIGFuZCByZXBvcnQKPiBzdWNjZXNzIG9yIGZhaWx1cmUuIFRodXMgSSBkb24ndCBzZWUgbWUg YXMgcGFwZXJpbmcgb3ZlciBzb21ldGhpbmcgaGVyZS4KPiAKPiBIb3dldmVyLCBwYXRjaCA1IGlz IG5lZWRlZCB0byB0ZXN0IHRoaXMgcGF0Y2hzZXQgb24gYXQgbGVhc3QgTTAgLSB0bwo+IGhhdmUg c2VyaWFsIGFuZCBlTU1DIHJvb3RmcyB3b3JraW5nIC0gdW50aWwgYSBiZXR0ZXIgZml4IGlzIGZv dW5kLgoKQW5kIHRoYXQncyBub3QgcGFwZXJpbmcgb3ZlciB0aGUgcHJvYmxlbT8gT0ssIG5ldmVy bWluZC4gTm90IHRvCm1lbnRpb24gdGhhdCB0aGUgR0lDIG5vZGUgaGFzIHNvbWUgb2J2aW91cyBt aXN0YWtlcyB3aGljaCByZXN1bHQgZnJvbQpjb3B5LXBhc3RlLgoKPiA+IFdlIHdvcmsgb3V0IHdo YXQgaXMgZ29pbmcKPiA+IHdyb25nIGFuZCB3ZSBmaXggaXQuCj4gCj4gVGhhbmtzLiBZb3Ugd2Vy ZSBzcGVjaWZpY2FsbHkgY29waWVkIHRvIGFkdmlzZSBvbgo+IGhvdyB0byBmaWd1cmUgb3V0IHdo YXQgbWlnaHQgY2F1c2UgaXQsIHNvIHRoYXQgd2UvSSBjYW4gZml4IGl0IHByb3Blcmx5LiA6KQo+ IAo+IEFzIEkgbWVudGlvbmVkLCBJIGFscmVhZHkgdHJpZWQgY2hhbmdpbmcgdGhlIGludGVycnVw dCBiZXR3ZWVuIGhpZ2ggYW5kCj4gbG93ICh3aGljaCB3YXMgYSBsaWtlbHkgYnVnIHNvdXJjZSBv biBSZWFsdGVrIFJLMTMxOSAod2hlcmUgSSdtIHN0aWxsCj4gd2FpdGluZyBvbiB0aGVtIHRvIGNv bmZpcm0gYSB+eWVhciBsYXRlci4uLikpLgoKV2hpY2ggaGFzIG5vIGluZmx1ZW5jZSBzaW5jZSB0 aGUgR0lDLTUwMCBQUElzIGFyZSBub3QgY29uZmlndXJhYmxlIGluClNXLCBhbmQgdGhlIHByZXNl bmNlIG9mIHRoaXMgYXR0cmlidXRlIGluIHRoZSBEVCBpcyBqdXN0IGZvcgpkb2N1bWVudGF0aW9u LgoKPiBJIGRvbid0IGhhdmUgYSBkYXRhIHNvdXJjZSBvdGhlciB0aGFuIHRoZSBkb3duc3RyZWFt IC5kdGIgdG8gY2hlY2sgdGhlCj4gaW50ZXJydXB0IG51bWJlciAtIG1haW5saW5lIFBYMzAvUksz MzA4L1JLMzMyOC9SSzMzNjgvUkszMzk5IGRvIGFsbCB1c2UKPiA5IGFuZCBoaWdoIGNvbnNpc3Rl bnRseSB0aG91Z2gsIHNvIEkgZmlndXJlZCBpdCdzIGxpa2VseSBjb3JyZWN0Lgo+IAo+IFdoYXQg SSB3YXMgd29uZGVyaW5nIGlzIHdoZXRoZXIgdGhlIHZHSUMsIHNpbWlsYXIgdG8gYXJjaCB0aW1l ciwgbWlnaHQKPiBuZWVkIHNvbWUgaW5pdGlhbGl6YXRpb24gaW4gdGhlIGJvb3Rsb2FkZXI/IChO b3RlOiBObyBVLUJvb3Qgc291cmNlcwo+IGVpdGhlciBhdCB0aGUgbGluay4pCgpBcyBsb25nIGFz IHRoZSBQUElzIGFyZSBzZXQgYXMgZ3JvdXAtMU5TLCB0aGlzIGlzIGVub3VnaC4gWW91IGNhbiBm aW5kCm91dCBieSBkdW1waW5nIHRoZSByZWRpc3RyaWJ1dG9ycycgR0lDUl9JR1JPVVBSMCByZWdp c3RlcnMuIE5vdGhpbmcKZWxzZSBpcyByZXF1aXJlZCBmb3IgdGhlIEdJQyB0byBiZWhhdmUuCgo+ IFVuZm9ydHVuYXRlbHkgSSdtIHNlZWluZyBhIHJlY3VycmluZyBwYXR0ZXJuIChjZi4gUmVhbHRl aykgdGhhdCB2ZW5kb3JzCj4gaW4gdGhlaXIgQlNQcyBkb24ndCBlbmFibGUgS1ZNIGFuZCB0aHVz IGRvbid0IHZhbGlkYXRlIHRoZWlyIGhhcmR3YXJlCj4gZGVzY3JpcHRpb24gYWdhaW5zdCBLVk07 IHRoZWlyIHNoaXBwaW5nIDQuNCBiYXNlZCBrZXJuZWwgaGVyZSBkb2VzIG5vdAo+IHNlZW0gdG8g aGF2ZSBLVk0gZW5hYmxlZC4KPiAKPiBPciBpcyBpdCBwb3NzaWJsZSBmb3IgdmVuZG9ycyB0byBh Y3R1YWxseSBoYXZlIGEgQ29ydGV4LUEzNSB3aXRob3V0IHRoZQo+IEFybXY4IFZpcnR1YWxpemF0 aW9uIEV4dGVuc2lvbnMgaW4gc2lsaWNvbj8gSWYgc28sIGhvdyBjb3VsZCBvbmUgdmVyaWZ5PwoK VGhlcmUgaXMgbm8gIkFybXY4IFZpcnR1YWxpemF0aW9uIEV4dGVuc2lvbnMiLiBUaGVyZSBpcyBv bmx5IEVMMiwgYW5kCnlvdSBhcmUgYWxyZWFkeSBib290aW5nIGF0IHRoYXQgZXhjZXB0aW9uIGxl dmVsLCBvciBLVk0gd291bGRuJ3QgZXZlbgp0cnkgdG8gaW5pdGlhbGlzZS4KCkl0IHdvdWxkIHBy b2JhYmx5IGhlbHAgaWYgeW91IHBvc3RlZCBhIGZ1bGwgZG1lc2cgYXMgd2VsbCBhcyBhZGRlZApz b21lIGJhc2ljIHRyYWNpbmcgaW4gdGhlIHZnaWMgaW5pdCBjb2RlIHNvIHRoYXQgd2UgY2FuIGZp Z3VyZSBvdXQKKndoYXQqIGlzIGdvaW5nIHdyb25nLCBzbyB0aGF0IHdlIGNhbiBhbGwgc3RvcCBt YWtpbmcgaWRsZSBndWVzc2VzLgoKCU0uCgotLSAKV2l0aG91dCBkZXZpYXRpb24gZnJvbSB0aGUg bm9ybSwgcHJvZ3Jlc3MgaXMgbm90IHBvc3NpYmxlLgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KTGludXgtcm9ja2NoaXAgbWFpbGluZyBsaXN0CkxpbnV4 LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E82DEC433ED for ; Mon, 17 May 2021 13:49:17 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F31760FD7 for ; Mon, 17 May 2021 13:49:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F31760FD7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:Cc:To: From:Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cYyq6OVXrjg7tI4iLEVEyXfBMm90qh3AgOus5yVIf+c=; b=CrvhBiCiYQJPx9UDQAS1tSZop 47NP8N4THYp3lRyj/aCHLvDfO8/gSgVNPlsQjB1v6H4h9RcpInPVJV3Jz7ijb6i/sMog0KZgQdL49 JhWW/gpU70SQY3ClfvGWDfgE4vEnsWcj3D2Aw+XaBRca7+d+VCJRXM0CUQNcUofEYYhruZq0tWTD8 +ZyyV4nnytvZgPO5Ee4JqeY727pQafepDH9vEU219/pBt26zWdoIXQpwpeE+J20iV0NfN2072FBc5 fu32VvSq9klLp9+wmUw1mcF7qZO+9UA4Mhv+sG/HrH3OrIBZUn1sCmeQuSlGkXc7cXb0jmNlro/4M V0g6KzsEQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lidW1-00F7Js-HI; Mon, 17 May 2021 13:42:37 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lidVv-00F7Ia-5f; Mon, 17 May 2021 13:42:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Subject:Cc:To:From: Message-ID:Date:Sender:Reply-To:Content-ID:Content-Description; bh=tar0YP1erk1H9y06ox3BwB8G/cI+kvFKfW/bopFxcPw=; b=ywyCbPi1eygmKq8wPl2cNZOq8X EFKRlLYFo5+qbES2Juiszf/S4Mqj/WUl0W/ofamMbDUDgWrXF+YP54JkzU7TIjYKU/KSGgUaePniK tAIHP94Hhv3+sP35+9BtWjTJqIqMCp001iIHt9wXKTGXwwZQCh6ne7CkHWfRNhAAoZQPbMpPOuvCf odXyzwY78moVT+V32xh9KQYYkmgtfZGFMnnFMxjSdG1mq9/z4v4d/LGc+yqv3177O8Xyz79E2hVZZ svAbFIizB+DOZTBepBrLy4Le0YMbkk0tSpAUMhuGAwaYnhOfiqeNDPfu0BUoK8UOQpTItRPUhTtK/ 6TuY02Rg==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lidVq-00Do9E-35; Mon, 17 May 2021 13:42:29 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9B702611BD; Mon, 17 May 2021 13:42:25 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lidVn-001odN-Hc; Mon, 17 May 2021 14:42:23 +0100 Date: Mon, 17 May 2021 14:42:22 +0100 Message-ID: <87eee5v5mp.wl-maz@kernel.org> From: Marc Zyngier To: Andreas =?UTF-8?B?RsOkcmJlcg==?= Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring Subject: Re: [PATCH 0/9] arm64: dts: rockchip: Initial Toybrick TB-RK1808M0 support In-Reply-To: References: <20210516230551.12469-1-afaerber@suse.de> <87im3hvikv.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: afaerber@suse.de, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210517_064226_199264_6398623B X-CRM114-Status: GOOD ( 56.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org QW5kcmVhcywKCk9uIE1vbiwgMTcgTWF5IDIwMjEgMTM6MjI6MjcgKzAxMDAsCkFuZHJlYXMgRsOk cmJlciA8YWZhZXJiZXJAc3VzZS5kZT4gd3JvdGU6Cj4gCj4gSGkgTWFyYywKPiAKPiBPbiAxNy4w NS4yMSAxMTowMiwgTWFyYyBaeW5naWVyIHdyb3RlOgo+ID4gT24gTW9uLCAxNyBNYXkgMjAyMSAw MDowNTo0MiArMDEwMCwKPiA+IEFuZHJlYXMgRsOkcmJlciA8YWZhZXJiZXJAc3VzZS5kZT4gd3Jv dGU6Cj4gPj4gUGF0Y2hlcyBhcmUgYmFzZWQgb24gdGhlIHNoaXBwaW5nIHRveWJyaWNrLmR0YiBm aWxlLgo+IAo+ID4+IGh0dHA6Ly90LnJvY2stY2hpcHMuY29tL2VuL3dpa2kucGhwP21vZD12aWV3 JmlkPTExMCBnaXZlcyBpbnN0cnVjdGlvbnMgZm9yCj4gCj4gPj4gY29tcGlsaW5nIHNvdXJjZXMs IGJ1dCBubyBzb3VyY2UgZG93bmxvYWQgb3IgbGluayBpcyBhY3R1YWxseSBwcm92aWRlZC4KPiAK PiA+PiAKPiAKPiA+PiBJIGVuY291bnRlcmVkIGEgaGFuZzogZWFybHljb24gcmV2ZWFsZWQgaXQg YmVpbmcgcmVsYXRlZCB0byBLVk0gYW5kCj4gPj4gdkdJQy4gIERpc2FibGluZyBLVk0gaW4gS2Nv bmZpZyB3b3JrcyBhcm91bmQgaXQsIGFzIGRvZXMgcmVtb3ZpbmcKPiA+PiB0aGUgdkdJQyBpcnEg aW4gRFQuICBJJ3ZlIGFscmVhZHkgdHJpZWQgbG93IGFuZCBoaWdoIGZvciB0aGUgdkdJQwo+ID4+ IGludGVycnVwdCwgc28gbm8gY2x1ZSB3aGF0IG1pZ2h0IGNhdXNlIGl0LiBPbiBhbiBtUENJZSBj YXJkIHdpdGggMQo+ID4+IEdpQiBvZiBSQU0gSSBmaWd1cmVkIEtWTSBpcyBub3QgZ29pbmcgdG8g YmUgYSBtYWpvciB1c2UgY2FzZSwgc28gaWYKPiA+PiB3ZSBmaW5kIG5vIG90aGVyIHNvbHV0aW9u LCB3ZSBjb3VsZCBqdXN0IGRlbGV0ZSB0aGUgaW50ZXJydXB0cwo+ID4+IHByb3BlcnR5IGluIGl0 cyAuZHRzLCBhcyBkZW1vbnN0cmF0ZWQgaGVyZS4KPiA+IAo+ID4gSSB0aGluayB5b3UgZmlndXJl ZCBpdCBvdXQgd3JvbmcsCj4gCj4gRGlkIEk/IEkgaWRlbnRpZmllZCB0aGF0IGFuIGlzc3VlIHJl c3VsdGluZyBpbiBubyBzZXJpYWwgY29uc29sZSB3YXMKPiBkZXBlbmRlbnQgb24gQ09ORklHX0tW TSBiZWluZyBlbmFibGVkIGFuZCBzcGVjaWZpY2FsbHkgdG8gdGhlIHZHSUMKPiBpbnRlcnJ1cHQg YmVpbmcgc3BlY2lmaWVkIGluIG15IERULiBUaGF0J3MgYWxsIEkgc2FpZC4KCkkgZ3Vlc3Mgd2Ug aGF2ZSBhIGRpZmZlcmVudCB3YXkgdG8gYXBwcm9hY2ggdGhlc2UgaXNzdWVzLiBSYXRoZXIgdGhh bgpkaXNhYmxpbmcgYSBmZWF0dXJlLCBJIHdvdWxkIGhhdmUgcmVhY2hlZCBvdXQgdG8gbmFycm93 IHRoZSBwcm9ibGVtCmRvd24gKmJlZm9yZSogcG9zdGluZyBhIHNlcmllcy4KCj4gSSBuZXZlciBj bGFpbWVkIEtWTSBjb2RlIHdhcyB0byBibGFtZSwgeW91IHNob3VsZCBrbm93IG1lIGJldHRlciBi eQo+IG5vdyEKCk1heWJlIGl0ICppcyogdG8gYmxhbWUsIGFuZCBJJ2QgcmVhbGx5IGxpa2UgdG8g a25vdy4KCj4gPiBmb3IgYSBudW1iZXIgb2YgcmVhc29uczoKPiA+IAo+ID4gLSBLVk0gaGFuZ2lu ZyBpcyB1c3VhbGx5IGEgc2lnbiB0aGF0IHlvdSBoYXZlIGRlc2NyaWJlZCB0aGUgcGxhdGZvcm0K PiA+ICAgdGhlIHdyb25nIHdheS4gRWl0aGVyIHlvdSBhcmUgc3RlcHBpbmcgb3ZlciByZXNlcnZl ZCBtZW1vcnkgcmVnaW9ucywKPiA+ICAgb3IgeW91IGhhdmUgYmFkbHkgZGVzY3JpYmVkIHRoZSBH SUMgaXRzZWxmLgo+IAo+IFRoaXMgd2hvbGUgc2VyaWVzIGlzIGFib3V0IGEgbmV3IERUIGhhcmR3 YXJlIGRlc2NyaXB0aW9uLCBzbyB5ZXMsIHRoYXQKPiBpcyB0aGUgbW9zdCBsaWtlbHkgc291cmNl IG9mIHRoZSBwcm9ibGVtIEknbSBvYnNlcnZpbmcuIFdpdGhvdXQgZnVydGhlcgo+IGhpbnRzIGhv dyB0byB2ZXJpZnkgd2hhdCBtYXkgY2F1c2UgaXQsIHlvdSdyZSBqdXN0IHN0YXRpbmcgdGhlIG9i dmlvdXMuCj4KPiBUaGUgb25seSAvcmVzZXJ2ZWQtbWVtb3J5IGVudHJpZXMgaW4gdGhlIHNoaXBw aW5nIERUQiBhcmUgZHJtLWxvZ28gb2YKPiBzaXplIDAgYW5kIHJhbW9vcHMgLSB0aGUgbGF0dGVy IEkgY291bGQgdHJ5IHRvIHRlc3QsIGJ1dCBJJ2QgYXNzdW1lIHRoYXQKPiB0byBqdXN0IGJlIGEg c29mdHdhcmUgY29udmVudGlvbiB0aGF0IGZvciBsYWNrIG9mIG9vcHMgc2hvdWxkIG5vdCBhZmZl Y3QKPiBLVk0gaGVyZT8KPiAKPiBBbmQgd2h5IHdvdWxkIHJlc2VydmVkIG1lbW9yeSBhZmZlY3Qg dGhlIHZHSUMgYnV0IG5vIG90aGVyIGRyaXZlciBkb2luZwo+IGFsbG9jYXRpb25zPyBBbnkgd2F5 IHRvIG5hcnJvdyBpdCBkb3duLCBkb2VzIHZHSUMgYWxsb2NhdGUgc3BlY2lhbGx5PwoKTm90IGFu IGV4aXN0aW5nIHJlc2VydmVkIG1lbW9yeSwgYnV0IGluc3RlYWQgdGhlIGxhY2sgb2YgYSByZXNl cnZlZAptZW1vcnkgZGVzY3JpcHRpb24gaW4gdGhlIERULCBvbiB3aGljaCBLVk0gd291bGQgaGFw cGlseSBzdGVwIGFzIHBhcnQKb2YgaXRzIG93biBhbGxvY2F0aW9ucy4gSGF2aW5nIGEgd29ya2lu ZyB2R0lDIGFkZHMgYSBzdWJzdGFudGlhbAphbW91bnQgb2YgY29kZSBwYXRocyBhbmQgKHN1cnBy aXNlISkgaW50ZXJydXB0IGhhbmRsaW5nLgoKPiBPbmx5IG90aGVyIGlzc3VlIEknbSBzZWVpbmcg aXMgRGViaWFuIGZhaWxpbmcgdG8gbW91bnQgcGFydGl0aW9ucyB0aGF0IEkKPiBjaGVja2VkIEkg ZG8gaGF2ZSBkcml2ZXJzIGJ1aWx0IGluIGZvciBhbmQgZW5kcyB1cCBmYWlsaW5nIHRvIHByb3Zp ZGUgYW4KPiBlbWVyZ2VuY3kgc2hlbGwuIEluIG9yZGVyIHRvIGJvb3QgYSBjbGVhbiBvcGVuU1VT RSByb290ZnMgZm9yIGNvbXBhcmlzb24KPiBJJ2QgZmlyc3QgbmVlZCB0byBmaWd1cmUgb3V0IGFk ZGluZyBhbnkgVVNCIGhvc3Qgbm9kZXMgYW5kIGNsb2Nrcy4KPiAKPiA+IAo+ID4gLSBJdCBjb3Vs ZCBhbHNvIGJlIGEgYnVnIGluIEtWTSwgd2hpY2ggd2lsbCBuZWVkIHRvIGJlIGZpeGVkLiBJZgo+ ID4gICB0aGF0J3MgYmVjYXVzZSB0aGUgSFcgaXMgYnJva2VuLCB3ZSBuZWVkIHRvIGJlIGFibGUg dG8gZGV0ZWN0IGl0Lgo+ID4gCj4gPiAtIFlvdSBjYW5ub3QgYmUgcHJlc2NyaXB0aXZlIG9mIHdo YXQgYSB1c2VyIGlzIGdvaW5nIHRvIHJ1bi4gUGVvcGxlCj4gPiAgIGhhdmUgYmVlbiBydW5uaW5n IEtWTSBvbiBzeXN0ZW1zIHdpdGggbGVzcyBtZW1vcnkgdGhhbiB0aGF0Lgo+ID4gCj4gPiBTbyBu bywgd2UgZG9uJ3QgcGFwZXIgb3ZlciB0aGVzZSBpc3N1ZXMuCj4gCj4gQXMgeW91IGNhbiBzZWUg aW4gcGF0Y2ggMywgaXQgZG9lcyBpbmNsdWRlIHRoZSB2R0lDIGludGVycnVwdCwgc28gdGhhdAo+ IGFueW9uZSB3aXRoIGFjY2VzcyB0byB0aGUgVEItOTZBSW9UIG9yIGFueSBFVkIgY2FuIHRlc3Qg S1ZNIGFuZCByZXBvcnQKPiBzdWNjZXNzIG9yIGZhaWx1cmUuIFRodXMgSSBkb24ndCBzZWUgbWUg YXMgcGFwZXJpbmcgb3ZlciBzb21ldGhpbmcgaGVyZS4KPiAKPiBIb3dldmVyLCBwYXRjaCA1IGlz IG5lZWRlZCB0byB0ZXN0IHRoaXMgcGF0Y2hzZXQgb24gYXQgbGVhc3QgTTAgLSB0bwo+IGhhdmUg c2VyaWFsIGFuZCBlTU1DIHJvb3RmcyB3b3JraW5nIC0gdW50aWwgYSBiZXR0ZXIgZml4IGlzIGZv dW5kLgoKQW5kIHRoYXQncyBub3QgcGFwZXJpbmcgb3ZlciB0aGUgcHJvYmxlbT8gT0ssIG5ldmVy bWluZC4gTm90IHRvCm1lbnRpb24gdGhhdCB0aGUgR0lDIG5vZGUgaGFzIHNvbWUgb2J2aW91cyBt aXN0YWtlcyB3aGljaCByZXN1bHQgZnJvbQpjb3B5LXBhc3RlLgoKPiA+IFdlIHdvcmsgb3V0IHdo YXQgaXMgZ29pbmcKPiA+IHdyb25nIGFuZCB3ZSBmaXggaXQuCj4gCj4gVGhhbmtzLiBZb3Ugd2Vy ZSBzcGVjaWZpY2FsbHkgY29waWVkIHRvIGFkdmlzZSBvbgo+IGhvdyB0byBmaWd1cmUgb3V0IHdo YXQgbWlnaHQgY2F1c2UgaXQsIHNvIHRoYXQgd2UvSSBjYW4gZml4IGl0IHByb3Blcmx5LiA6KQo+ IAo+IEFzIEkgbWVudGlvbmVkLCBJIGFscmVhZHkgdHJpZWQgY2hhbmdpbmcgdGhlIGludGVycnVw dCBiZXR3ZWVuIGhpZ2ggYW5kCj4gbG93ICh3aGljaCB3YXMgYSBsaWtlbHkgYnVnIHNvdXJjZSBv biBSZWFsdGVrIFJLMTMxOSAod2hlcmUgSSdtIHN0aWxsCj4gd2FpdGluZyBvbiB0aGVtIHRvIGNv bmZpcm0gYSB+eWVhciBsYXRlci4uLikpLgoKV2hpY2ggaGFzIG5vIGluZmx1ZW5jZSBzaW5jZSB0 aGUgR0lDLTUwMCBQUElzIGFyZSBub3QgY29uZmlndXJhYmxlIGluClNXLCBhbmQgdGhlIHByZXNl bmNlIG9mIHRoaXMgYXR0cmlidXRlIGluIHRoZSBEVCBpcyBqdXN0IGZvcgpkb2N1bWVudGF0aW9u LgoKPiBJIGRvbid0IGhhdmUgYSBkYXRhIHNvdXJjZSBvdGhlciB0aGFuIHRoZSBkb3duc3RyZWFt IC5kdGIgdG8gY2hlY2sgdGhlCj4gaW50ZXJydXB0IG51bWJlciAtIG1haW5saW5lIFBYMzAvUksz MzA4L1JLMzMyOC9SSzMzNjgvUkszMzk5IGRvIGFsbCB1c2UKPiA5IGFuZCBoaWdoIGNvbnNpc3Rl bnRseSB0aG91Z2gsIHNvIEkgZmlndXJlZCBpdCdzIGxpa2VseSBjb3JyZWN0Lgo+IAo+IFdoYXQg SSB3YXMgd29uZGVyaW5nIGlzIHdoZXRoZXIgdGhlIHZHSUMsIHNpbWlsYXIgdG8gYXJjaCB0aW1l ciwgbWlnaHQKPiBuZWVkIHNvbWUgaW5pdGlhbGl6YXRpb24gaW4gdGhlIGJvb3Rsb2FkZXI/IChO b3RlOiBObyBVLUJvb3Qgc291cmNlcwo+IGVpdGhlciBhdCB0aGUgbGluay4pCgpBcyBsb25nIGFz IHRoZSBQUElzIGFyZSBzZXQgYXMgZ3JvdXAtMU5TLCB0aGlzIGlzIGVub3VnaC4gWW91IGNhbiBm aW5kCm91dCBieSBkdW1waW5nIHRoZSByZWRpc3RyaWJ1dG9ycycgR0lDUl9JR1JPVVBSMCByZWdp c3RlcnMuIE5vdGhpbmcKZWxzZSBpcyByZXF1aXJlZCBmb3IgdGhlIEdJQyB0byBiZWhhdmUuCgo+ IFVuZm9ydHVuYXRlbHkgSSdtIHNlZWluZyBhIHJlY3VycmluZyBwYXR0ZXJuIChjZi4gUmVhbHRl aykgdGhhdCB2ZW5kb3JzCj4gaW4gdGhlaXIgQlNQcyBkb24ndCBlbmFibGUgS1ZNIGFuZCB0aHVz IGRvbid0IHZhbGlkYXRlIHRoZWlyIGhhcmR3YXJlCj4gZGVzY3JpcHRpb24gYWdhaW5zdCBLVk07 IHRoZWlyIHNoaXBwaW5nIDQuNCBiYXNlZCBrZXJuZWwgaGVyZSBkb2VzIG5vdAo+IHNlZW0gdG8g aGF2ZSBLVk0gZW5hYmxlZC4KPiAKPiBPciBpcyBpdCBwb3NzaWJsZSBmb3IgdmVuZG9ycyB0byBh Y3R1YWxseSBoYXZlIGEgQ29ydGV4LUEzNSB3aXRob3V0IHRoZQo+IEFybXY4IFZpcnR1YWxpemF0 aW9uIEV4dGVuc2lvbnMgaW4gc2lsaWNvbj8gSWYgc28sIGhvdyBjb3VsZCBvbmUgdmVyaWZ5PwoK VGhlcmUgaXMgbm8gIkFybXY4IFZpcnR1YWxpemF0aW9uIEV4dGVuc2lvbnMiLiBUaGVyZSBpcyBv bmx5IEVMMiwgYW5kCnlvdSBhcmUgYWxyZWFkeSBib290aW5nIGF0IHRoYXQgZXhjZXB0aW9uIGxl dmVsLCBvciBLVk0gd291bGRuJ3QgZXZlbgp0cnkgdG8gaW5pdGlhbGlzZS4KCkl0IHdvdWxkIHBy b2JhYmx5IGhlbHAgaWYgeW91IHBvc3RlZCBhIGZ1bGwgZG1lc2cgYXMgd2VsbCBhcyBhZGRlZApz b21lIGJhc2ljIHRyYWNpbmcgaW4gdGhlIHZnaWMgaW5pdCBjb2RlIHNvIHRoYXQgd2UgY2FuIGZp Z3VyZSBvdXQKKndoYXQqIGlzIGdvaW5nIHdyb25nLCBzbyB0aGF0IHdlIGNhbiBhbGwgc3RvcCBt YWtpbmcgaWRsZSBndWVzc2VzLgoKCU0uCgotLSAKV2l0aG91dCBkZXZpYXRpb24gZnJvbSB0aGUg bm9ybSwgcHJvZ3Jlc3MgaXMgbm90IHBvc3NpYmxlLgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8992C433ED for ; Mon, 17 May 2021 13:42:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 933C561209 for ; Mon, 17 May 2021 13:42:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237422AbhEQNnm convert rfc822-to-8bit (ORCPT ); Mon, 17 May 2021 09:43:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:58446 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237408AbhEQNnl (ORCPT ); Mon, 17 May 2021 09:43:41 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9B702611BD; Mon, 17 May 2021 13:42:25 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lidVn-001odN-Hc; Mon, 17 May 2021 14:42:23 +0100 Date: Mon, 17 May 2021 14:42:22 +0100 Message-ID: <87eee5v5mp.wl-maz@kernel.org> From: Marc Zyngier To: Andreas =?UTF-8?B?RsOkcmJlcg==?= Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring Subject: Re: [PATCH 0/9] arm64: dts: rockchip: Initial Toybrick TB-RK1808M0 support In-Reply-To: References: <20210516230551.12469-1-afaerber@suse.de> <87im3hvikv.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: afaerber@suse.de, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Andreas, On Mon, 17 May 2021 13:22:27 +0100, Andreas Färber wrote: > > Hi Marc, > > On 17.05.21 11:02, Marc Zyngier wrote: > > On Mon, 17 May 2021 00:05:42 +0100, > > Andreas Färber wrote: > >> Patches are based on the shipping toybrick.dtb file. > > >> http://t.rock-chips.com/en/wiki.php?mod=view&id=110 gives instructions for > > >> compiling sources, but no source download or link is actually provided. > > >> > > >> I encountered a hang: earlycon revealed it being related to KVM and > >> vGIC. Disabling KVM in Kconfig works around it, as does removing > >> the vGIC irq in DT. I've already tried low and high for the vGIC > >> interrupt, so no clue what might cause it. On an mPCIe card with 1 > >> GiB of RAM I figured KVM is not going to be a major use case, so if > >> we find no other solution, we could just delete the interrupts > >> property in its .dts, as demonstrated here. > > > > I think you figured it out wrong, > > Did I? I identified that an issue resulting in no serial console was > dependent on CONFIG_KVM being enabled and specifically to the vGIC > interrupt being specified in my DT. That's all I said. I guess we have a different way to approach these issues. Rather than disabling a feature, I would have reached out to narrow the problem down *before* posting a series. > I never claimed KVM code was to blame, you should know me better by > now! Maybe it *is* to blame, and I'd really like to know. > > for a number of reasons: > > > > - KVM hanging is usually a sign that you have described the platform > > the wrong way. Either you are stepping over reserved memory regions, > > or you have badly described the GIC itself. > > This whole series is about a new DT hardware description, so yes, that > is the most likely source of the problem I'm observing. Without further > hints how to verify what may cause it, you're just stating the obvious. > > The only /reserved-memory entries in the shipping DTB are drm-logo of > size 0 and ramoops - the latter I could try to test, but I'd assume that > to just be a software convention that for lack of oops should not affect > KVM here? > > And why would reserved memory affect the vGIC but no other driver doing > allocations? Any way to narrow it down, does vGIC allocate specially? Not an existing reserved memory, but instead the lack of a reserved memory description in the DT, on which KVM would happily step as part of its own allocations. Having a working vGIC adds a substantial amount of code paths and (surprise!) interrupt handling. > Only other issue I'm seeing is Debian failing to mount partitions that I > checked I do have drivers built in for and ends up failing to provide an > emergency shell. In order to boot a clean openSUSE rootfs for comparison > I'd first need to figure out adding any USB host nodes and clocks. > > > > > - It could also be a bug in KVM, which will need to be fixed. If > > that's because the HW is broken, we need to be able to detect it. > > > > - You cannot be prescriptive of what a user is going to run. People > > have been running KVM on systems with less memory than that. > > > > So no, we don't paper over these issues. > > As you can see in patch 3, it does include the vGIC interrupt, so that > anyone with access to the TB-96AIoT or any EVB can test KVM and report > success or failure. Thus I don't see me as papering over something here. > > However, patch 5 is needed to test this patchset on at least M0 - to > have serial and eMMC rootfs working - until a better fix is found. And that's not papering over the problem? OK, nevermind. Not to mention that the GIC node has some obvious mistakes which result from copy-paste. > > We work out what is going > > wrong and we fix it. > > Thanks. You were specifically copied to advise on > how to figure out what might cause it, so that we/I can fix it properly. :) > > As I mentioned, I already tried changing the interrupt between high and > low (which was a likely bug source on Realtek RK1319 (where I'm still > waiting on them to confirm a ~year later...)). Which has no influence since the GIC-500 PPIs are not configurable in SW, and the presence of this attribute in the DT is just for documentation. > I don't have a data source other than the downstream .dtb to check the > interrupt number - mainline PX30/RK3308/RK3328/RK3368/RK3399 do all use > 9 and high consistently though, so I figured it's likely correct. > > What I was wondering is whether the vGIC, similar to arch timer, might > need some initialization in the bootloader? (Note: No U-Boot sources > either at the link.) As long as the PPIs are set as group-1NS, this is enough. You can find out by dumping the redistributors' GICR_IGROUPR0 registers. Nothing else is required for the GIC to behave. > Unfortunately I'm seeing a recurring pattern (cf. Realtek) that vendors > in their BSPs don't enable KVM and thus don't validate their hardware > description against KVM; their shipping 4.4 based kernel here does not > seem to have KVM enabled. > > Or is it possible for vendors to actually have a Cortex-A35 without the > Armv8 Virtualization Extensions in silicon? If so, how could one verify? There is no "Armv8 Virtualization Extensions". There is only EL2, and you are already booting at that exception level, or KVM wouldn't even try to initialise. It would probably help if you posted a full dmesg as well as added some basic tracing in the vgic init code so that we can figure out *what* is going wrong, so that we can all stop making idle guesses. M. -- Without deviation from the norm, progress is not possible.