From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E610CC433B4 for ; Sat, 1 May 2021 09:30:33 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 53ED66142B for ; Sat, 1 May 2021 09:30:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53ED66142B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id BFBA64B4F2; Sat, 1 May 2021 05:30:32 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UhRieNvVXaIJ; Sat, 1 May 2021 05:30:30 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4DD934B4DC; Sat, 1 May 2021 05:30:30 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C55744B4DC for ; Sat, 1 May 2021 05:30:28 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f+UH8LZElZjJ for ; Sat, 1 May 2021 05:30:27 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 3BB8F4B4D1 for ; Sat, 1 May 2021 05:30:27 -0400 (EDT) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 32D206141E; Sat, 1 May 2021 09:30:26 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lclx9-00AJhV-T1; Sat, 01 May 2021 10:30:24 +0100 Date: Sat, 01 May 2021 10:30:22 +0100 Message-ID: <87eeeqvm1d.wl-maz@kernel.org> From: Marc Zyngier To: Vikram Sethi Subject: Re: [RFC 1/2] vfio/pci: keep the prefetchable attribute of a BAR region in VMA In-Reply-To: References: <20210429162906.32742-1-sdonthineni@nvidia.com> <20210429162906.32742-2-sdonthineni@nvidia.com> <20210429122840.4f98f78e@redhat.com> <470360a7-0242-9ae5-816f-13608f957bf6@nvidia.com> <20210429134659.321a5c3c@redhat.com> <87czucngdc.wl-maz@kernel.org> <1edb2c4e-23f0-5730-245b-fc6d289951e1@nvidia.com> <878s4zokll.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: vsethi@nvidia.com, sdonthineni@nvidia.com, alex.williamson@redhat.com, will@kernel.org, catalin.marinas@arm.com, christoffer.dall@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, jsequeira@nvidia.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , Catalin Marinas , Shanker Donthineni , Alex Williamson , Jason Sequeira , Will Deacon , "kvmarm@lists.cs.columbia.edu" , "linux-arm-kernel@lists.infradead.org" X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu SGkgVmlrcmFtLAoKT24gRnJpLCAzMCBBcHIgMjAyMSAxNzo1NzoxNCArMDEwMCwKVmlrcmFtIFNl dGhpIDx2c2V0aGlAbnZpZGlhLmNvbT4gd3JvdGU6Cj4gCj4gSGkgTWFyYywgCj4gCj4gPiAtLS0t LU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+ID4gRnJvbTogTWFyYyBaeW5naWVyIDxtYXpAa2VybmVs Lm9yZz4KPiA+IFNlbnQ6IEZyaWRheSwgQXByaWwgMzAsIDIwMjEgMTA6MzEgQU0KPiA+IE9uIEZy aSwgMzAgQXByIDIwMjEgMTU6NTg6MTQgKzAxMDAsCj4gPiBTaGFua2VyIFIgRG9udGhpbmVuaSA8 c2RvbnRoaW5lbmlAbnZpZGlhLmNvbT4gd3JvdGU6Cj4gPiA+Cj4gPiA+IEhpIE1hcmMsCj4gPiA+ Cj4gPiA+IE9uIDQvMzAvMjEgNjo0NyBBTSwgTWFyYyBaeW5naWVyIHdyb3RlOgo+ID4gPiA+Cj4g PiA+ID4+Pj4gV2UndmUgdHdvIGNvbmNlcm5zIGhlcmU6Cj4gPiA+ID4+Pj4gICAgLSBQZXJmb3Jt YW5jZSBpbXBhY3RzIGZvciBwYXNzLXRocm91Z2ggZGV2aWNlcy4KPiA+ID4gPj4+PiAgICAtIFRo ZSBkZWZpbml0aW9uIG9mIGlvcmVtYXBfd2MoKSBmdW5jdGlvbiBkb2Vzbid0IG1hdGNoIHRoZQo+ ID4gPiA+Pj4+IGhvc3Qga2VybmVsIG9uIEFSTTY0Cj4gPiA+ID4+PiBQZXJmb3JtYW5jZSBJIGNh biB1bmRlcnN0YW5kLCBidXQgSSB0aGluayB5b3UncmUgYWxzbyB1c2luZyBpdCB0bwo+ID4gPiA+ Pj4gbWFzayBhIGRyaXZlciBidWcgd2hpY2ggc2hvdWxkIGJlIHJlc29sdmVkIGZpcnN0LiAgVGhh bmsKPiA+ID4gPj4gV2XigJl2ZSBhbHJlYWR5IGluc3RydW1lbnRlZCB0aGUgZHJpdmVyIGNvZGUg YW5kIGZvdW5kIHRoZSBjb2RlIHBhdGgKPiA+ID4gPj4gZm9yIHRoZSB1bmFsaWduZWQgYWNjZXNz ZXMuIFdl4oCZbGwgZml4IHRoaXMgaXNzdWUgaWYgaXTigJlzIG5vdAo+ID4gPiA+PiBmb2xsb3dp bmcgV0Mgc2VtYW50aWNzLgo+ID4gPiA+Pgo+ID4gPiA+PiBGaXhpbmcgdGhlIHBlcmZvcm1hbmNl IGNvbmNlcm4gd2lsbCBiZSB1bmRlciBLVk0gc3RhZ2UtMiBwYWdlLXRhYmxlCj4gPiA+ID4+IGNv bnRyb2wuIFdlJ3JlIGxvb2tpbmcgZm9yIGEgZ3VpZGFuY2Uvc29sdXRpb24gZm9yIHVwZGF0aW5n IHN0YWdlLTIKPiA+ID4gPj4gUFRFIGJhc2VkIG9uIFBDSS1CQVIgYXR0cmlidXRlLgo+ID4gPiA+ IEJlZm9yZSB3ZSBzdGFydCBkaXNjdXNzaW5nIHRoZSAqaG93KiwgSSdkIGxpa2UgdG8gY2xlYXJs eSB1bmRlcnN0YW5kCj4gPiA+ID4gd2hhdCAqYXJtNjQqIG1lbW9yeSBhdHRyaWJ1dGVzIHlvdSBh cmUgcmVseWluZyBvbi4gV2UgYWxyZWFkeSBoYXZlCj4gPiA+ID4gZXN0YWJsaXNoZWQgdGhhdCB0 aGUgdW5hbGlnbmVkIGFjY2VzcyB3YXMgYSBidWcsIHdoaWNoIHdhcyB0aGUKPiA+ID4gPiBiaWdn ZXN0IGFyZ3VtZW50IGluIGZhdm91ciBvZiBOT1JNQUxfTkMuIFdoYXQgYXJlIHRoZSBvdGhlcgo+ ID4gcmVxdWlyZW1lbnRzPwo+ID4gPiBTb3JyeSwgbXkgZWFybGllciByZXNwb25zZSB3YXMgbm90 IGNvbXBsZXRlLi4uCj4gPiA+Cj4gPiA+IEFSTXY4IGFyY2hpdGVjdHVyZSBoYXMgdHdvIGZlYXR1 cmVzIEdhdGhlcmluZyBhbmQgUmVvcmRlcgo+ID4gPiB0cmFuc2FjdGlvbnMsIHZlcnkgaW1wb3J0 YW50IGZyb20gYSBwZXJmb3JtYW5jZSBwb2ludCBvZiB2aWV3LiBTbWFsbAo+ID4gPiBpbmxpbmUg cGFja2V0cyBmb3IgTklDIGNhcmRzIGFuZCBhY2Nlc3NlcyB0byBHUFUncyBmcmFtZSBidWZmZXIg YXJlCj4gPiA+IENQVS1ib3VuZCBvcGVyYXRpb25zLiBXZSB3YW50IHRvIHRha2UgYWR2YW50YWdl cyBvZiBHUkUgZmVhdHVyZXMgdG8KPiA+ID4gYWNoaWV2ZSBoaWdoZXIgcGVyZm9ybWFuY2UuCj4g PiA+Cj4gPiA+IEJvdGggdGhlc2UgZmVhdHVyZXMgYXJlIGRpc2FibGVkIGZvciBwcmVmZXRjaGFi bGUgQkFScyBpbiBWTSBiZWNhdXNlCj4gPiA+IG1lbW9yeS10eXBlIE1UX0RFVklDRV9uR25SRSBl bmZvcmNlZCBpbiBzdGFnZS0yLgo+ID4gCj4gPiBSaWdodCwgc28gTm9ybWFsX05DIGlzIGEgcmVk IGhlcnJpbmcsIGFuZCBpdCBpcyBEZXZpY2VfR1JFIHRoYXQKPiA+IHlvdSByZWFsbHkgYXJlIGFm dGVyLCByaWdodD8KPiA+IAo+IEkgdGhpbmsgRGV2aWNlIEdSRSBoYXMgc29tZSBwcmFjdGljYWwg cHJvYmxlbXMuCj4gMS4gQSBsb3Qgb2YgdXNlcnNwYWNlIGNvZGUgd2hpY2ggaXMgdXNlZCB0byBn ZXR0aW5nIHdyaXRlIGNvbWJpbmVkCj4gbWFwcGluZ3MgdG8gR1BVIG1lbW9yeSBmcm9tIGtlcm5l bCBkcml2ZXJzIGRvZXMgbWVtY3B5L21lbXNldCBvbiBpdAo+IHdoaWNoIGNhbiBpbnNlcnQgbGRw L3N0cCB3aGljaCBjYW4gY3Jhc2ggb24gRGV2aWNlIE1lbW9yeSBUeXBlLiBGcm9tCj4gYSBxdWlj ayBzZWFyY2ggSSBkaWRuJ3QgZmluZCBhIG1lbWNweV9pbyBvciBtZW1zZXRfaW8gaW4KPiBnbGli Yy4gUGVyaGFwcyB0aGVyZSBhcmUgc29tZSBvdGhlciBmdW5jdGlvbnMgYXZhaWxhYmxlLCBidXQg YSBsb3QKPiBvZiB1c2Vyc3BhY2UgYXBwbGljYXRpb25zIHRoYXQgd29yayBvbiB4ODYgYW5kIEFS TSBiYXJlbWV0YWwgd29uJ3QKPiB3b3JrIG9uIEFSTSBWTXMgd2l0aG91dCBzdWNoIGNoYW5nZXMu IENoYW5nZXMgdG8gYWxsIG9mIHVzZXJzcGFjZQo+IG1heSBub3QgYWx3YXlzIGJlIHByYWN0aWNh bCwgc3BlY2lhbGx5IGlmIGxpbmtpbmcgdG8gYmluYXJpZXMKClRoaXMgc2VlbXMgdG8gZ28gYWdh aW5zdCB3aGF0IEFsZXggd2FzIGhpbnRpbmcgYXQgZWFybGllciwgd2hpY2ggaXMKdGhhdCB1bmFs aWduZWQgYWNjZXNzZXMgd2VyZSBub3QgZXhwZWN0ZWQgb24gcHJlZmV0Y2hhYmxlIHJlZ2lvbnMs IGFuZApTaGFua2VyIGxhdHRlciBjb25maXJtaW5nIHRoYXQgaXQgd2FzIGFuIGFjdHVhbCBidWcu IFdoZXJlIGRvIHdlIHN0YW5kCmhlcmU/Cgo+IAo+IDIuIFNvbWV0aW1lcyBldmVuIGlmIGFwcGxp Y2F0aW9uIGlzIG5vdCB1c2luZyBtZW1zZXQvbWVtY3B5IGRpcmVjdGx5LCAKPiBnY2MgbWF5IGlu c2VydCBhIGJ1aWx0aW4gbWVtY3B5L21lbXNldC4gCj4gCj4gMy4gUmVjb21waWxpbmcgYWxsIGFw cGxpY2F0aW9ucyB3aXRoIGdjYyAtbSBzdHJpY3QtYWxpZ24gaGFzCj4gcGVyZm9ybWFuY2UgaXNz dWVzLiAgSW4gb3VyIGV4cGVyaW1lbnRzIHRoYXQgcmVzdWx0ZWQgaW4gYW4gaW5jcmVhc2UKPiBp biBjb2RlIHNpemUsIGFuZCBhbHNvIDMtNSUgcGVyZm9ybWFuY2UgZGVjcmVhc2UgcmVsaWFibHku ICBBbHNvLCBpdAo+IGlzIG5vdCBhbHdheXMgcHJhY3RpY2FsIHRvIHJlY29tcGlsZSBhbGwgb2Yg dXNlcnNwYWNlLCBkZXBlbmRpbmcgb24KPiB3aG8gb3ducyB0aGUgY29kZS9saW5rZWQgYmluYXJp ZXMgZXRjLgo+IAo+IEZyb20gS1ZNLUFSTSBwb2ludCBvZiB2aWV3LCB3aGF0IGlzIGl0IGFib3V0 IE5vcm1hbCBOQyBhdCBzdGFnZSAyCj4gZm9yIFByZWZldGNoYWJsZSBCQVIgKGhvd2V2ZXIgS1ZN IGdldHMgdGhlIGhpbnQsIHdoZXRoZXIgZnJvbQo+IHVzZXJzcGFjZSBvciBWTUEpIHRoYXQgaXMg dW5kZXNpcmFibGUgdnMgRGV2aWNlIEdSRT8gSSBjb3VsZG4ndAo+IHRoaW5rIG9mIGEgZGlmZmVy ZW5jZSB0byBkZXZpY2VzIHdoZXRoZXIgdGhlIGNvbWJpbmluZyBvcgo+IHByZWZldGNoaW5nIG9y IHJlb3JkZXJpbmcgaGFwcGVuZWQgYmVjYXVzZSBvZiBvbmUgb3IgdGhlIG90aGVyLgoKVGhlIHBy b2JsZW0gSSBzZWUgaXMgdGhhdCB3ZSBoYXZlIFZNIGFuZCB1c2Vyc3BhY2UgYmVpbmcgd3JpdHRl biBpbgp0ZXJtcyBvZiBXcml0ZS1Db21iaW5lLCB3aGljaCBpczoKCi0gbG9vc2VseSBkZWZpbmVk IGV2ZW4gb24geDg2CgotIHN1YmplY3QgdG8gaW50ZXJwcmV0YXRpb25zIGluIHRoZSB3YXkgaXQg bWFwcyB0byBQQ0kKCi0gaGFzIG5vIGRpcmVjdCBlcXVpdmFsZW50IGluIHRoZSBBUk12OCBjb2xs ZWN0aW9uIG9mIG1lbW9yeQogIGF0dHJpYnV0ZXMgKGFuZCBOb3JtYWxfTkMgY29tZXMgd2l0aCBz cGVjdWxhdGlvbiBjYXBhYmlsaXRpZXMgd2hpY2gKICBzdHJpa2VzIG1lIGFzIGV4dHJlbWVseSB1 bmRlc2lyYWJsZSBvbiBhcmJpdHJhcnkgZGV2aWNlcykKCkhvdyBkbyB3ZSB0cmFuc2xhdGUgdGhp cyBpbnRvIHNvbWV0aGluZyBjb25zaXN0ZW50PyBJJ2QgbGlrZSB0byBzZWUgYW4KYWN0dWFsIGRl c2NyaXB0aW9uIG9mIHdoYXQgd2UgKnJlYWxseSogZXhwZWN0IGZyb20gV0Mgb24gcHJlZmV0Y2hh YmxlClBDSSByZWdpb25zLCB0dXJuIHRoYXQgaW50byBhIGRvY3VtZW50ZWQgZGVmaW5pdGlvbiBh Z3JlZWQgYWNyb3NzCmFyY2hpdGVjdHVyZXMsIGFuZCB0aGVuIHdlIGNhbiBsb29rIGF0IGltcGxl bWVudGluZyBpdCB3aXRoIG9uZSBtZW1vcnkKdHlwZSBvciBhbm90aGVyIG9uIGFybTY0LgoKQmVj YXVzZSBvbmNlIHdlIGV4cG9zZSB0aGF0IG1lbW9yeSB0eXBlIGF0IFMyIGZvciBLVk0gZ3Vlc3Rz LCBpdApiZWNvbWVzIEFCSSBhbmQgdGhlcmUgaXMgbm8gdHVybmluZyBiYWNrLiBTbyBJIHdhbnQg dG8gZ2V0IGl0IHJpZ2h0Cm9uY2UgYW5kIGZvciBhbGwuCgpUaGFua3MsCgoJTS4KCi0tIApXaXRo b3V0IGRldmlhdGlvbiBmcm9tIHRoZSBub3JtLCBwcm9ncmVzcyBpcyBub3QgcG9zc2libGUuCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmt2bWFybSBtYWls aW5nIGxpc3QKa3ZtYXJtQGxpc3RzLmNzLmNvbHVtYmlhLmVkdQpodHRwczovL2xpc3RzLmNzLmNv bHVtYmlhLmVkdS9tYWlsbWFuL2xpc3RpbmZvL2t2bWFybQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DB8BC433ED for ; Sat, 1 May 2021 09:32:32 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 17007606A5 for ; Sat, 1 May 2021 09:32:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17007606A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:Cc:To: From:Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hw97yMJASFZAhwnNHFy5m2TnVnWhX+QMUnBwuC338xk=; b=aOP5zSzJZA+CtezXH+JmbyPBE WZKCuossfX+2xklG1wfzh2QTipAP4k8KUy8aKAI41CXK1AVL99B3c3G5jI92b+FOL7p3Ym3ijL8v8 pXlg+iJll4Yf2jb3GYWx54hhkgoqhD+DwqSwtQbK9zwOwGzotG3TdCEJUFJ/Ec383Z72DCOd4ijXp mS4MFDwHEeGSWUJsaDLww9heu00gJEH0IAcpux416hqW8y/bdE9l2l81/Xgg97xehICDXFMLWJbHM es6amqIABE3GXnWlnHipT+4MTm0MCon94dzdgMQDlcVcUar1OTz4oHw9rPBU98/aoTbM6lC1sudmz sRbM7nzWg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lclxK-009o2G-Ig; Sat, 01 May 2021 09:30:34 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lclxF-009o1g-FB for linux-arm-kernel@desiato.infradead.org; Sat, 01 May 2021 09:30:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Subject:Cc:To:From: Message-ID:Date:Sender:Reply-To:Content-ID:Content-Description; bh=4FJzcBxnPtCb8i7wHr/uyU+IzqVxR4tIfLIKGz461UA=; b=Y/xwYhu2XCvW5df8NpkoB71Rm6 DFuzuMcOOjyU5AfwE8U2tPmRRoPUZ7MfHn4L9jgi4u4RiabFFMrhcJDnp0+1rLC6LOCvfUi9vwy9g Df3Pa50FvKVRrc2ZK0iPsSRq2KRmEjktiG33h90aYHxPtZq9hpRMQRbJDkTKCTL0PtGegYuoygjNE Ga6mg+nHuwabuA+yH33lBxUmDsut/iWcWwrzr00iZJVkGJUaACUDDO2S6MEcHQP3YKJ0lR1b7NIlX sxwA0GYH3omVxDgFDePCxI2dKvux7Z6DdhvnsE0Dqt2f8YvOwBQnOKScfPxzs0HHBfVWcrUbahxmd xw3Osq3w==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lclxC-001upw-P0 for linux-arm-kernel@lists.infradead.org; Sat, 01 May 2021 09:30:28 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 32D206141E; Sat, 1 May 2021 09:30:26 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lclx9-00AJhV-T1; Sat, 01 May 2021 10:30:24 +0100 Date: Sat, 01 May 2021 10:30:22 +0100 Message-ID: <87eeeqvm1d.wl-maz@kernel.org> From: Marc Zyngier To: Vikram Sethi Cc: Shanker Donthineni , Alex Williamson , Will Deacon , Catalin Marinas , Christoffer Dall , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.cs.columbia.edu" , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , Jason Sequeira Subject: Re: [RFC 1/2] vfio/pci: keep the prefetchable attribute of a BAR region in VMA In-Reply-To: References: <20210429162906.32742-1-sdonthineni@nvidia.com> <20210429162906.32742-2-sdonthineni@nvidia.com> <20210429122840.4f98f78e@redhat.com> <470360a7-0242-9ae5-816f-13608f957bf6@nvidia.com> <20210429134659.321a5c3c@redhat.com> <87czucngdc.wl-maz@kernel.org> <1edb2c4e-23f0-5730-245b-fc6d289951e1@nvidia.com> <878s4zokll.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: vsethi@nvidia.com, sdonthineni@nvidia.com, alex.williamson@redhat.com, will@kernel.org, catalin.marinas@arm.com, christoffer.dall@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, jsequeira@nvidia.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210501_023026_875928_E0056BBF X-CRM114-Status: GOOD ( 45.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgVmlrcmFtLAoKT24gRnJpLCAzMCBBcHIgMjAyMSAxNzo1NzoxNCArMDEwMCwKVmlrcmFtIFNl dGhpIDx2c2V0aGlAbnZpZGlhLmNvbT4gd3JvdGU6Cj4gCj4gSGkgTWFyYywgCj4gCj4gPiAtLS0t LU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+ID4gRnJvbTogTWFyYyBaeW5naWVyIDxtYXpAa2VybmVs Lm9yZz4KPiA+IFNlbnQ6IEZyaWRheSwgQXByaWwgMzAsIDIwMjEgMTA6MzEgQU0KPiA+IE9uIEZy aSwgMzAgQXByIDIwMjEgMTU6NTg6MTQgKzAxMDAsCj4gPiBTaGFua2VyIFIgRG9udGhpbmVuaSA8 c2RvbnRoaW5lbmlAbnZpZGlhLmNvbT4gd3JvdGU6Cj4gPiA+Cj4gPiA+IEhpIE1hcmMsCj4gPiA+ Cj4gPiA+IE9uIDQvMzAvMjEgNjo0NyBBTSwgTWFyYyBaeW5naWVyIHdyb3RlOgo+ID4gPiA+Cj4g PiA+ID4+Pj4gV2UndmUgdHdvIGNvbmNlcm5zIGhlcmU6Cj4gPiA+ID4+Pj4gICAgLSBQZXJmb3Jt YW5jZSBpbXBhY3RzIGZvciBwYXNzLXRocm91Z2ggZGV2aWNlcy4KPiA+ID4gPj4+PiAgICAtIFRo ZSBkZWZpbml0aW9uIG9mIGlvcmVtYXBfd2MoKSBmdW5jdGlvbiBkb2Vzbid0IG1hdGNoIHRoZQo+ ID4gPiA+Pj4+IGhvc3Qga2VybmVsIG9uIEFSTTY0Cj4gPiA+ID4+PiBQZXJmb3JtYW5jZSBJIGNh biB1bmRlcnN0YW5kLCBidXQgSSB0aGluayB5b3UncmUgYWxzbyB1c2luZyBpdCB0bwo+ID4gPiA+ Pj4gbWFzayBhIGRyaXZlciBidWcgd2hpY2ggc2hvdWxkIGJlIHJlc29sdmVkIGZpcnN0LiAgVGhh bmsKPiA+ID4gPj4gV2XigJl2ZSBhbHJlYWR5IGluc3RydW1lbnRlZCB0aGUgZHJpdmVyIGNvZGUg YW5kIGZvdW5kIHRoZSBjb2RlIHBhdGgKPiA+ID4gPj4gZm9yIHRoZSB1bmFsaWduZWQgYWNjZXNz ZXMuIFdl4oCZbGwgZml4IHRoaXMgaXNzdWUgaWYgaXTigJlzIG5vdAo+ID4gPiA+PiBmb2xsb3dp bmcgV0Mgc2VtYW50aWNzLgo+ID4gPiA+Pgo+ID4gPiA+PiBGaXhpbmcgdGhlIHBlcmZvcm1hbmNl IGNvbmNlcm4gd2lsbCBiZSB1bmRlciBLVk0gc3RhZ2UtMiBwYWdlLXRhYmxlCj4gPiA+ID4+IGNv bnRyb2wuIFdlJ3JlIGxvb2tpbmcgZm9yIGEgZ3VpZGFuY2Uvc29sdXRpb24gZm9yIHVwZGF0aW5n IHN0YWdlLTIKPiA+ID4gPj4gUFRFIGJhc2VkIG9uIFBDSS1CQVIgYXR0cmlidXRlLgo+ID4gPiA+ IEJlZm9yZSB3ZSBzdGFydCBkaXNjdXNzaW5nIHRoZSAqaG93KiwgSSdkIGxpa2UgdG8gY2xlYXJs eSB1bmRlcnN0YW5kCj4gPiA+ID4gd2hhdCAqYXJtNjQqIG1lbW9yeSBhdHRyaWJ1dGVzIHlvdSBh cmUgcmVseWluZyBvbi4gV2UgYWxyZWFkeSBoYXZlCj4gPiA+ID4gZXN0YWJsaXNoZWQgdGhhdCB0 aGUgdW5hbGlnbmVkIGFjY2VzcyB3YXMgYSBidWcsIHdoaWNoIHdhcyB0aGUKPiA+ID4gPiBiaWdn ZXN0IGFyZ3VtZW50IGluIGZhdm91ciBvZiBOT1JNQUxfTkMuIFdoYXQgYXJlIHRoZSBvdGhlcgo+ ID4gcmVxdWlyZW1lbnRzPwo+ID4gPiBTb3JyeSwgbXkgZWFybGllciByZXNwb25zZSB3YXMgbm90 IGNvbXBsZXRlLi4uCj4gPiA+Cj4gPiA+IEFSTXY4IGFyY2hpdGVjdHVyZSBoYXMgdHdvIGZlYXR1 cmVzIEdhdGhlcmluZyBhbmQgUmVvcmRlcgo+ID4gPiB0cmFuc2FjdGlvbnMsIHZlcnkgaW1wb3J0 YW50IGZyb20gYSBwZXJmb3JtYW5jZSBwb2ludCBvZiB2aWV3LiBTbWFsbAo+ID4gPiBpbmxpbmUg cGFja2V0cyBmb3IgTklDIGNhcmRzIGFuZCBhY2Nlc3NlcyB0byBHUFUncyBmcmFtZSBidWZmZXIg YXJlCj4gPiA+IENQVS1ib3VuZCBvcGVyYXRpb25zLiBXZSB3YW50IHRvIHRha2UgYWR2YW50YWdl cyBvZiBHUkUgZmVhdHVyZXMgdG8KPiA+ID4gYWNoaWV2ZSBoaWdoZXIgcGVyZm9ybWFuY2UuCj4g PiA+Cj4gPiA+IEJvdGggdGhlc2UgZmVhdHVyZXMgYXJlIGRpc2FibGVkIGZvciBwcmVmZXRjaGFi bGUgQkFScyBpbiBWTSBiZWNhdXNlCj4gPiA+IG1lbW9yeS10eXBlIE1UX0RFVklDRV9uR25SRSBl bmZvcmNlZCBpbiBzdGFnZS0yLgo+ID4gCj4gPiBSaWdodCwgc28gTm9ybWFsX05DIGlzIGEgcmVk IGhlcnJpbmcsIGFuZCBpdCBpcyBEZXZpY2VfR1JFIHRoYXQKPiA+IHlvdSByZWFsbHkgYXJlIGFm dGVyLCByaWdodD8KPiA+IAo+IEkgdGhpbmsgRGV2aWNlIEdSRSBoYXMgc29tZSBwcmFjdGljYWwg cHJvYmxlbXMuCj4gMS4gQSBsb3Qgb2YgdXNlcnNwYWNlIGNvZGUgd2hpY2ggaXMgdXNlZCB0byBn ZXR0aW5nIHdyaXRlIGNvbWJpbmVkCj4gbWFwcGluZ3MgdG8gR1BVIG1lbW9yeSBmcm9tIGtlcm5l bCBkcml2ZXJzIGRvZXMgbWVtY3B5L21lbXNldCBvbiBpdAo+IHdoaWNoIGNhbiBpbnNlcnQgbGRw L3N0cCB3aGljaCBjYW4gY3Jhc2ggb24gRGV2aWNlIE1lbW9yeSBUeXBlLiBGcm9tCj4gYSBxdWlj ayBzZWFyY2ggSSBkaWRuJ3QgZmluZCBhIG1lbWNweV9pbyBvciBtZW1zZXRfaW8gaW4KPiBnbGli Yy4gUGVyaGFwcyB0aGVyZSBhcmUgc29tZSBvdGhlciBmdW5jdGlvbnMgYXZhaWxhYmxlLCBidXQg YSBsb3QKPiBvZiB1c2Vyc3BhY2UgYXBwbGljYXRpb25zIHRoYXQgd29yayBvbiB4ODYgYW5kIEFS TSBiYXJlbWV0YWwgd29uJ3QKPiB3b3JrIG9uIEFSTSBWTXMgd2l0aG91dCBzdWNoIGNoYW5nZXMu IENoYW5nZXMgdG8gYWxsIG9mIHVzZXJzcGFjZQo+IG1heSBub3QgYWx3YXlzIGJlIHByYWN0aWNh bCwgc3BlY2lhbGx5IGlmIGxpbmtpbmcgdG8gYmluYXJpZXMKClRoaXMgc2VlbXMgdG8gZ28gYWdh aW5zdCB3aGF0IEFsZXggd2FzIGhpbnRpbmcgYXQgZWFybGllciwgd2hpY2ggaXMKdGhhdCB1bmFs aWduZWQgYWNjZXNzZXMgd2VyZSBub3QgZXhwZWN0ZWQgb24gcHJlZmV0Y2hhYmxlIHJlZ2lvbnMs IGFuZApTaGFua2VyIGxhdHRlciBjb25maXJtaW5nIHRoYXQgaXQgd2FzIGFuIGFjdHVhbCBidWcu IFdoZXJlIGRvIHdlIHN0YW5kCmhlcmU/Cgo+IAo+IDIuIFNvbWV0aW1lcyBldmVuIGlmIGFwcGxp Y2F0aW9uIGlzIG5vdCB1c2luZyBtZW1zZXQvbWVtY3B5IGRpcmVjdGx5LCAKPiBnY2MgbWF5IGlu c2VydCBhIGJ1aWx0aW4gbWVtY3B5L21lbXNldC4gCj4gCj4gMy4gUmVjb21waWxpbmcgYWxsIGFw cGxpY2F0aW9ucyB3aXRoIGdjYyAtbSBzdHJpY3QtYWxpZ24gaGFzCj4gcGVyZm9ybWFuY2UgaXNz dWVzLiAgSW4gb3VyIGV4cGVyaW1lbnRzIHRoYXQgcmVzdWx0ZWQgaW4gYW4gaW5jcmVhc2UKPiBp biBjb2RlIHNpemUsIGFuZCBhbHNvIDMtNSUgcGVyZm9ybWFuY2UgZGVjcmVhc2UgcmVsaWFibHku ICBBbHNvLCBpdAo+IGlzIG5vdCBhbHdheXMgcHJhY3RpY2FsIHRvIHJlY29tcGlsZSBhbGwgb2Yg dXNlcnNwYWNlLCBkZXBlbmRpbmcgb24KPiB3aG8gb3ducyB0aGUgY29kZS9saW5rZWQgYmluYXJp ZXMgZXRjLgo+IAo+IEZyb20gS1ZNLUFSTSBwb2ludCBvZiB2aWV3LCB3aGF0IGlzIGl0IGFib3V0 IE5vcm1hbCBOQyBhdCBzdGFnZSAyCj4gZm9yIFByZWZldGNoYWJsZSBCQVIgKGhvd2V2ZXIgS1ZN IGdldHMgdGhlIGhpbnQsIHdoZXRoZXIgZnJvbQo+IHVzZXJzcGFjZSBvciBWTUEpIHRoYXQgaXMg dW5kZXNpcmFibGUgdnMgRGV2aWNlIEdSRT8gSSBjb3VsZG4ndAo+IHRoaW5rIG9mIGEgZGlmZmVy ZW5jZSB0byBkZXZpY2VzIHdoZXRoZXIgdGhlIGNvbWJpbmluZyBvcgo+IHByZWZldGNoaW5nIG9y IHJlb3JkZXJpbmcgaGFwcGVuZWQgYmVjYXVzZSBvZiBvbmUgb3IgdGhlIG90aGVyLgoKVGhlIHBy b2JsZW0gSSBzZWUgaXMgdGhhdCB3ZSBoYXZlIFZNIGFuZCB1c2Vyc3BhY2UgYmVpbmcgd3JpdHRl biBpbgp0ZXJtcyBvZiBXcml0ZS1Db21iaW5lLCB3aGljaCBpczoKCi0gbG9vc2VseSBkZWZpbmVk IGV2ZW4gb24geDg2CgotIHN1YmplY3QgdG8gaW50ZXJwcmV0YXRpb25zIGluIHRoZSB3YXkgaXQg bWFwcyB0byBQQ0kKCi0gaGFzIG5vIGRpcmVjdCBlcXVpdmFsZW50IGluIHRoZSBBUk12OCBjb2xs ZWN0aW9uIG9mIG1lbW9yeQogIGF0dHJpYnV0ZXMgKGFuZCBOb3JtYWxfTkMgY29tZXMgd2l0aCBz cGVjdWxhdGlvbiBjYXBhYmlsaXRpZXMgd2hpY2gKICBzdHJpa2VzIG1lIGFzIGV4dHJlbWVseSB1 bmRlc2lyYWJsZSBvbiBhcmJpdHJhcnkgZGV2aWNlcykKCkhvdyBkbyB3ZSB0cmFuc2xhdGUgdGhp cyBpbnRvIHNvbWV0aGluZyBjb25zaXN0ZW50PyBJJ2QgbGlrZSB0byBzZWUgYW4KYWN0dWFsIGRl c2NyaXB0aW9uIG9mIHdoYXQgd2UgKnJlYWxseSogZXhwZWN0IGZyb20gV0Mgb24gcHJlZmV0Y2hh YmxlClBDSSByZWdpb25zLCB0dXJuIHRoYXQgaW50byBhIGRvY3VtZW50ZWQgZGVmaW5pdGlvbiBh Z3JlZWQgYWNyb3NzCmFyY2hpdGVjdHVyZXMsIGFuZCB0aGVuIHdlIGNhbiBsb29rIGF0IGltcGxl bWVudGluZyBpdCB3aXRoIG9uZSBtZW1vcnkKdHlwZSBvciBhbm90aGVyIG9uIGFybTY0LgoKQmVj YXVzZSBvbmNlIHdlIGV4cG9zZSB0aGF0IG1lbW9yeSB0eXBlIGF0IFMyIGZvciBLVk0gZ3Vlc3Rz LCBpdApiZWNvbWVzIEFCSSBhbmQgdGhlcmUgaXMgbm8gdHVybmluZyBiYWNrLiBTbyBJIHdhbnQg dG8gZ2V0IGl0IHJpZ2h0Cm9uY2UgYW5kIGZvciBhbGwuCgpUaGFua3MsCgoJTS4KCi0tIApXaXRo b3V0IGRldmlhdGlvbiBmcm9tIHRoZSBub3JtLCBwcm9ncmVzcyBpcyBub3QgcG9zc2libGUuCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0t a2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2Vy bmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52C00C433ED for ; Sat, 1 May 2021 09:30:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 21EA9613C8 for ; Sat, 1 May 2021 09:30:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231837AbhEAJbQ convert rfc822-to-8bit (ORCPT ); Sat, 1 May 2021 05:31:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:32888 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231713AbhEAJbP (ORCPT ); Sat, 1 May 2021 05:31:15 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 32D206141E; Sat, 1 May 2021 09:30:26 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lclx9-00AJhV-T1; Sat, 01 May 2021 10:30:24 +0100 Date: Sat, 01 May 2021 10:30:22 +0100 Message-ID: <87eeeqvm1d.wl-maz@kernel.org> From: Marc Zyngier To: Vikram Sethi Cc: Shanker Donthineni , Alex Williamson , Will Deacon , Catalin Marinas , Christoffer Dall , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.cs.columbia.edu" , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , Jason Sequeira Subject: Re: [RFC 1/2] vfio/pci: keep the prefetchable attribute of a BAR region in VMA In-Reply-To: References: <20210429162906.32742-1-sdonthineni@nvidia.com> <20210429162906.32742-2-sdonthineni@nvidia.com> <20210429122840.4f98f78e@redhat.com> <470360a7-0242-9ae5-816f-13608f957bf6@nvidia.com> <20210429134659.321a5c3c@redhat.com> <87czucngdc.wl-maz@kernel.org> <1edb2c4e-23f0-5730-245b-fc6d289951e1@nvidia.com> <878s4zokll.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: vsethi@nvidia.com, sdonthineni@nvidia.com, alex.williamson@redhat.com, will@kernel.org, catalin.marinas@arm.com, christoffer.dall@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, jsequeira@nvidia.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi Vikram, On Fri, 30 Apr 2021 17:57:14 +0100, Vikram Sethi wrote: > > Hi Marc, > > > -----Original Message----- > > From: Marc Zyngier > > Sent: Friday, April 30, 2021 10:31 AM > > On Fri, 30 Apr 2021 15:58:14 +0100, > > Shanker R Donthineni wrote: > > > > > > Hi Marc, > > > > > > On 4/30/21 6:47 AM, Marc Zyngier wrote: > > > > > > > >>>> We've two concerns here: > > > >>>> - Performance impacts for pass-through devices. > > > >>>> - The definition of ioremap_wc() function doesn't match the > > > >>>> host kernel on ARM64 > > > >>> Performance I can understand, but I think you're also using it to > > > >>> mask a driver bug which should be resolved first. Thank > > > >> We’ve already instrumented the driver code and found the code path > > > >> for the unaligned accesses. We’ll fix this issue if it’s not > > > >> following WC semantics. > > > >> > > > >> Fixing the performance concern will be under KVM stage-2 page-table > > > >> control. We're looking for a guidance/solution for updating stage-2 > > > >> PTE based on PCI-BAR attribute. > > > > Before we start discussing the *how*, I'd like to clearly understand > > > > what *arm64* memory attributes you are relying on. We already have > > > > established that the unaligned access was a bug, which was the > > > > biggest argument in favour of NORMAL_NC. What are the other > > requirements? > > > Sorry, my earlier response was not complete... > > > > > > ARMv8 architecture has two features Gathering and Reorder > > > transactions, very important from a performance point of view. Small > > > inline packets for NIC cards and accesses to GPU's frame buffer are > > > CPU-bound operations. We want to take advantages of GRE features to > > > achieve higher performance. > > > > > > Both these features are disabled for prefetchable BARs in VM because > > > memory-type MT_DEVICE_nGnRE enforced in stage-2. > > > > Right, so Normal_NC is a red herring, and it is Device_GRE that > > you really are after, right? > > > I think Device GRE has some practical problems. > 1. A lot of userspace code which is used to getting write combined > mappings to GPU memory from kernel drivers does memcpy/memset on it > which can insert ldp/stp which can crash on Device Memory Type. From > a quick search I didn't find a memcpy_io or memset_io in > glibc. Perhaps there are some other functions available, but a lot > of userspace applications that work on x86 and ARM baremetal won't > work on ARM VMs without such changes. Changes to all of userspace > may not always be practical, specially if linking to binaries This seems to go against what Alex was hinting at earlier, which is that unaligned accesses were not expected on prefetchable regions, and Shanker latter confirming that it was an actual bug. Where do we stand here? > > 2. Sometimes even if application is not using memset/memcpy directly, > gcc may insert a builtin memcpy/memset. > > 3. Recompiling all applications with gcc -m strict-align has > performance issues. In our experiments that resulted in an increase > in code size, and also 3-5% performance decrease reliably. Also, it > is not always practical to recompile all of userspace, depending on > who owns the code/linked binaries etc. > > From KVM-ARM point of view, what is it about Normal NC at stage 2 > for Prefetchable BAR (however KVM gets the hint, whether from > userspace or VMA) that is undesirable vs Device GRE? I couldn't > think of a difference to devices whether the combining or > prefetching or reordering happened because of one or the other. The problem I see is that we have VM and userspace being written in terms of Write-Combine, which is: - loosely defined even on x86 - subject to interpretations in the way it maps to PCI - has no direct equivalent in the ARMv8 collection of memory attributes (and Normal_NC comes with speculation capabilities which strikes me as extremely undesirable on arbitrary devices) How do we translate this into something consistent? I'd like to see an actual description of what we *really* expect from WC on prefetchable PCI regions, turn that into a documented definition agreed across architectures, and then we can look at implementing it with one memory type or another on arm64. Because once we expose that memory type at S2 for KVM guests, it becomes ABI and there is no turning back. So I want to get it right once and for all. Thanks, M. -- Without deviation from the norm, progress is not possible.