All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Denis Plotnikov <den-plotnikov@yandex-team.ru>, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, anirban.chakraborty@qlogic.com,
	sony.chacko@qlogic.com, GR-Linux-NIC-Dev@marvell.com,
	helgaas@kernel.org, simon.horman@corigine.com,
	manishc@marvell.com, shshaikh@marvell.com
Subject: Re: [PATCH net-next v2] qlcnic: check pci_reset_function result
Date: Tue, 11 Apr 2023 13:24:33 +0200	[thread overview]
Message-ID: <87eef8a06064dc895f183ba2a1cd649c213f3e37.camel@redhat.com> (raw)
In-Reply-To: <20230407071849.309516-1-den-plotnikov@yandex-team.ru>

On Fri, 2023-04-07 at 10:18 +0300, Denis Plotnikov wrote:
> Static code analyzer complains to unchecked return value.
> The result of pci_reset_function() is unchecked.
> Despite, the issue is on the FLR supported code path and in that
> case reset can be done with pcie_flr(), the patch uses less invasive
> approach by adding the result check of pci_reset_function().
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: 7e2cf4feba05 ("qlcnic: change driver hardware interface mechanism")
> Signed-off-by: Denis Plotnikov <den-plotnikov@yandex-team.ru>

Any special reason to target the net-next tree? This looks like a -net
candidate to me?

Thanks!

Paolo


  parent reply	other threads:[~2023-04-11 11:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-07  7:18 [PATCH net-next v2] qlcnic: check pci_reset_function result Denis Plotnikov
2023-04-07  9:01 ` Simon Horman
2023-04-07 15:31   ` Bjorn Helgaas
2023-04-11 11:24 ` Paolo Abeni [this message]
2023-04-11 11:31   ` Simon Horman
2023-04-12  7:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eef8a06064dc895f183ba2a1cd649c213f3e37.camel@redhat.com \
    --to=pabeni@redhat.com \
    --cc=GR-Linux-NIC-Dev@marvell.com \
    --cc=anirban.chakraborty@qlogic.com \
    --cc=den-plotnikov@yandex-team.ru \
    --cc=helgaas@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manishc@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=shshaikh@marvell.com \
    --cc=simon.horman@corigine.com \
    --cc=sony.chacko@qlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.