From: "Alex Bennée" <alex.bennee@linaro.org>
To: luoyonggang@gmail.com
Cc: Paolo Bonzini <pbonzini@redhat.com>,
"Emilio G . Cota" <cota@braap.org>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-level <qemu-devel@nongnu.org>
Subject: Re: [PATCH v3 0/6] Enable plugin support on msys2/mingw
Date: Wed, 10 Feb 2021 15:10:17 +0000 [thread overview]
Message-ID: <87eehovt7k.fsf@linaro.org> (raw)
In-Reply-To: <CAE2XoE9CgA3MvV9MJnM8bx6JQ0+DU69mqSD0jOFLCvAu5kwwcg@mail.gmail.com>
罗勇刚(Yonggang Luo) <luoyonggang@gmail.com> writes:
> Hi alex, when does plugins/next getting PR
Sorry for the delay. I should be cooking up a pre-PR series this week
once the recent icount/io_recompile fix has been tested and reviewed.
You can see the current state of the tree here:
https://github.com/stsquad/qemu/tree/plugins/next
I'm afraid I've dropped the ball on your plugin patches... I can't seem
to find the v5 series referenced.
>
> On Tue, Oct 6, 2020 at 7:35 PM Alex Bennée <alex.bennee@linaro.org> wrote:
>
>>
>> Yonggang Luo <luoyonggang@gmail.com> writes:
>>
>> > V2-V3
>> > Split following patches out
>> >
>> > V1-V2
>> > 1. Fixes review comments
>> > 2. Increase QEMU_PLUGIN_VERSION to 1 for compat QEMU_PLUGIN_VERSION 0
>> > 3. Revise the loader to support for version 0 and 1
>> > 4. By export function qemu_plugin_initialize in plugin, and call it in
>> loader=
>> > , so
>> > we have no need call it in every plugin. And also provide a standard
>> implem=
>> > entation,
>> > anyway, use can also override it.
>> >
>> > Add this feature on msys2/mingw by using glib provided cross-platform
>> dlsym f=
>> > unctional.
>>
>> I've grabbed the first two fixes into plugins/next for now. Aside from
>> fixing the review comments I'd like to have an indication that the
>> proposed change to the API linking doesn't adversely affect the
>> performance of the plugins.
>>
>> It might be worth enabling a --enable-plugins build for mingw gitlab as
>> Cirrus
>> seems a bit broken at the moment.
>>
>> Thanks,
>>
>>
>> --
>> Alex Bennée
>>
--
Alex Bennée
prev parent reply other threads:[~2021-02-10 15:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 16:34 [PATCH v3 0/6] Enable plugin support on msys2/mingw Yonggang Luo
2020-10-01 16:34 ` [PATCH v3 1/6] plugins: Fixes a issue when dlsym failed, the handle not closed Yonggang Luo
2020-10-05 9:59 ` Alex Bennée
2020-10-01 16:34 ` [PATCH v3 2/6] plugin: Fixes compiling errors on msys2/mingw Yonggang Luo
2020-10-05 10:00 ` Alex Bennée
2020-10-01 16:34 ` [PATCH v3 3/6] cirrus: Enable plugin in cirrus for windows Yonggang Luo
2020-10-05 10:17 ` Alex Bennée
2020-10-01 16:34 ` [PATCH v3 4/6] plugin: define QEMU_PLUGIN_API_IMPLEMENTATION first Yonggang Luo
2020-10-05 10:44 ` Alex Bennée
2020-10-05 15:58 ` 罗勇刚(Yonggang Luo)
2020-10-01 16:34 ` [PATCH v3 5/6] plugin: getting qemu_plugin_get_hwaddr only expose one function prototype Yonggang Luo
2020-10-05 10:48 ` Alex Bennée
2020-10-05 15:34 ` 罗勇刚(Yonggang Luo)
2020-10-05 15:46 ` Alex Bennée
2020-10-01 16:34 ` [PATCH v3 6/6] plugin: Getting qemu-plugin works under win32 Yonggang Luo
2020-10-06 11:29 ` Alex Bennée
2020-10-06 12:08 ` 罗勇刚(Yonggang Luo)
2020-10-06 11:35 ` [PATCH v3 0/6] Enable plugin support on msys2/mingw Alex Bennée
2021-01-27 3:52 ` 罗勇刚(Yonggang Luo)
2021-02-10 15:10 ` Alex Bennée [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eehovt7k.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=cota@braap.org \
--cc=luoyonggang@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.