From: Kalle Valo <kvalo@codeaurora.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Ping-Ke Shih <pkshih@realtek.com>,
Yan-Hsuan Chuang <tony0620emma@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
phhuang@realtek.com
Subject: Re: [PATCH RESEND v3 4/8] rtw88: replace tx tasklet with tx work
Date: Thu, 14 Jan 2021 20:41:37 +0200 [thread overview]
Message-ID: <87eeingy3i.fsf@codeaurora.org> (raw)
In-Reply-To: <CA+ASDXPy784XGyqV-EM2KF_=K58CG6fLdhieZSoxvpbfQC5rvg@mail.gmail.com> (Brian Norris's message of "Thu, 14 Jan 2021 10:34:18 -0800")
Brian Norris <briannorris@chromium.org> writes:
> On Wed, Jan 13, 2021 at 5:45 PM Ping-Ke Shih <pkshih@realtek.com> wrote:
>>
>> From: Po-Hao Huang <phhuang@realtek.com>
>>
>> Move tx tasklet to thread, by this we can reduce time spent on
>> waiting for schedule and have better efficiency.
>>
>> Signed-off-by: Po-Hao Huang <phhuang@realtek.com>
>> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
>
> I'll note here for completeness: I suggested considering a workqueue
> on v2 (I hadn't yet received v3), and Realtek was planning on
> considering that.
A good point, thanks. I also think that reinventing the wheel should be
avoided and instead use existing workqueue framework.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-01-14 18:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 1:09 [PATCH RESEND v3 0/8] rtw88: improve TX performance in field Ping-Ke Shih
2021-01-14 1:09 ` [PATCH RESEND v3 1/8] rtw88: add dynamic rrsr configuration Ping-Ke Shih
2021-01-14 1:09 ` [PATCH RESEND v3 2/8] rtw88: add rts condition Ping-Ke Shih
2021-01-14 1:09 ` [PATCH RESEND v3 3/8] rtw88: add napi support Ping-Ke Shih
2021-01-14 1:09 ` [PATCH RESEND v3 4/8] rtw88: replace tx tasklet with tx work Ping-Ke Shih
2021-01-14 18:34 ` Brian Norris
2021-01-14 18:41 ` Kalle Valo [this message]
2021-01-14 1:09 ` [PATCH RESEND v3 5/8] rtw88: 8822c: update MAC/BB parameter tables to v60 Ping-Ke Shih
2021-01-14 1:09 ` [PATCH RESEND v3 6/8] rtw88: 8822c: update RF_A " Ping-Ke Shih
2021-01-14 1:09 ` [PATCH RESEND v3 7/8] rtw88: 8822c: update RF_B (1/2) " Ping-Ke Shih
2021-01-14 1:09 ` [PATCH RESEND v3 8/8] rtw88: 8822c: update RF_B (2/2) " Ping-Ke Shih
2021-01-14 7:21 ` [PATCH RESEND v3 0/8] rtw88: improve TX performance in field Kalle Valo
2021-01-15 1:17 ` Pkshih
2021-01-15 7:52 ` Kalle Valo
2021-01-15 8:07 ` Pkshih
2021-01-18 14:44 ` Kalle Valo
2021-01-19 2:15 ` Pkshih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eeingy3i.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=briannorris@chromium.org \
--cc=linux-wireless@vger.kernel.org \
--cc=phhuang@realtek.com \
--cc=pkshih@realtek.com \
--cc=tony0620emma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.