From: Kalle Valo <kvalo@codeaurora.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Shyam Sundar S K <shyam-sundar.s-k@amd.com>,
Igor Russkikh <irusskikh@marvell.com>,
Iyappan Subramanian <iyappan@os.amperecomputing.com>,
GR-everest-linux-l2@marvell.com,
Ioana Radulescu <ruxandra.radulescu@nxp.com>,
Madalin Bucur <madalin.bucur@nxp.com>,
Michal Simek <michal.simek@xilinx.com>,
Doug Ledford <dledford@redhat.com>,
Murali Karicheri <m-karicheri2@ti.com>,
Mark Lee <Mark-MC.Lee@mediatek.com>,
Jiri Pirko <jiri@resnulli.us>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Hauke Mehrtens <hauke@hauke-m.de>,
Arnaud Ebalard <arno@natisbad.org>,
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Guy Tzalik <gtzalik@amazon.com>,
Luis Chamberlain <mcgrof@kernel.org>,
linux-crypto@vger.kernel.org,
Shannon Nelson <snelson@pensando.io>,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Chris Snook <chris.snook@gmail.com>,
Daniele Venzano <venza@brownhat.org>,
Zhu Yanjun <zyjzyj2000@gmail.com>,
linux-i2c@vger.kernel.org, Ioana Ciornei <ioana.ciornei@nxp.com>,
Jon Olson <jonolson@google.com>,
Arthur Kiyanovski <akiyano@amazon.com>,
Leon Romanovsky <leon@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Boris Pismenny <borisp@nvidia.com>,
John Fastabend <john.fastabend@gmail.com>,
Rain River <rain.1986.08.12@gmail.com>,
Martin Habets <habetsm.xilinx@gmail.com>,
Yisen Zhuang <yisen.zhuang@huawei.com>,
Wingman Kwok <w-kwok2@ti.com>, Sean Wang <sean.wang@mediatek.com>,
Kevin Br ace <"kev inbrace"@bracecomputerlab.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Pensando Drivers <drivers@pensando.io>,
linux-arm-kernel@lists.infradead.org,
Boris Brezillon <bbrezillon@kernel.org>,
Sagi Shahar <sagis@google.com>, Tariq Toukan <tariqt@nvidia.com>,
Sudarsana Kalluru <skalluru@marvell.com>,
Netanel Belgazal <netanel@amazon.com>,
Andreas Larsson <andreas@gaisler.com>,
Catherine Sullivan <csully@google.com>,
Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>,
Alexei Starovoitov <ast@kernel.org>,
Elie Morisse <syniurge@gmail.com>,
Luca Coelho <luciano.coelho@intel.com>,
Quan Nguyen <quan@os.amperecomputing.com>,
Subb araya Su ndeep <sbhatta@marvell.com>,
Jiri Slaby <jirislaby@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
linux-rdma@vger.kernel.org, Srujana Challa <schalla@marvell.com>,
ath10k@lists.infradead.org, b43-dev@lists.infradead.org,
ath11k@lists.infradead.org, Jay Cliburn <jcliburn@gmail.com>,
Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>,
John Crispin <john@phrozen.org>,
Michael Chan <michael.chan@broadcom.com>,
Edward Cree <ecree.xilinx@gmail.com>,
iommu@lists.linux-foundation.org, wil6210@qti.qualcomm.com,
Saeed Bishara <saeedb@amazon.com>,
bpf@vger.kernel.org, Geetha sowjanya <gakula@marvell.com>,
Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Zorik Machulsky <zorik@amazon.com>,
qat-linux@intel.com, Jason Gunthorpe <jgg@ziepe.ca>,
Nick Kossifidis <mickflemm@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Nehal Shah <nehal-bakulchandra.shah@amd.com>,
Sunil Goutham <sgoutham@marvell.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Ariel Elior <aelior@marvell.com>,
Keyur Chudgar <keyur@os.amperecomputing.com>,
George Cherian <gcherian@marvell.com>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, hariprasad <hkelam@marvell.com>,
Raju Rangoju <rajur@chelsio.com>, Felix Fietkau <nbd@nbd.name>,
Saeed Mahameed <saeedm@nvidia.com>,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH] dma-mapping: move hint unlikely for dma_mapping_error from drivers to core
Date: Fri, 11 Dec 2020 08:29:24 +0200 [thread overview]
Message-ID: <87eejw97p7.fsf@codeaurora.org> (raw)
In-Reply-To: <5d08af46-5897-b827-dcfb-181d869c8f71@gmail.com> (Heiner Kallweit's message of "Thu, 10 Dec 2020 15:47:50 +0100")
Heiner Kallweit <hkallweit1@gmail.com> writes:
> Zillions of drivers use the unlikely() hint when checking the result of
> dma_mapping_error(). This is an inline function anyway, so we can move
> the hint into the function and remove it from drivers.
>>From time to time discussions pop up how effective unlikely() is,
> and that it should be used only if something is really very unlikely.
> I think that's the case here.
>
> Patch was created with some help from coccinelle.
>
> @@
> expression dev, dma_addr;
> @@
>
> - unlikely(dma_mapping_error(dev, dma_addr))
> + dma_mapping_error(dev, dma_addr)
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> If ok, then tbd through which tree this is supposed to go.
> Patch is based on linux-next-20201210.
> ---
[...]
> drivers/net/wireless/ath/ath10k/htt_rx.c | 2 +-
> drivers/net/wireless/ath/ath10k/pci.c | 2 +-
> drivers/net/wireless/ath/ath10k/snoc.c | 2 +-
> drivers/net/wireless/ath/ath11k/ce.c | 2 +-
> drivers/net/wireless/ath/ath11k/dp_rx.c | 2 +-
> drivers/net/wireless/ath/ath5k/base.c | 2 +-
> drivers/net/wireless/ath/ath9k/beacon.c | 2 +-
> drivers/net/wireless/ath/ath9k/recv.c | 21 +++++++---------
> drivers/net/wireless/ath/ath9k/xmit.c | 2 +-
> drivers/net/wireless/ath/wil6210/txrx.c | 10 ++++----
> drivers/net/wireless/ath/wil6210/txrx_edma.c | 4 +--
> drivers/net/wireless/broadcom/b43/dma.c | 2 +-
> drivers/net/wireless/broadcom/b43legacy/dma.c | 2 +-
> drivers/net/wireless/intel/iwlwifi/pcie/tx.c | 10 ++++----
> drivers/net/wireless/intel/iwlwifi/queue/tx.c | 10 ++++----
> drivers/net/wireless/mediatek/mt76/dma.c | 8 +++---
> .../net/wireless/ralink/rt2x00/rt2x00queue.c | 4 +--
For wireless drivers:
Acked-by: Kalle Valo <kvalo@codeaurora.org>
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
prev parent reply other threads:[~2020-12-11 6:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 14:47 [PATCH] dma-mapping: move hint unlikely for dma_mapping_error from drivers to core Heiner Kallweit
2020-12-10 14:47 ` Heiner Kallweit
2020-12-10 14:47 ` Heiner Kallweit
2020-12-10 14:47 ` Heiner Kallweit
2020-12-10 14:47 ` Heiner Kallweit
2020-12-10 19:58 ` Wolfram Sang
2020-12-10 19:58 ` Wolfram Sang
2020-12-10 19:58 ` Wolfram Sang
2020-12-10 19:58 ` Wolfram Sang
2020-12-10 19:58 ` Wolfram Sang
2020-12-11 6:29 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eejw97p7.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc="kev inbrace"@bracecomputerlab.com \
--cc=GR-everest-linux-l2@marvell.com \
--cc=Larry.Finger@lwfinger.net \
--cc=Mark-MC.Lee@mediatek.com \
--cc=aelior@marvell.com \
--cc=akiyano@amazon.com \
--cc=andreas@gaisler.com \
--cc=arno@natisbad.org \
--cc=ast@kernel.org \
--cc=ath10k@lists.infradead.org \
--cc=ath11k@lists.infradead.org \
--cc=b43-dev@lists.infradead.org \
--cc=bbrezillon@kernel.org \
--cc=borisp@nvidia.com \
--cc=bpf@vger.kernel.org \
--cc=chris.snook@gmail.com \
--cc=claudiu.manoil@nxp.com \
--cc=csully@google.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=dledford@redhat.com \
--cc=drivers@pensando.io \
--cc=ecree.xilinx@gmail.com \
--cc=gakula@marvell.com \
--cc=gcherian@marvell.com \
--cc=giovanni.cabiddu@intel.com \
--cc=gtzalik@amazon.com \
--cc=habetsm.xilinx@gmail.com \
--cc=hauke@hauke-m.de \
--cc=hawk@kernel.org \
--cc=hayashi.kunihiko@socionext.com \
--cc=herbert@gondor.apana.org.au \
--cc=hkallweit1@gmail.com \
--cc=hkelam@marvell.com \
--cc=ioana.ciornei@nxp.com \
--cc=iommu@lists.linux-foundation.org \
--cc=irusskikh@marvell.com \
--cc=iyappan@os.amperecomputing.com \
--cc=jcliburn@gmail.com \
--cc=jgg@ziepe.ca \
--cc=jiri@resnulli.us \
--cc=jirislaby@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=john@phrozen.org \
--cc=jonolson@google.com \
--cc=keyur@os.amperecomputing.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=luciano.coelho@intel.com \
--cc=m-karicheri2@ti.com \
--cc=madalin.bucur@nxp.com \
--cc=matthias.bgg@gmail.com \
--cc=mcgrof@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=michal.simek@xilinx.com \
--cc=mickflemm@gmail.com \
--cc=mike.marciniszyn@cornelisnetworks.com \
--cc=nbd@nbd.name \
--cc=nehal-bakulchandra.shah@amd.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=qat-linux@intel.com \
--cc=quan@os.amperecomputing.com \
--cc=radhey.shyam.pandey@xilinx.com \
--cc=rain.1986.08.12@gmail.com \
--cc=rajur@chelsio.com \
--cc=ruxandra.radulescu@nxp.com \
--cc=saeedb@amazon.com \
--cc=saeedm@nvidia.com \
--cc=sagis@google.com \
--cc=sbhatta@marvell.com \
--cc=schalla@marvell.com \
--cc=sean.wang@mediatek.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=sgoutham@marvell.com \
--cc=shyam-sundar.s-k@amd.com \
--cc=skalluru@marvell.com \
--cc=snelson@pensando.io \
--cc=syniurge@gmail.com \
--cc=tariqt@nvidia.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=venza@brownhat.org \
--cc=w-kwok2@ti.com \
--cc=wil6210@qti.qualcomm.com \
--cc=yisen.zhuang@huawei.com \
--cc=zorik@amazon.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.