All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Dominique Martinet <asmadeus@codewreck.org>
Cc: Eric Van Hensbergen <ericvh@gmail.com>,
	Latchesar Ionkov <lucho@ionkov.net>,
	linux-kernel@vger.kernel.org,
	v9fs-developer@lists.sourceforge.net
Subject: Re: [V9fs-developer] [PATCH] fs: 9p: add generic splice_read file operations
Date: Tue, 01 Dec 2020 21:37:15 +0100	[thread overview]
Message-ID: <87eek91cw4.fsf@toke.dk> (raw)
In-Reply-To: <20201201153950.GA20545@nautica>

Dominique Martinet <asmadeus@codewreck.org> writes:

> Toke Høiland-Jørgensen wrote on Tue, Dec 01, 2020:
>> > This made me test copy_file_range, and it works with both as well (used
>> > not to)
>> >
>> > interestingly on older kernels this came as default somehow? I have
>> > splice working on 5.4.67 :/ so this broke somewhat recently...
>> 
>> Huh, no idea; this is my first time digging into filesystem code, I
>> normally do networking and BPF :)
>
> In case anyone else wants to know, this broke in 5.10-rc1 with
> 36e2c7421f02 ("fs: don't allow splice read/write without explicit ops")
>
> So really a recent regression, good catch :)

Thanks - and what a lucky coincidence that I happened upon this now so
it can be fixed before 5.10-final :)

-Toke


  reply	other threads:[~2020-12-01 20:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-01 13:54 [PATCH] fs: 9p: add generic splice_read file operations Toke Høiland-Jørgensen
2020-12-01 14:57 ` Dominique Martinet
2020-12-01 15:16   ` [V9fs-developer] " Dominique Martinet
2020-12-01 15:23     ` Toke Høiland-Jørgensen
2020-12-01 15:39       ` Dominique Martinet
2020-12-01 20:37         ` Toke Høiland-Jørgensen [this message]
2020-12-01 15:44     ` [PATCH] fs: 9p: add generic splice_write file operation Dominique Martinet
2020-12-01 19:25       ` Christoph Hellwig
2020-12-01 20:37       ` Toke Høiland-Jørgensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eek91cw4.fsf@toke.dk \
    --to=toke@redhat.com \
    --cc=asmadeus@codewreck.org \
    --cc=ericvh@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucho@ionkov.net \
    --cc=v9fs-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.