From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] support/scripts/check-kernel-headers.sh: do not print error for loose checks
Date: Mon, 06 Apr 2020 17:19:12 +0200 [thread overview]
Message-ID: <87eet0y74f.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20200321135220.341529-2-thomas.petazzoni@bootlin.com> (Thomas Petazzoni's message of "Sat, 21 Mar 2020 14:52:19 +0100")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> The C program inside check-kernel-headers.sh has two checking mode: a
> strict and a loose one.
> In strict mode, we want the kernel headers version declared by the
> user to match exactly the one of the toolchain.
> In loose mode, we want the kernel headers version of the toolchain to
> be greater than or equal to the one declared by the user: this is used
> when we have a toolchain that has newer headers than the latest
> version known by Buildroot.
> However, in loose mode, we continue to show the "Incorrect kernel
> headers version" message, even though we then return a zero error
> code. This is very confusing: you see an error displayed on the
> terminal, but the build goes on.
> We fix that by first doing the loose check first, and returning 0 if
> it succeeds. And then we move on with the strict check where we want
> the version to be identical.
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed to 2020.02.x, thanks.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2020-04-06 15:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-21 13:52 [Buildroot] [PATCH] toolchain/toolchain-external: fix call to check_kernel_headers_version Thomas Petazzoni
2020-03-21 13:52 ` [Buildroot] [PATCH] support/scripts/check-kernel-headers.sh: do not print error for loose checks Thomas Petazzoni
2020-03-21 14:48 ` Yann E. MORIN
2020-04-06 15:19 ` Peter Korsgaard [this message]
2020-03-21 14:47 ` [Buildroot] [PATCH] toolchain/toolchain-external: fix call to check_kernel_headers_version Yann E. MORIN
2020-04-06 15:16 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eet0y74f.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.