All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Vandita Kulkarni <vandita.kulkarni@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [V8 5/9] drm/i915/dsi: Use private flags to indicate TE in cmd mode
Date: Tue, 24 Mar 2020 17:28:37 +0200	[thread overview]
Message-ID: <87eethbwm2.fsf@intel.com> (raw)
In-Reply-To: <20200312053841.2794-6-vandita.kulkarni@intel.com>

On Thu, 12 Mar 2020, Vandita Kulkarni <vandita.kulkarni@intel.com> wrote:
> On dsi cmd mode we do not receive vblanks instead
> we would get TE and these flags indicate TE is expected on
> which port.
>
> Signed-off-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>

Pushed up to and including this patch.

BR,
Jani.

> ---
>  drivers/gpu/drm/i915/display/icl_dsi.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c
> index 949f4867402b..d452037b1ac9 100644
> --- a/drivers/gpu/drm/i915/display/icl_dsi.c
> +++ b/drivers/gpu/drm/i915/display/icl_dsi.c
> @@ -1550,6 +1550,24 @@ static int gen11_dsi_compute_config(struct intel_encoder *encoder,
>  	pipe_config->hw.adjusted_mode.private_flags &=
>  					~I915_MODE_FLAG_DSI_PERIODIC_CMD_MODE;
>  
> +	/*
> +	 * In case of TE GATE cmd mode, we
> +	 * receive TE from the slave if
> +	 * dual link is enabled
> +	 */
> +	if (is_cmd_mode(intel_dsi)) {
> +		if (intel_dsi->ports == (BIT(PORT_B) | BIT(PORT_A)))
> +			pipe_config->hw.adjusted_mode.private_flags |=
> +						I915_MODE_FLAG_DSI_USE_TE1 |
> +						I915_MODE_FLAG_DSI_USE_TE0;
> +		else if (intel_dsi->ports == BIT(PORT_B))
> +			pipe_config->hw.adjusted_mode.private_flags |=
> +						I915_MODE_FLAG_DSI_USE_TE1;
> +		else
> +			pipe_config->hw.adjusted_mode.private_flags |=
> +						I915_MODE_FLAG_DSI_USE_TE0;
> +	}
> +
>  	return 0;
>  }

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-03-24 15:28 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-12  5:38 [Intel-gfx] [V8 0/9] Add support for mipi dsi cmd mode Vandita Kulkarni
2020-03-12  5:38 ` [Intel-gfx] [V8 1/9] drm/i915/dsi: Configure transcoder operation for command mode Vandita Kulkarni
2020-03-12  5:38 ` [Intel-gfx] [V8 2/9] drm/i915/dsi: Add vblank calculation " Vandita Kulkarni
2020-03-12  5:38 ` [Intel-gfx] [V8 3/9] drm/i915/dsi: Add cmd mode flags in display mode private flags Vandita Kulkarni
2020-03-12  5:38 ` [Intel-gfx] [V8 4/9] drm/i915/dsi: Add check for periodic command mode Vandita Kulkarni
2020-03-12  5:38 ` [Intel-gfx] [V8 5/9] drm/i915/dsi: Use private flags to indicate TE in cmd mode Vandita Kulkarni
2020-03-24 15:28   ` Jani Nikula [this message]
2020-03-12  5:38 ` [Intel-gfx] [V8 6/9] drm/i915/dsi: Configure TE interrupt for " Vandita Kulkarni
2020-03-12  5:38 ` [Intel-gfx] [V8 7/9] drm/i915/dsi: Add TE handler for dsi " Vandita Kulkarni
2020-03-24 15:31   ` Jani Nikula
2020-03-12  5:38 ` [Intel-gfx] [V8 8/9] drm/i915/dsi: Initiate fame request in " Vandita Kulkarni
2020-03-12  5:38 ` [Intel-gfx] [V8 9/9] drm/i915/dsi: Clear the DSI IIR Vandita Kulkarni
2020-03-12  6:37 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add support for mipi dsi cmd mode (rev7) Patchwork
2020-03-12  6:40 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-03-12  7:00 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-03-16 21:59 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add support for mipi dsi cmd mode (rev8) Patchwork
2020-03-16 22:02 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-03-16 22:17 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2020-03-16 22:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-03-17  6:59 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eethbwm2.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=vandita.kulkarni@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.