From: Kalle Valo <kvalo@codeaurora.org>
To: <yhchuang@realtek.com>
Cc: <linux-wireless@vger.kernel.org>, <briannorris@chromium.org>
Subject: Re: [PATCH] rtw88: add debugfs to fix tx rate
Date: Fri, 13 Mar 2020 12:33:13 +0200 [thread overview]
Message-ID: <87eetwo87q.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20200313065114.23433-1-yhchuang@realtek.com> (yhchuang@realtek.com's message of "Fri, 13 Mar 2020 14:51:14 +0800")
<yhchuang@realtek.com> writes:
> From: Yan-Hsuan Chuang <yhchuang@realtek.com>
>
> It is useful to fix the bit rate of TX packets. For example, if
> someone is measuring the TX power, or debugging with the issues
> of the TX throughput on the field.
>
> To set the value of fixed rate, one should input corresponding
> desc rate index (ex, 0x0b for DESC_RATE54M to fix at 54 Mbps).
> Set a value larger than DESC_RATE_MAX will disable fix rate, so
> the rate adaptive mechanism can resume to work.
>
> Example,
> To fix rate at MCS 1:
> echo 0x0d > /sys/kernel/debug/ieee80211/phy0/rtw88/fix_rate
>
> To not to fix rate:
> echo 0xff > /sys/kernel/debug/ieee80211/phy0/rtw88/fix_rate
>
> To know which rate was fixed at:
> cat /sys/kernel/debug/ieee80211/phy0/rtw88/fix_rate
>
> Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
No way, debugfs is not a method for working around nl80211 and doing
whatever idea you come up with. The goal is that we have a generic
nl80211 command for all generic actions, like this one. And I think we
already have an nl80211 command for fixing the tx rate, right?
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-03-13 10:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 6:51 [PATCH] rtw88: add debugfs to fix tx rate yhchuang
2020-03-13 10:33 ` Kalle Valo [this message]
2020-03-16 2:28 ` Tony Chuang
2020-03-17 7:10 ` Kalle Valo
2020-03-17 10:32 ` Tony Chuang
2020-03-17 15:40 ` Kalle Valo
2020-03-17 15:49 ` Ben Greear
2020-03-18 9:02 ` Tony Chuang
2020-03-20 13:05 ` Johannes Berg
2020-03-25 0:03 ` Brian Norris
2020-03-25 2:55 ` Tony Chuang
2020-03-25 5:16 ` Brian Norris
2020-03-25 5:54 ` Tony Chuang
2020-03-25 9:10 ` Johannes Berg
2020-03-25 15:52 ` Ben Greear
2020-03-25 18:14 ` Brian Norris
2020-05-25 9:07 ` Johannes Berg
2020-05-25 16:16 ` Ben Greear
2020-03-26 18:27 ` Brian Norris
2021-11-26 16:19 ` Kalle Valo
2021-11-29 2:25 ` Pkshih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eetwo87q.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=briannorris@chromium.org \
--cc=linux-wireless@vger.kernel.org \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.