From: Jani Nikula <jani.nikula@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: significantly reduce the use of <drm/i915_drm.h>
Date: Tue, 25 Feb 2020 15:41:16 +0200 [thread overview]
Message-ID: <87eeuiss1v.fsf@intel.com> (raw)
In-Reply-To: <158263718815.26598.17202312224644171261@skylake-alporthouse-com>
On Tue, 25 Feb 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Jani Nikula (2020-02-25 13:07:28)
>> The #include has been splattered all over the place, but there are
>> precious few places, all .c files, that actually need it.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Trust in the compiler,
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Thanks!
> The users of i915_drv.h that irk me the most are where we only want the
> device_info/runtime_info. Might just bite the bullet and make those
> pointers and so not have to traverse through i915.
In general, struct drm_i915_private is just way too big. It requires the
definitions of almost everything, and almost everything needs struct
drm_i915_private definition. Static inlines that look inside i915 make
matters worse.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-25 13:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 13:07 [Intel-gfx] [PATCH] drm/i915: significantly reduce the use of <drm/i915_drm.h> Jani Nikula
2020-02-25 13:26 ` Chris Wilson
2020-02-25 13:41 ` Jani Nikula [this message]
2020-02-25 13:27 ` Chris Wilson
2020-02-25 13:32 ` Jani Nikula
2020-02-25 13:31 ` [Intel-gfx] [PATCH v2] " Jani Nikula
2020-02-26 13:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: significantly reduce the use of <drm/i915_drm.h> (rev2) Patchwork
2020-02-26 22:13 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eeuiss1v.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.