From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ED1AC35671 for ; Mon, 24 Feb 2020 12:30:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B3782072D for ; Mon, 24 Feb 2020 12:30:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B3782072D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1AA4F6E455; Mon, 24 Feb 2020 12:30:08 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2B3886E455 for ; Mon, 24 Feb 2020 12:30:07 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Feb 2020 04:30:06 -0800 X-IronPort-AV: E=Sophos;i="5.70,480,1574150400"; d="scan'208";a="230635399" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Feb 2020 04:30:03 -0800 From: Jani Nikula To: Randy Dunlap , Masahiro Yamada In-Reply-To: <0f6712cd-87e5-5480-f01c-bfadd98368b5@infradead.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20200221105414.14358-1-jani.nikula@intel.com> <373b4c07-2355-6e78-e9f4-e1bf50322287@infradead.org> <0f6712cd-87e5-5480-f01c-bfadd98368b5@infradead.org> Date: Mon, 24 Feb 2020 14:29:59 +0200 Message-ID: <87eeuktbg8.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH] drm/i915: fix header test with GCOV X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, 21 Feb 2020, Randy Dunlap wrote: > On 2/21/20 9:49 PM, Masahiro Yamada wrote: >> On Sat, Feb 22, 2020 at 2:25 PM Randy Dunlap wrote: >>> >>> On 2/21/20 8:53 PM, Masahiro Yamada wrote: >>>> On Sat, Feb 22, 2020 at 1:43 PM Masahiro Yamada wrote: >>>>> >>>>> Hi Jani, >>>>> >>>>> On Fri, Feb 21, 2020 at 7:54 PM Jani Nikula wrote: >>>>>> >>>>>> $(CC) with $(CFLAGS_GCOV) assumes the output filename with .gcno suffix >>>>>> appended is writable. This is not the case when the output filename is >>>>>> /dev/null: >>>>>> >>>>>> HDRTEST drivers/gpu/drm/i915/display/intel_frontbuffer.h >>>>>> /dev/null:1:0: error: cannot open /dev/null.gcno >>>>>> HDRTEST drivers/gpu/drm/i915/display/intel_ddi.h >>>>>> /dev/null:1:0: error: cannot open /dev/null.gcno >>>>>> make[5]: *** [../drivers/gpu/drm/i915/Makefile:307: >>>>>> drivers/gpu/drm/i915/display/intel_ddi.hdrtest] Error 1 >>>>>> make[5]: *** Waiting for unfinished jobs.... >>>>>> make[5]: *** [../drivers/gpu/drm/i915/Makefile:307: >>>>>> drivers/gpu/drm/i915/display/intel_frontbuffer.hdrtest] Error 1 >>>>>> >>>>>> Filter out $(CFLAGS_GVOC) from the header test $(c_flags) as they don't >>>>>> make sense here anyway. >>>>> >>>>> >>>>> >>>>> Is GCOV the only case that produces a separate file? >>>>> >>>>> Could you also test CONFIG_DEBUG_INFO_SPLIT, please ? >>>>> >>>>> >>>>> The GCC manual says this: >>>>> >>>>> -gsplit-dwarf >>>>> >>>>> Separate as much DWARF debugging information as possible into a >>>>> separate output >>>>> file with the extension .dwo. This option allows the build system >>>>> to avoid linking >>>>> files with debug information. To be useful, this option requires a debugger >>>>> capable of reading .dwo files. >>>>> >>>> >>>> >>>> I just tested it. >>>> >>>> This is not a problem for header test >>>> because cmd_hdrtest uses '-S' instead of '-c'. >>>> >>>> If '-c' were used, we would see a similar error. >>>> >>>> >>>> So, gsplit-dwarf is OK. >>> >>> Yes, works for me also. >>> >>> (I think you have a faster build machine that I do. I began the build >>> almost immediately after reading your email. :) >> >> >> I use a reasonable PC for my development. >> (core-i9 with 4 physical cores) >> >> >> I just compiled under i915/ with this command: >> >> make drivers/gpu/drm/i915/ > > Good trick. I did a full build. Thanks for the testing. I also checked with some other options, did not see any failures. I'll go with this for now, let's revisit as needed. Another related thing is we try to hide this a bit from build testing outside of our CI with "depends on !COMPILE_TEST" but I guess there's no way to ensure something is not enabled on a randconfig build... BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx