From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E286C33C9E for ; Thu, 30 Jan 2020 08:03:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EDB8E20702 for ; Thu, 30 Jan 2020 08:03:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="U5SZWROh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EDB8E20702 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56990 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ix4nh-0002fA-3N for qemu-devel@archiver.kernel.org; Thu, 30 Jan 2020 03:03:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51092) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ix4n5-0002Dr-L9 for qemu-devel@nongnu.org; Thu, 30 Jan 2020 03:03:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ix4n4-00011n-I0 for qemu-devel@nongnu.org; Thu, 30 Jan 2020 03:03:07 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:58980 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ix4n4-00011X-Em for qemu-devel@nongnu.org; Thu, 30 Jan 2020 03:03:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580371385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bD+xi3Q17dA/0Mdd/xrrPB/fhwRm9Kpds3JmDTXVkjI=; b=U5SZWROhnjHnUFINNZELXDISUfyF+qx/QN8KGqd1uNTZER+FldLUXPruT1q7UwUbROU/mq bxQfy9rNzbowFy1IJEyFMN0VX5hsMSA8Cr+43ylJwOOqu6HsErKkoPQKJNMazFRApjL3aZ UUScvo7UbgCkKtkMhJDhdlIA0rFQPyI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-52-Re9EH0oZPc-EAJHqy2zN4A-1; Thu, 30 Jan 2020 03:03:03 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 652DE108443D for ; Thu, 30 Jan 2020 08:03:02 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-131.ams2.redhat.com [10.36.116.131]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A702A89D18; Thu, 30 Jan 2020 08:03:01 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 170471138404; Thu, 30 Jan 2020 09:03:00 +0100 (CET) From: Markus Armbruster To: Juan Quintela Subject: Re: [PATCH v5 4/8] multifd: Add multifd-zlib-level parameter References: <20200129115655.10414-1-quintela@redhat.com> <20200129115655.10414-5-quintela@redhat.com> Date: Thu, 30 Jan 2020 09:03:00 +0100 In-Reply-To: <20200129115655.10414-5-quintela@redhat.com> (Juan Quintela's message of "Wed, 29 Jan 2020 12:56:51 +0100") Message-ID: <87eevhxtfv.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: Re9EH0oZPc-EAJHqy2zN4A-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , "Daniel P. =?utf-8?Q?Berrang=C3=A9?=" , Eduardo Habkost , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Juan Quintela writes: > It will indicate which level use for compression. > > Signed-off-by: Juan Quintela This is slightly confusing (there is no zlib compression), unless you peek at the next patch (which adds zlib compression). Three ways to make it less confusing: * Squash the two commits * Swap them: first add zlib compression with level hardcoded to 1, then make the level configurable. * Have the first commit explain itself better. Something like multifd: Add multifd-zlib-level parameter This parameter specifies zlib compression level. The next patch will put it to use. For QAPI: Acked-by: Markus Armbruster