All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Fam Zheng <fam@euphon.net>,
	peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: Re: [PATCH v1 3/3] tests/vm/ubuntu: update i386 image to 18.04
Date: Fri, 22 Nov 2019 13:03:15 +0000	[thread overview]
Message-ID: <87eey083n0.fsf@linaro.org> (raw)
In-Reply-To: <b91b6119-fc01-9cc0-b8cb-730d5484ede4@redhat.com>


Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> On 11/22/19 12:22 PM, Alex Bennée wrote:
>> The current image is broken while running qtests but the bug go away
>> when built with a newer Ubuntu i386 image. I was unable to replicate
>> the crash on Debian Buster for i386 either so I'm concluding it is a
>> distro problem. Let's paper over that crack by updating our 32 bir
>
> typo "our 32 bit"
>
>> test image.
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>>   tests/vm/ubuntu.i386 | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>> diff --git a/tests/vm/ubuntu.i386 b/tests/vm/ubuntu.i386
>> index 18b1ea2b72c..f611bebdc9d 100755
>> --- a/tests/vm/ubuntu.i386
>> +++ b/tests/vm/ubuntu.i386
>> @@ -66,8 +66,8 @@ class UbuntuX86VM(basevm.BaseVM):
>>         def build_image(self, img):
>>           cimg = self._download_with_cache(
>> -            "https://cloud-images.ubuntu.com/releases/16.04/release-20190605/ubuntu-16.04-server-cloudimg-i386-disk1.img",
>> -            sha256sum="e30091144c73483822b7c27193e9d47346dd1064229da577c3fedcf943f7cfcc")
>
> This one is in QCow2 format.
>
>> +            "https://cloud-images.ubuntu.com/releases/bionic/release-20191114/ubuntu-18.04-server-cloudimg-i386.img",
>> +            sha256sum="28969840626d1ea80bb249c08eef1a4533e8904aa51a327b40f37ac4b4ff04ef")
>
> This one is announced as USB format (ISO) but is in QCow2 format too...
>

heh I never noticed. It worked though ;-)

> Using '18.04' instead of 'bionic' in the URL is not important because
> the information is also in the filename.
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Thanks.

>
>>           img_tmp = img + ".tmp"
>>           subprocess.check_call(["cp", "-f", cimg, img_tmp])
>>           subprocess.check_call(["qemu-img", "resize", img_tmp, "50G"])
>> 


-- 
Alex Bennée


      reply	other threads:[~2019-11-22 13:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-22 11:22 [PATCH for 4.2 v1 0/3] some tests/vm fixes Alex Bennée
2019-11-22 11:22 ` [PATCH v1 1/3] tests/vm/centos: fix centos build target Alex Bennée
2019-11-22 11:22 ` [PATCH v1 2/3] tests/vm/ubuntu: include language pack to silence locale warnings Alex Bennée
2019-11-22 11:39   ` Philippe Mathieu-Daudé
2019-11-22 11:22 ` [PATCH v1 3/3] tests/vm/ubuntu: update i386 image to 18.04 Alex Bennée
2019-11-22 11:39   ` Philippe Mathieu-Daudé
2019-11-22 13:03     ` Alex Bennée [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eey083n0.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=fam@euphon.net \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.