From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:adf:e804:0:0:0:0:0 with SMTP id o4csp4824428wrm; Tue, 8 Oct 2019 00:31:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqySdnzrmVQxTeVAOR1uGGkCIS0MbmQJc2CXnBv1F+EpGg93wv8e4vd+Q5rCYc1pp2oYOk6p X-Received: by 2002:a17:906:8258:: with SMTP id f24mr26927179ejx.234.1570519899466; Tue, 08 Oct 2019 00:31:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570519899; cv=none; d=google.com; s=arc-20160816; b=MnqxrE9z1tkZ5tk0cBj5amQP1h6EuHfk7zZm9WwjjJu7pn34Hsbnj/sYmx9NMG8N2D rb+NpoTt1syGcUJ77y9OQA5FMgLAvZux1CL4gpA/BTrvR3aJtm5NqddzGy7Dqa+JBpbY P4gbb0Tjx2ADqIAER1+iAhnAp+XP2TfmiJ3cVEcmxfLvYVn4hiij3A+Rho9PwPWA3nQP 0C2l8pDiDPF00KqKau08lU8iEV/U03LDjxJ+VpIBHfApW80X1cieQ0IlX7TjH5nbSPeN UHQdtTK8Ts92l9MplhqF4R3fXoJZiVys9aPrW54FcLns1vNsl6V7mb8P1Zrvt0lH9bBW 25Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version:user-agent :message-id:in-reply-to:date:references:subject:to:from; bh=COb5YQiNb3S1fzhfkOFgvX1kK2GwhC9VHk8WUOwv+HQ=; b=XRvpLPneJk904dvT+bZoIwAGuYDlm2uj3mSWG8rlzx7Hl3BCeLQwPMOucH/l0sus+P I0+6XU1VgAW5BhvxAKMNNmffLNslSK7j/IwxqB1ohkedI9K/WKmz6QzgBQagm56bKdEJ LJlvWZ0nm2lQVD5IyHoVsUAIm6u+opIWb5GU/1L54pfOeRUATrg3mdH4lcNpFsqszWPi Mp1xY67H6w6KxCSVe8Di+PFS3fgpS9c3tT2hS7kg6Q3ATlvFfR0HwR+2k3HcO/63R1i1 kFOcYg473U5txzgPNSFXCiQAbq1UKluo2nWeTY/JnRVXrSIaYqHDxPORR16MvC2Q8we5 TqSA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id i38si10662730eda.64.2019.10.08.00.31.39 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 Oct 2019 00:31:39 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:51650 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHjy6-0007Zn-Ej for alex.bennee@linaro.org; Tue, 08 Oct 2019 03:31:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49266) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHjxL-0007Ze-1z for qemu-arm@nongnu.org; Tue, 08 Oct 2019 03:30:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iHjxG-0000RS-Gp for qemu-arm@nongnu.org; Tue, 08 Oct 2019 03:30:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57196) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iHjxC-0000QL-40; Tue, 08 Oct 2019 03:30:43 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3C8F619D369; Tue, 8 Oct 2019 07:30:35 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.118.123]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 754BE5D9D3; Tue, 8 Oct 2019 07:30:20 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id CB1D01138648; Tue, 8 Oct 2019 09:30:18 +0200 (CEST) From: Markus Armbruster To: Vladimir Sementsov-Ogievskiy Subject: Re: [PATCH v4 00/31] error: auto propagated local_err References: <20191001155319.8066-1-vsementsov@virtuozzo.com> Date: Tue, 08 Oct 2019 09:30:18 +0200 In-Reply-To: <20191001155319.8066-1-vsementsov@virtuozzo.com> (Vladimir Sementsov-Ogievskiy's message of "Tue, 1 Oct 2019 18:52:48 +0300") Message-ID: <87eeznn185.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 08 Oct 2019 07:30:40 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, pburton@wavecomp.com, peter.maydell@linaro.org, codyprime@gmail.com, jasowang@redhat.com, mark.cave-ayland@ilande.co.uk, qemu-devel@nongnu.org, kraxel@redhat.com, mreitz@redhat.com, qemu-block@nongnu.org, quintela@redhat.com, arikalo@wavecomp.com, mst@redhat.com, mdroth@linux.vnet.ibm.com, pasic@linux.ibm.com, borntraeger@de.ibm.com, joel@jms.id.au, marcandre.lureau@redhat.com, david@gibson.dropbear.id.au, farman@linux.ibm.com, ehabkost@redhat.com, sw@weilnetz.de, groug@kaod.org, yuval.shaia@oracle.com, dgilbert@redhat.com, alex.williamson@redhat.com, qemu-arm@nongnu.org, clg@kaod.org, stefanha@redhat.com, david@redhat.com, jsnow@redhat.com, rth@twiddle.net, kwolf@redhat.com, integration@gluster.org, berrange@redhat.com, andrew@aj.id.au, cohuck@redhat.com, qemu-s390x@nongnu.org, sundeep.lkml@gmail.com, qemu-ppc@nongnu.org, pbonzini@redhat.com Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: bYfAaQ6JzYSi Vladimir Sementsov-Ogievskiy writes: > Hi all! > > Here is a proposal of auto propagation for local_err, to not call > error_propagate on every exit point, when we deal with local_err. > > There are also two issues with errp: > > 1. error_fatal & error_append_hint/error_prepend: user can't see this > additional info, because exit() happens in error_setg earlier than info > is added. [Reported by Greg Kurz] How is this series related to Greg's "[PATCH 00/17] Fix usage of error_append_hint()"? Do we need both? > 2. error_abort & error_propagate: when we wrap > error_abort by local_err+error_propagate, resulting coredump will > refer to error_propagate and not to the place where error happened. > (the macro itself don't fix the issue, but it allows to [3.] drop all > local_err+error_propagate pattern, which will definitely fix the issue) > [Reported by Kevin Wolf] > > Still, applying new macro to all errp-functions is a huge task, which is > impossible to solve in one series. > > So, here is a minimum: solve only [1.], by adding new macro to all > errp-functions which wants to call error_append_hint. > > v4; > 02: - check errp to be not NULL > - drop Eric's r-b > 03: add Eric's r-b > 04: - rename macro to ERRP_AUTO_PROPAGATE [Kevin] > - improve comment and commit msg, mention > error_prepend > 05: - handle error_prepend too > - use new macro name > - drop empty line at the end > > commit message for auto-generated commits updated, > commits regenerated. > > I'll use cc-cmd to cc appropriate recipients per patch, still > cover-letter together with 04-06 patches should be interesting for > all: [...] Big series; let me guess its structure. > Vladimir Sementsov-Ogievskiy (31): > errp: rename errp to errp_in where it is IN-argument > hw/core/loader-fit: fix freeing errp in fit_load_fdt > net/net: fix local variable shadowing in net_client_init Preparations. > error: auto propagated local_err The new idea. > scripts: add script to fix error_append_hint/error_prepend usage > python: add commit-per-subsystem.py Scripts to help you apply it. > s390: Fix error_append_hint/error_prepend usage > ARM TCG CPUs: Fix error_append_hint/error_prepend usage > PowerPC TCG CPUs: Fix error_append_hint/error_prepend usage > arm: Fix error_append_hint/error_prepend usage > SmartFusion2: Fix error_append_hint/error_prepend usage > ASPEED BMCs: Fix error_append_hint/error_prepend usage > Boston: Fix error_append_hint/error_prepend usage > PowerNV (Non-Virtualized): Fix error_append_hint/error_prepend usage > PCI: Fix error_append_hint/error_prepend usage > SCSI: Fix error_append_hint/error_prepend usage > USB: Fix error_append_hint/error_prepend usage > VFIO: Fix error_append_hint/error_prepend usage > vhost: Fix error_append_hint/error_prepend usage > virtio: Fix error_append_hint/error_prepend usage > virtio-9p: Fix error_append_hint/error_prepend usage > XIVE: Fix error_append_hint/error_prepend usage > block: Fix error_append_hint/error_prepend usage > chardev: Fix error_append_hint/error_prepend usage > cmdline: Fix error_append_hint/error_prepend usage > QOM: Fix error_append_hint/error_prepend usage > Migration: Fix error_append_hint/error_prepend usage > Sockets: Fix error_append_hint/error_prepend usage > nbd: Fix error_append_hint/error_prepend usage > PVRDMA: Fix error_append_hint/error_prepend usage > ivshmem: Fix error_append_hint/error_prepend usage Applying it. Correct? [...]