From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v5 3/5] drm/dp_mst: Add MST support to DP DPCD R/W functions Date: Mon, 26 Aug 2019 15:44:56 +0300 Message-ID: <87ef189juf.fsf@intel.com> References: <20190823202809.15934-1-David.Francis@amd.com> <20190823202809.15934-4-David.Francis@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2C81189FA7 for ; Mon, 26 Aug 2019 12:44:59 +0000 (UTC) In-Reply-To: <20190823202809.15934-4-David.Francis@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: David Francis , "Syrjala, Ville" List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAyMyBBdWcgMjAxOSwgRGF2aWQgRnJhbmNpcyA8RGF2aWQuRnJhbmNpc0BhbWQuY29t PiB3cm90ZToKPiBJbnN0ZWFkIG9mIGhhdmluZyBkcm1fZHBfZHBjZF9yZWFkL3dyaXRlIGFuZAo+ IGRybV9kcF9tc3RfZHBjZF9yZWFkL3dyaXRlIGFzIGVudHJ5IHBvaW50cyBpbnRvIHRoZQo+IGF1 eCBjb2RlLCBoYXZlIGRybV9kcF9kcGNkX3JlYWQvd3JpdGUgaGFuZGxlIGJvdGguCj4KPiBUaGlz IG1lYW5zIHRoYXQgRFJNIGRyaXZlcnMgY2FuIG1ha2UgTVNUIERQQ0QgcmVhZC93cml0ZXMuCj4K PiB2MjogRml4IHNwYWNpbmcKPiB2MzogRHVtcCBkcGNkIGFjY2VzcyBvbiBNU1QgcmVhZC93cml0 ZXMKPgo+IFJldmlld2VkLWJ5OiBMeXVkZSBQYXVsIDxseXVkZUByZWRoYXQuY29tPgo+IFNpZ25l ZC1vZmYtYnk6IERhdmlkIEZyYW5jaXMgPERhdmlkLkZyYW5jaXNAYW1kLmNvbT4KCkNjOiBWaWxs ZSB3aG8gYWRkZWQgZHJtX2RwX21zdF9kcGNkX3JlYWQgYW5kIF93cml0ZS4KCkJSLApKYW5pLgoK Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZHBfYXV4X2Rldi5jIHwgMTIgKystLS0tLS0t LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZHBfaGVscGVyLmMgIHwgMzAgKysrKysrKysrKysr KysrKysrKystLS0tLS0tLS0tCj4gIDIgZmlsZXMgY2hhbmdlZCwgMjIgaW5zZXJ0aW9ucygrKSwg MjAgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9kcF9h dXhfZGV2LmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2RwX2F1eF9kZXYuYwo+IGluZGV4IDBjZmIz ODY3NTRjMy4uNDE4Y2FkNGY2NDlhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1f ZHBfYXV4X2Rldi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9kcF9hdXhfZGV2LmMKPiBA QCAtMTYzLDExICsxNjMsNyBAQCBzdGF0aWMgc3NpemVfdCBhdXhkZXZfcmVhZF9pdGVyKHN0cnVj dCBraW9jYiAqaW9jYiwgc3RydWN0IGlvdl9pdGVyICp0bykKPiAgCQkJYnJlYWs7Cj4gIAkJfQo+ ICAKPiAtCQlpZiAoYXV4X2Rldi0+YXV4LT5pc19yZW1vdGUpCj4gLQkJCXJlcyA9IGRybV9kcF9t c3RfZHBjZF9yZWFkKGF1eF9kZXYtPmF1eCwgcG9zLCBidWYsCj4gLQkJCQkJCSAgIHRvZG8pOwo+ IC0JCWVsc2UKPiAtCQkJcmVzID0gZHJtX2RwX2RwY2RfcmVhZChhdXhfZGV2LT5hdXgsIHBvcywg YnVmLCB0b2RvKTsKPiArCQlyZXMgPSBkcm1fZHBfZHBjZF9yZWFkKGF1eF9kZXYtPmF1eCwgcG9z LCBidWYsIHRvZG8pOwo+ICAKPiAgCQlpZiAocmVzIDw9IDApCj4gIAkJCWJyZWFrOwo+IEBAIC0y MTUsMTEgKzIxMSw3IEBAIHN0YXRpYyBzc2l6ZV90IGF1eGRldl93cml0ZV9pdGVyKHN0cnVjdCBr aW9jYiAqaW9jYiwgc3RydWN0IGlvdl9pdGVyICpmcm9tKQo+ICAJCQlicmVhazsKPiAgCQl9Cj4g IAo+IC0JCWlmIChhdXhfZGV2LT5hdXgtPmlzX3JlbW90ZSkKPiAtCQkJcmVzID0gZHJtX2RwX21z dF9kcGNkX3dyaXRlKGF1eF9kZXYtPmF1eCwgcG9zLCBidWYsCj4gLQkJCQkJCSAgICB0b2RvKTsK PiAtCQllbHNlCj4gLQkJCXJlcyA9IGRybV9kcF9kcGNkX3dyaXRlKGF1eF9kZXYtPmF1eCwgcG9z LCBidWYsIHRvZG8pOwo+ICsJCXJlcyA9IGRybV9kcF9tc3RfZHBjZF93cml0ZShhdXhfZGV2LT5h dXgsIHBvcywgYnVmLCB0b2RvKTsKPiAgCj4gIAkJaWYgKHJlcyA8PSAwKQo+ICAJCQlicmVhazsK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9kcF9oZWxwZXIuYyBiL2RyaXZlcnMv Z3B1L2RybS9kcm1fZHBfaGVscGVyLmMKPiBpbmRleCBmZmM2OGQzMDVhZmUuLjJjYzIxZWZmNGNm MyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2RwX2hlbHBlci5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2RybV9kcF9oZWxwZXIuYwo+IEBAIC0zMCw2ICszMCw3IEBACj4gICNp bmNsdWRlIDxsaW51eC9zZXFfZmlsZS5oPgo+ICAKPiAgI2luY2x1ZGUgPGRybS9kcm1fZHBfaGVs cGVyLmg+Cj4gKyNpbmNsdWRlIDxkcm0vZHJtX2RwX21zdF9oZWxwZXIuaD4KPiAgI2luY2x1ZGUg PGRybS9kcm1fcHJpbnQuaD4KPiAgI2luY2x1ZGUgPGRybS9kcm1fdmJsYW5rLmg+Cj4gIAo+IEBA IC0yNTEsNyArMjUyLDcgQEAgc3RhdGljIGludCBkcm1fZHBfZHBjZF9hY2Nlc3Moc3RydWN0IGRy bV9kcF9hdXggKmF1eCwgdTggcmVxdWVzdCwKPiAgCj4gIC8qKgo+ICAgKiBkcm1fZHBfZHBjZF9y ZWFkKCkgLSByZWFkIGEgc2VyaWVzIG9mIGJ5dGVzIGZyb20gdGhlIERQQ0QKPiAtICogQGF1eDog RGlzcGxheVBvcnQgQVVYIGNoYW5uZWwKPiArICogQGF1eDogRGlzcGxheVBvcnQgQVVYIGNoYW5u ZWwgKFNTVCBvciBNU1QpCj4gICAqIEBvZmZzZXQ6IGFkZHJlc3Mgb2YgdGhlIChmaXJzdCkgcmVn aXN0ZXIgdG8gcmVhZAo+ICAgKiBAYnVmZmVyOiBidWZmZXIgdG8gc3RvcmUgdGhlIHJlZ2lzdGVy IHZhbHVlcwo+ICAgKiBAc2l6ZTogbnVtYmVyIG9mIGJ5dGVzIGluIEBidWZmZXIKPiBAQCAtMjgw LDEzICsyODEsMTggQEAgc3NpemVfdCBkcm1fZHBfZHBjZF9yZWFkKHN0cnVjdCBkcm1fZHBfYXV4 ICphdXgsIHVuc2lnbmVkIGludCBvZmZzZXQsCj4gIAkgKiBXZSBqdXN0IGhhdmUgdG8gZG8gaXQg YmVmb3JlIGFueSBEUENEIGFjY2VzcyBhbmQgaG9wZSB0aGF0IHRoZQo+ICAJICogbW9uaXRvciBk b2Vzbid0IHBvd2VyIGRvd24gZXhhY3RseSBhZnRlciB0aGUgdGhyb3cgYXdheSByZWFkLgo+ICAJ ICovCj4gLQlyZXQgPSBkcm1fZHBfZHBjZF9hY2Nlc3MoYXV4LCBEUF9BVVhfTkFUSVZFX1JFQUQs IERQX0RQQ0RfUkVWLCBidWZmZXIsCj4gLQkJCQkgMSk7Cj4gLQlpZiAocmV0ICE9IDEpCj4gLQkJ Z290byBvdXQ7Cj4gKwlpZiAoIWF1eC0+aXNfcmVtb3RlKSB7Cj4gKwkJcmV0ID0gZHJtX2RwX2Rw Y2RfYWNjZXNzKGF1eCwgRFBfQVVYX05BVElWRV9SRUFELCBEUF9EUENEX1JFViwKPiArCQkJCQkg YnVmZmVyLCAxKTsKPiArCQlpZiAocmV0ICE9IDEpCj4gKwkJCWdvdG8gb3V0Owo+ICsJfQo+ICAK PiAtCXJldCA9IGRybV9kcF9kcGNkX2FjY2VzcyhhdXgsIERQX0FVWF9OQVRJVkVfUkVBRCwgb2Zm c2V0LCBidWZmZXIsCj4gLQkJCQkgc2l6ZSk7Cj4gKwlpZiAoYXV4LT5pc19yZW1vdGUpCj4gKwkJ cmV0ID0gZHJtX2RwX21zdF9kcGNkX3JlYWQoYXV4LCBvZmZzZXQsIGJ1ZmZlciwgc2l6ZSk7Cj4g KwllbHNlCj4gKwkJcmV0ID0gZHJtX2RwX2RwY2RfYWNjZXNzKGF1eCwgRFBfQVVYX05BVElWRV9S RUFELCBvZmZzZXQsCj4gKwkJCQkJIGJ1ZmZlciwgc2l6ZSk7Cj4gIAo+ICBvdXQ6Cj4gIAlkcm1f ZHBfZHVtcF9hY2Nlc3MoYXV4LCBEUF9BVVhfTkFUSVZFX1JFQUQsIG9mZnNldCwgYnVmZmVyLCBy ZXQpOwo+IEBAIC0yOTYsNyArMzAyLDcgQEAgRVhQT1JUX1NZTUJPTChkcm1fZHBfZHBjZF9yZWFk KTsKPiAgCj4gIC8qKgo+ICAgKiBkcm1fZHBfZHBjZF93cml0ZSgpIC0gd3JpdGUgYSBzZXJpZXMg b2YgYnl0ZXMgdG8gdGhlIERQQ0QKPiAtICogQGF1eDogRGlzcGxheVBvcnQgQVVYIGNoYW5uZWwK PiArICogQGF1eDogRGlzcGxheVBvcnQgQVVYIGNoYW5uZWwgKFNTVCBvciBNU1QpCj4gICAqIEBv ZmZzZXQ6IGFkZHJlc3Mgb2YgdGhlIChmaXJzdCkgcmVnaXN0ZXIgdG8gd3JpdGUKPiAgICogQGJ1 ZmZlcjogYnVmZmVyIGNvbnRhaW5pbmcgdGhlIHZhbHVlcyB0byB3cml0ZQo+ICAgKiBAc2l6ZTog bnVtYmVyIG9mIGJ5dGVzIGluIEBidWZmZXIKPiBAQCAtMzEzLDggKzMxOSwxMiBAQCBzc2l6ZV90 IGRybV9kcF9kcGNkX3dyaXRlKHN0cnVjdCBkcm1fZHBfYXV4ICphdXgsIHVuc2lnbmVkIGludCBv ZmZzZXQsCj4gIHsKPiAgCWludCByZXQ7Cj4gIAo+IC0JcmV0ID0gZHJtX2RwX2RwY2RfYWNjZXNz KGF1eCwgRFBfQVVYX05BVElWRV9XUklURSwgb2Zmc2V0LCBidWZmZXIsCj4gLQkJCQkgc2l6ZSk7 Cj4gKwlpZiAoYXV4LT5pc19yZW1vdGUpCj4gKwkJcmV0ID0gZHJtX2RwX21zdF9kcGNkX3dyaXRl KGF1eCwgb2Zmc2V0LCBidWZmZXIsIHNpemUpOwo+ICsJZWxzZQo+ICsJCXJldCA9IGRybV9kcF9k cGNkX2FjY2VzcyhhdXgsIERQX0FVWF9OQVRJVkVfV1JJVEUsIG9mZnNldCwKPiArCQkJCQkgYnVm ZmVyLCBzaXplKTsKPiArCj4gIAlkcm1fZHBfZHVtcF9hY2Nlc3MoYXV4LCBEUF9BVVhfTkFUSVZF X1dSSVRFLCBvZmZzZXQsIGJ1ZmZlciwgcmV0KTsKPiAgCXJldHVybiByZXQ7Cj4gIH0KCi0tIApK YW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgR3JhcGhpY3MgQ2VudGVyCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==