From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a5d:51d0:0:0:0:0:0 with SMTP id n16csp9173637wrv; Fri, 9 Aug 2019 06:03:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqwMHs39u9yBjv8MZJzi2adOOCCMvqEiWo6V2Rj4XLd3rNz1p7WU6RJnYpb8I9sx07De6+hv X-Received: by 2002:ac8:35f7:: with SMTP id l52mr13332858qtb.299.1565355786041; Fri, 09 Aug 2019 06:03:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565355786; cv=none; d=google.com; s=arc-20160816; b=THjBOAEOa1MNABsgfI1lNUPBDQk1cIjO1UTKwOhD6j3LkqFJouIAJ13e+ngpcYC3Xo bzSak7tFrt/GkVuW/Ba/xRu/nacc8rt8Q2UQ7odRzV17Kawvp3/ytixr92T4tu2yQUjf ArANrHlqeDhxkRHfVZtY/sKSqq8fHiTCFo2c4wT/8RB6xTBNXzRZ3njznlXC+TAXXjaw PGJMn5BSEXlO0bb6etxkKkLVAOQDzlyQ5SnSyvo56HoC+koq3oCDJwN4zYCyrinbBb+D rIHWRU4nLIk5nSKRokr8lsV1g9R3cmGGN+NZrA6324qXoyvcTHps9/UYkI12sVSRST1a sCiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:user-agent:references:in-reply-to:to :from; bh=o+lL9O2PNKz0vyapYoA0x3WXq0cHi+Oa6EulYQ8zM4I=; b=U+4gxV5sCrvoV57+iXWLmBA/qoAdUDC4qW2X6MSV3hx+a52Ip+lrr8SE/S0z6oK1t4 96fqhPO8D4dUEjnj/GNGlv4fpfZ4lXO47Ko7SrKYt/+F9tQvyItia7EMlaRliq0/+E2h uhKmqZUr9yWqBaNTVBzEOXbbOyv2Zb35G48l+AOrliSUfwFDWLAE/ILIuWJwbs77O0uQ nEhtDbMMeP0qohJmvELG31jx2+40KquX+kbMFoSFJVRBZL17biz0P6ceXtk+GdFg6pkj z21tiDRGFsgaOEmPNrzBKiUr2vxch2X5N/UPBp93y1O87J5h9dJNK3Hfa1vLlM7iLc8N 97lQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id i22si57984081qta.152.2019.08.09.06.03.05 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 09 Aug 2019 06:03:05 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:59287 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hw4Xx-000527-G9 for alex.bennee@linaro.org; Fri, 09 Aug 2019 09:03:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55323) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hw4Xp-000516-Mv for qemu-arm@nongnu.org; Fri, 09 Aug 2019 09:02:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hw4Xo-00027F-6x for qemu-arm@nongnu.org; Fri, 09 Aug 2019 09:02:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47824) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hw4Xn-00026h-KS; Fri, 09 Aug 2019 09:02:55 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A82E13003C55; Fri, 9 Aug 2019 13:02:54 +0000 (UTC) Received: from redhat.com (ovpn-116-49.ams2.redhat.com [10.36.116.49]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 14C1960610; Fri, 9 Aug 2019 13:02:39 +0000 (UTC) From: Juan Quintela To: Damien Hedde In-Reply-To: <69a53af1-7007-7b80-8e6c-62ebabba8a62@greensocs.com> (Damien Hedde's message of "Fri, 9 Aug 2019 12:46:12 +0200") References: <20190729145654.14644-1-damien.hedde@greensocs.com> <20190729145654.14644-8-damien.hedde@greensocs.com> <20190808154219.GK2852@work-vm> <69a53af1-7007-7b80-8e6c-62ebabba8a62@greensocs.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Date: Fri, 09 Aug 2019 15:02:35 +0200 Message-ID: <87ef1u3310.fsf@trasno.org> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Fri, 09 Aug 2019 13:02:54 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-arm] [PATCH v3 07/33] automatically add vmstate for reset support in devices X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: quintela@redhat.com Cc: Fam Zheng , Peter Maydell , Collin Walling , Dmitry Fleytman , "Michael S. Tsirkin" , Mark Cave-Ayland , QEMU Developers , Gerd Hoffmann , Edgar Iglesias , Hannes Reinecke , Qemu-block , David Hildenbrand , Halil Pasic , Christian Borntraeger , Marcel Apfelbaum , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Richard Henderson , Thomas Huth , Eduardo Habkost , Alistair Francis , "Dr. David Alan Gilbert" , qemu-s390x , qemu-arm , =?utf-8?Q?C=C3=A9dric?= Le Goater , John Snow , David Gibson , "Daniel P. Berrange" , Cornelia Huck , Mark Burton , qemu-ppc , Paolo Bonzini Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: lmgrgF2AgXIJ Damien Hedde wrote: > On 8/9/19 12:32 PM, Peter Maydell wrote: >> On Fri, 9 Aug 2019 at 11:29, Damien Hedde wrote: >>> >>> One way to keep the feature without copy-pasting vmsd would be to add >>> a new vmstate_register with an additional argument to pass the base >>> class vmsd section and handle the whole thing there. >> >> If we have a vmstate section which contains no actual data, >> only subsections with 'needed' functions, is it migration >> compatible with previous versions in the same way that >> tacking a subsection onto an existing function is? > > I don't think so because of the naming schema. I had to forge the > correct name for the reset subsection for every device. > Each subsection must be named after its parent section plus '/something'. That bit is easy. You jsut named it: "parent_name/subsection_name", no? Later, Juan. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BA27C433FF for ; Fri, 9 Aug 2019 13:03:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E3DE320B7C for ; Fri, 9 Aug 2019 13:03:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3DE320B7C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59296 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hw4YR-0005nE-6P for qemu-devel@archiver.kernel.org; Fri, 09 Aug 2019 09:03:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55373) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hw4Xu-00055o-UJ for qemu-devel@nongnu.org; Fri, 09 Aug 2019 09:03:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hw4Xt-0002A8-SS for qemu-devel@nongnu.org; Fri, 09 Aug 2019 09:03:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47824) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hw4Xn-00026h-KS; Fri, 09 Aug 2019 09:02:55 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A82E13003C55; Fri, 9 Aug 2019 13:02:54 +0000 (UTC) Received: from redhat.com (ovpn-116-49.ams2.redhat.com [10.36.116.49]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 14C1960610; Fri, 9 Aug 2019 13:02:39 +0000 (UTC) From: Juan Quintela To: Damien Hedde In-Reply-To: <69a53af1-7007-7b80-8e6c-62ebabba8a62@greensocs.com> (Damien Hedde's message of "Fri, 9 Aug 2019 12:46:12 +0200") References: <20190729145654.14644-1-damien.hedde@greensocs.com> <20190729145654.14644-8-damien.hedde@greensocs.com> <20190808154219.GK2852@work-vm> <69a53af1-7007-7b80-8e6c-62ebabba8a62@greensocs.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Date: Fri, 09 Aug 2019 15:02:35 +0200 Message-ID: <87ef1u3310.fsf@trasno.org> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Fri, 09 Aug 2019 13:02:54 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v3 07/33] automatically add vmstate for reset support in devices X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: quintela@redhat.com Cc: Fam Zheng , Peter Maydell , Collin Walling , Dmitry Fleytman , "Michael S. Tsirkin" , Mark Cave-Ayland , QEMU Developers , Gerd Hoffmann , Edgar Iglesias , Hannes Reinecke , Qemu-block , David Hildenbrand , Halil Pasic , Christian Borntraeger , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Richard Henderson , Thomas Huth , Eduardo Habkost , Alistair Francis , "Dr. David Alan Gilbert" , qemu-s390x , qemu-arm , =?utf-8?Q?C=C3=A9dric?= Le Goater , John Snow , David Gibson , "Daniel P. Berrange" , Cornelia Huck , Mark Burton , qemu-ppc , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Damien Hedde wrote: > On 8/9/19 12:32 PM, Peter Maydell wrote: >> On Fri, 9 Aug 2019 at 11:29, Damien Hedde wrote: >>> >>> One way to keep the feature without copy-pasting vmsd would be to add >>> a new vmstate_register with an additional argument to pass the base >>> class vmsd section and handle the whole thing there. >> >> If we have a vmstate section which contains no actual data, >> only subsections with 'needed' functions, is it migration >> compatible with previous versions in the same way that >> tacking a subsection onto an existing function is? > > I don't think so because of the naming schema. I had to forge the > correct name for the reset subsection for every device. > Each subsection must be named after its parent section plus '/something'. That bit is easy. You jsut named it: "parent_name/subsection_name", no? Later, Juan.