From: Kalle Valo <kvalo@codeaurora.org>
To: Tony Chuang <yhchuang@realtek.com>
Cc: Brian Norris <briannorris@chromium.org>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>
Subject: Re: [RFC PATCH] rtw88: use txpwr_lmt_cfg_pair struct, not arrays
Date: Thu, 25 Jul 2019 08:59:40 +0300 [thread overview]
Message-ID: <87ef2ezmb7.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <F7CD281DE3E379468C6D07993EA72F84D187DDAE@RTITMBSVM04.realtek.com.tw> (Tony Chuang's message of "Thu, 25 Jul 2019 02:26:45 +0000")
Tony Chuang <yhchuang@realtek.com> writes:
>> Brian Norris <briannorris@chromium.org> wrote:
>>
>> > We're just trusting that these tables are of the right dimensions, when
>> > we could do better by just using the struct directly. Let's expose the
>> > struct txpwr_lmt_cfg_pair instead.
>> >
>> > The table changes were made by using some Vim macros, so that should
>> > help prevent any translation mistakes along the way.
>> >
>> > Remaining work: get the 'void *data' out of the generic struct
>> > rtw_table; all of these tables really deserve to be their own data
>> > structure, with proper type fields.
>> >
>> > Signed-off-by: Brian Norris <briannorris@chromium.org>
>>
>> To me this looks like a clear improvement and I'm inclined to apply it. Tony,
>> what do you think?
>
> I think it indeed is better to use struct instead of arrays to access the table.
> But what I am trying to do is to figure a way to write a proper struct for
> radio_[ab] tables. Since the parsing logic is more complicated than others.
>
> Once I finished them, I will send a patch to change the tables.
Are you saying that your patch will also clean up these txpwr tables and
I should drop this patch? Or can I apply this?
--
Kalle Valo
next prev parent reply other threads:[~2019-07-25 5:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-13 1:32 [RFC PATCH] rtw88: use txpwr_lmt_cfg_pair struct, not arrays Brian Norris
2019-07-24 11:23 ` Kalle Valo
2019-07-25 2:26 ` Tony Chuang
2019-07-25 5:59 ` Kalle Valo [this message]
2019-07-25 8:55 ` Tony Chuang
2019-08-06 12:25 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ef2ezmb7.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=briannorris@chromium.org \
--cc=linux-wireless@vger.kernel.org \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.