From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 3/3] drm/i915: Disable PSMI idle messaging when stopping ring Date: Thu, 28 Feb 2019 18:33:50 +0200 Message-ID: <87ef7rvpn5.fsf@gaia.fi.intel.com> References: <20190228160133.819-1-mika.kuoppala@linux.intel.com> <20190228160133.819-3-mika.kuoppala@linux.intel.com> <155137096226.5847.2098547421682849940@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id B75C56E20C for ; Thu, 28 Feb 2019 16:34:18 +0000 (UTC) In-Reply-To: <155137096226.5847.2098547421682849940@skylake-alporthouse-com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gUXVvdGlu ZyBNaWthIEt1b3BwYWxhICgyMDE5LTAyLTI4IDE2OjAxOjMzKQo+PiBIYXJkd2FyZSBjYW5ub3Qg YmUgaW4gYSBtaWRkbGUgb2YgaWRsZSBmbG93IG1lc3NhZ2luZwo+PiB3aGVuIHdlIHB1bGwgdGhl IHBsdWcgZnJvbSByaW5nYnVmZmVyLiBEaXNhYmxlIGlkbGUKPj4gbWVzc2FnaW5nIGJlZm9yZSB3 ZSBkbyBzbyB0byBhdm9pZCBwb3RlbnRpYWwgZGVhZGxvY2sKPj4gb24gZW5naW5lIGluaXRpYWxp emF0aW9uIGFuZCByZXNldC4KPj4gCj4+IHYyOiBJTlZBTElEX01NSU9fUkVHLCB1bmNvbmRpdGlv bmFsIGVuYWJsZSAoQ2hyaXMpCj4+IHYzOiBjb21tZW50IChDaHJpcyksIGJzcGVjIHJlZmVyZW5j ZQo+PiAKPj4gUmVmZXJlbmNlczogYnNwZWMvMTE3NTEKPj4gQ2M6IENocmlzIFdpbHNvbiA8Y2hy aXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+PiBBY2tlZC1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0Bj aHJpcy13aWxzb24uY28udWs+Cj4+IFNpZ25lZC1vZmYtYnk6IE1pa2EgS3VvcHBhbGEgPG1pa2Eu a3VvcHBhbGFAbGludXguaW50ZWwuY29tPgo+PiAtLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2VuZ2luZV9jcy5jIHwgNjQgKysrKysrKysrKysrKysrKysrKysrKysrKy0KPj4gIDEg ZmlsZSBjaGFuZ2VkLCA2MyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4+IAo+PiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVfY3MuYwo+PiBpbmRleCAyYTk0YjkyY2ZjZDMuLjEw Y2I2YjIyZmU5MiAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5n aW5lX2NzLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMK Pj4gQEAgLTc2NCw3ICs3NjQsNyBAQCBpbnQgaW50ZWxfZW5naW5lX2luaXRfY29tbW9uKHN0cnVj dCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPj4gIAo+PiAgLyoqCj4+ICAgKiBpbnRlbF9lbmdp bmVzX2NsZWFudXBfY29tbW9uIC0gY2xlYW5zIHVwIHRoZSBlbmdpbmUgc3RhdGUgY3JlYXRlZCBi eQo+PiAtICogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRoZSBjb21tb24gaW5pdGlh aWxpemVycy4KPj4gKyAqICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB0aGUgY29tbW9u IGluaXRpYWxpemVycy4KPj4gICAqIEBlbmdpbmU6IEVuZ2luZSB0byBjbGVhbnVwLgo+PiAgICoK Pj4gICAqIFRoaXMgY2xlYW5zIHVwIGV2ZXJ5dGhpbmcgY3JlYXRlZCBieSB0aGUgY29tbW9uIGhl bHBlcnMuCj4+IEBAIC04NjUsNiArODY1LDYzIEBAIHZvaWQgaW50ZWxfZW5naW5lX2NhbmNlbF9z dG9wX2NzKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPj4gICAgICAgICAgICAgICAg ICAgICAgIF9NQVNLRURfQklUX0RJU0FCTEUoU1RPUF9SSU5HKSk7Cj4+ICB9Cj4+ICAKPj4gK3N0 YXRpYyBpOTE1X3JlZ190IGdldF9pZGxlX3BvbGxfcmVnKGNvbnN0IHN0cnVjdCBpbnRlbF9lbmdp bmVfY3MgKmVuZ2luZSkKPj4gK3sKPj4gKyAgICAgICBpZiAoZW5naW5lLT5pZCAhPSBSQ1MpCj4+ ICsgICAgICAgICAgICAgICByZXR1cm4gSU5WQUxJRF9NTUlPX1JFRzsKPj4gKwo+PiArICAgICAg IGlmIChJU19HRU4oZW5naW5lLT5pOTE1LCA5KSkKPj4gKyAgICAgICAgICAgICAgIHJldHVybiBH RU45X1JDU19GRV9GU00yOwo+PiArCj4+ICsgICAgICAgaWYgKElTX0dFTihlbmdpbmUtPmk5MTUs IDgpKQo+PiArICAgICAgICAgICAgICAgcmV0dXJuIEdFTjZfUkNTX1BXUl9GU007Cj4+ICsKPj4g KyAgICAgICByZXR1cm4gSU5WQUxJRF9NTUlPX1JFRzsKPj4gK30KPj4gKwo+PiArc3RhdGljIHZv aWQgZGlzYWJsZV9pZGxlX21lc3NhZ2luZyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUp Cj4+ICt7Cj4+ICsgICAgICAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZW5n aW5lLT5pOTE1Owo+PiArICAgICAgIGk5MTVfcmVnX3QgcG9sbF9yZWc7Cj4+ICsKPj4gKyAgICAg ICBwb2xsX3JlZyA9IGdldF9pZGxlX3BvbGxfcmVnKGVuZ2luZSk7Cj4+ICsgICAgICAgaWYgKCFp OTE1X21taW9fcmVnX3ZhbGlkKHBvbGxfcmVnKSkKPj4gKyAgICAgICAgICAgICAgIHJldHVybjsK Pj4gKwo+PiArICAgICAgIEdFTV9ERUJVR19XQVJOX09OKEk5MTVfUkVBRF9GVyhHRU42X1JDX1NM RUVQX1BTTUlfQ09OVFJPTCkgJgo+PiArICAgICAgICAgICAgICAgICAgICAgICAgIEdFTjZfUFNN SV9TTEVFUF9NU0dfRElTQUJMRSk7Cj4+ICsgICAgICAgLyoKPj4gKyAgICAgICAgKiBIYXJkd2Fy ZSBtdXN0IG5vdCBiZSBpbiBtaWRkbGUgb2YgaWRsZSBmbG93IHNpZ25hbGxpbmcKPj4gKyAgICAg ICAgKiB3aGVuIHRoZSBSSU5HX0NUTCBpcyB6ZXJvZWQuIEluIG9yZGVyIHRvIHByZXZlbnQgdGhp cwo+PiArICAgICAgICAqIHdlIGRpc2FibGUgdGhlIG1lc3NhZ2luZyB0ZW1wb3JhcmlseS4KPj4g KyAgICAgICAgKi8KPj4gKyAgICAgICBJOTE1X1dSSVRFX0ZXKEdFTjZfUkNfU0xFRVBfUFNNSV9D T05UUk9MLAo+PiArICAgICAgICAgICAgICAgICAgICAgX01BU0tFRF9CSVRfRU5BQkxFKEdFTjZf UFNNSV9TTEVFUF9NU0dfRElTQUJMRSkpOwo+PiArCj4+ICsgICAgICAgLyoKPj4gKyAgICAgICAg KiBQb2xsIHRoZSBtYWdpYyBiaXRzIHRvIGVuc3VyZSB0aGF0IGVuZ2luZSBzdGF0ZSBtYWNoaW5l Cj4+ICsgICAgICAgICogaXMgaW4gdmFsaWQgc3RhdGUgZm9yIHN0b3BwaW5nIHRoZSByaW5nLgo+ PiArICAgICAgICAqLwo+PiArICAgICAgIGlmIChfX2ludGVsX3dhaXRfZm9yX3JlZ2lzdGVyX2Z3 KGRldl9wcml2LCBwb2xsX3JlZywKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAweDdmLCAweDMwLAo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIDUwMDAsIDAsCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgTlVMTCkpCj4+ICsgICAgICAgICAgICAgICBEUk1fREVCVUdfRFJJVkVSKCJwc21pIGlkbGUg bXNnIHBvbGwgdGltZW91dFxuIik7Cj4+ICt9Cj4+ICsKPj4gK3N0YXRpYyB2b2lkIGVuYWJsZV9p ZGxlX21lc3NhZ2luZyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4+ICt7Cj4+ICsg ICAgICAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZW5naW5lLT5pOTE1Owo+ PiArICAgICAgIGk5MTVfcmVnX3QgcG9sbF9yZWc7Cj4+ICsKPj4gKyAgICAgICBwb2xsX3JlZyA9 IGdldF9pZGxlX3BvbGxfcmVnKGVuZ2luZSk7Cj4+ICsgICAgICAgaWYgKCFpOTE1X21taW9fcmVn X3ZhbGlkKHBvbGxfcmVnKSkKPj4gKyAgICAgICAgICAgICAgIHJldHVybjsKPj4gKwo+PiArICAg ICAgIEk5MTVfV1JJVEVfRlcoR0VONl9SQ19TTEVFUF9QU01JX0NPTlRST0wsCj4+ICsgICAgICAg ICAgICAgICAgICAgICBfTUFTS0VEX0JJVF9ESVNBQkxFKEdFTjZfUFNNSV9TTEVFUF9NU0dfRElT QUJMRSkpOwo+PiArfQo+PiArCj4+ICBpbnQgaW50ZWxfZW5naW5lX3N0b3BfcmluZyhzdHJ1Y3Qg aW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4+ICB7Cj4+ICAgICAgICAgc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2ID0gZW5naW5lLT5pOTE1Owo+PiBAQCAtODgwLDkgKzkzNywxNCBA QCBpbnQgaW50ZWxfZW5naW5lX3N0b3BfcmluZyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdp bmUpCj4+ICAgICAgICAgSTkxNV9XUklURV9GVyhSSU5HX1RBSUwoYmFzZSksIDApOwo+PiAgICAg ICAgIFBPU1RJTkdfUkVBRF9GVyhSSU5HX1RBSUwoYmFzZSkpOwo+PiAgCj4+ICsgICAgICAgLyog SWRsZSBtZXNzYWdpbmcgbmVlZHMgdG8gYmUgb2ZmIGR1cmluZyByaW5nIGRpc2FibGUgKi8KPgo+ IE9rLCB0aGF0J3Mgb3R0IDopCgpSZXN0IGFzc3VyZWQsIENhcHRhaW4gT2J2aW91cyB3aWxsIHNj cmFwIHRoaXMgYmVmb3JlIG1lcmdpbmcuCgo+Cj4gVGhlIHByZXZpb3VzIHBhaXIgYXJlIGEgbmlj ZSB3aHksIHBlZWxpbmcgYmFjayBzb21lIG9mIHRoZSBsYXllcnMgb2YgdGhlCj4gSFcgdG8gc2Vl IHdoYXQncyBnb2luZyBvbi4gVGhpcyBvbmUgaXMganVzdCByZXBlYXRpbmcKPiBkaXNhYmxlX2lk bGVfbWVzc2luZygpLgoKVGhlcmUgaXMgdGhpcyBkcmVhbSBJIGhhZCB3aGVyZSBoYXJkd2FyZSBl bmdpbmVlcnMKZGlkIHJldmlldyBwYXRjaGVzLgoKQnV0IGl0IHNob3VsZCBiZSBjbG9zZSBlbm91 Z2ggb2YgJ3doYXQncyBnb2luZyBvbicKClRoYW5rcywKLU1pa2EKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4