From: Felipe Balbi <balbi@kernel.org>
To: Thinh Nguyen <thinh.nguyen@synopsys.com>, linux-usb@vger.kernel.org
Cc: John Youn <john.youn@synopsys.com>, Bjorn Helgaas <helgaas@kernel.org>
Subject: usb: dwc3: haps: Workaround matching VID PID
Date: Thu, 07 Feb 2019 13:16:27 +0200 [thread overview]
Message-ID: <87ef8jlugk.fsf@linux.intel.com> (raw)
Hi,
Thinh Nguyen <thinh.nguyen@synopsys.com> writes:
> i.MX6QP and i.MX7D platform use a PCIe controller with the same VID and
> PID as this USB controller. The system may incorrectly match this driver
> to that PCIe controller. To workaround this, specifically use class type
> USB with PCI device ID to prevent incorrect driver matching.
>
> Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
> ---
> drivers/usb/dwc3/dwc3-haps.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/usb/dwc3/dwc3-haps.c b/drivers/usb/dwc3/dwc3-haps.c
> index 02d57d98ef9b..3cecbf169452 100644
> --- a/drivers/usb/dwc3/dwc3-haps.c
> +++ b/drivers/usb/dwc3/dwc3-haps.c
> @@ -106,6 +106,15 @@ static const struct pci_device_id dwc3_haps_id_table[] = {
> {
> PCI_DEVICE(PCI_VENDOR_ID_SYNOPSYS,
> PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3),
> + /*
> + * i.MX6QP and i.MX7D platform use a PCIe controller with the
> + * same VID and PID as this USB controller. The system may
> + * incorrectly match this driver to that PCIe controller. To
> + * workaround this, specifically use class type USB to prevent
> + * incorrect driver matching.
> + */
> + .class = (PCI_CLASS_SERIAL_USB << 8),
> + .class_mask = 0xffff00,
Just curious, how can NXP use Synopsys' vendor ID?
next reply other threads:[~2019-02-07 11:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 11:16 Felipe Balbi [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-02-07 20:59 usb: dwc3: haps: Workaround matching VID PID Thinh Nguyen
2019-02-06 18:49 Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ef8jlugk.fsf@linux.intel.com \
--to=balbi@kernel.org \
--cc=helgaas@kernel.org \
--cc=john.youn@synopsys.com \
--cc=linux-usb@vger.kernel.org \
--cc=thinh.nguyen@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.