All of lore.kernel.org
 help / color / mirror / Atom feed
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Tamir Carmeli <carmeli.tamir@gmail.com>
Cc: joe@perches.com, jthumshirn@suse.de,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	akpm@linux-foundation.org, axboe@kernel.dk,
	martin.petersen@oracle.com, bvanassche@acm.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] fat: New macros to determine the FAT variant (32, 16 or 12)
Date: Fri, 14 Dec 2018 18:49:28 +0900	[thread overview]
Message-ID: <87efakcuaf.fsf@mail.parknet.co.jp> (raw)
In-Reply-To: <CAKxm1-G7WpJV0_3=TLyY_JMN=Wz1GkM2w6buc6ez+WUZ_tyEhg@mail.gmail.com> (Tamir Carmeli's message of "Fri, 14 Dec 2018 10:14:35 +0200")

Tamir Carmeli <carmeli.tamir@gmail.com> writes:

> I just want to make sure, is there a reason why I shouldn't delete
> FAT_FIRST_ENT, as Joe Perches commented?

FAT_FIRST_ENT() was used to check if fat spec compliance. But in real
world, there are too many implementations that didn't follow spec.

Well, so, now FAT_FIRST_ENT() is pointed only from comment. The reason
is only for this comment.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

      reply	other threads:[~2018-12-14  9:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-10 19:41 [PATCH 0/2] fat: Added macros to determine the FAT FS variant (12/16/32bit) Carmeli Tamir
2018-12-10 19:41 ` [PATCH 1/2] fat: Moved macros that won't work without fat.h Carmeli Tamir
2018-12-10 19:41 ` [PATCH 2/2] fat: New macros to determine the FAT variant (32, 16 or 12) Carmeli Tamir
2018-12-10 20:09   ` Joe Perches
2018-12-14  3:16     ` OGAWA Hirofumi
2018-12-14  8:14       ` Tamir Carmeli
2018-12-14  9:49         ` OGAWA Hirofumi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87efakcuaf.fsf@mail.parknet.co.jp \
    --to=hirofumi@mail.parknet.co.jp \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=carmeli.tamir@gmail.com \
    --cc=joe@perches.com \
    --cc=jthumshirn@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=sergey.senozhatsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.