From: Markus Armbruster <armbru@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v3 for-4.0 0/9] qapi: Rewrite string-input-visitor's integer and list parsing
Date: Mon, 26 Nov 2018 18:33:44 +0100 [thread overview]
Message-ID: <87efb7iw07.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20181121164421.20780-1-david@redhat.com> (David Hildenbrand's message of "Wed, 21 Nov 2018 17:44:12 +0100")
David Hildenbrand <david@redhat.com> writes:
> Rewrite string-input-visitor to be (hopefully) less ugly. Support
> int and uint lists (including ranges, but not implemented via type
> "Range").
>
> Virtual walks are now supported and more errors are cought (and some bugs
> fixed). Fix and extend the tests. Parsing of uint64_t is now properly
> supported.
>
> Importantly, when parsing a list we now return the list and not an
> ordered set (we are not an ordered set parser after all). Whoever needs
> that can add it on top. As far as I can see, current code can deal with
> it but I'll have to look at the details.
>
> While at it, introduce and use qemu_strtod() and qemu_strtod_finite().
> However don't convert monitor.c as that seems to be too broken for me
> (it ignores both conversion errors and range errors, and there is an
> actual unit test in which conversion is expected to fail).
Queued for 4.0. Thanks a lot, David!
prev parent reply other threads:[~2018-11-26 17:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 16:44 [Qemu-devel] [PATCH v3 for-4.0 0/9] qapi: Rewrite string-input-visitor's integer and list parsing David Hildenbrand
2018-11-21 16:44 ` [Qemu-devel] [PATCH v3 for-4.0 1/9] cutils: Add qemu_strtod() and qemu_strtod_finite() David Hildenbrand
2018-11-21 17:43 ` Eric Blake
2018-11-21 16:44 ` [Qemu-devel] [PATCH v3 for-4.0 2/9] cutils: Fix qemu_strtosz() & friends to reject non-finite sizes David Hildenbrand
2018-11-21 16:44 ` [Qemu-devel] [PATCH v3 for-4.0 3/9] qapi: Fix string-input-visitor to reject NaN and infinities David Hildenbrand
2018-11-21 16:44 ` [Qemu-devel] [PATCH v3 for-4.0 4/9] qapi: Use qemu_strtod_finite() in qobject-input-visitor David Hildenbrand
2018-11-21 16:44 ` [Qemu-devel] [PATCH v3 for-4.0 5/9] test-string-input-visitor: Add more tests David Hildenbrand
2018-11-21 16:44 ` [Qemu-devel] [PATCH v3 for-4.0 6/9] qapi: Rewrite string-input-visitor's integer and list parsing David Hildenbrand
2018-11-21 16:44 ` [Qemu-devel] [PATCH v3 for-4.0 7/9] test-string-input-visitor: Use virtual walk David Hildenbrand
2018-11-21 16:44 ` [Qemu-devel] [PATCH v3 for-4.0 8/9] test-string-input-visitor: Split off uint64 list tests David Hildenbrand
2018-11-21 16:44 ` [Qemu-devel] [PATCH v3 for-4.0 9/9] test-string-input-visitor: Add range overflow tests David Hildenbrand
2018-11-26 17:33 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efb7iw07.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=david@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.