From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: Rob Herring <robh@kernel.org>
Cc: linux-kernel@vger.kernel.org, uclinux-h8-devel@lists.sourceforge.jp
Subject: Re: [PATCH] h8300: remove unnecessary of_platform_populate call
Date: Sun, 22 Jul 2018 23:11:00 +0900 [thread overview]
Message-ID: <87effvfjij.wl-ysato@users.sourceforge.jp> (raw)
In-Reply-To: <20180619214054.19326-1-robh@kernel.org>
On Wed, 20 Jun 2018 06:40:54 +0900,
Rob Herring wrote:
>
> The DT core will call of_platform_populate, so it is not necessary for
> arch specific code to call it unless there are custom match entries,
> auxdata or parent device. Neither of those apply here, so remove the call.
>
> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
> Cc: uclinux-h8-devel@lists.sourceforge.jp
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> arch/h8300/kernel/setup.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/arch/h8300/kernel/setup.c b/arch/h8300/kernel/setup.c
> index a4d0470c10a9..b2b51f75774e 100644
> --- a/arch/h8300/kernel/setup.c
> +++ b/arch/h8300/kernel/setup.c
> @@ -23,7 +23,6 @@
> #include <linux/init.h>
> #include <linux/of.h>
> #include <linux/of_fdt.h>
> -#include <linux/of_platform.h>
> #include <linux/of_address.h>
> #include <linux/clk-provider.h>
> #include <linux/memblock.h>
> @@ -188,15 +187,6 @@ const struct seq_operations cpuinfo_op = {
> .show = show_cpuinfo,
> };
>
> -static int __init device_probe(void)
> -{
> - of_platform_populate(NULL, NULL, NULL, NULL);
> -
> - return 0;
> -}
> -
> -device_initcall(device_probe);
> -
> #if defined(CONFIG_CPU_H8300H)
> #define get_wait(base, addr) ({ \
> int baddr; \
> --
> 2.17.1
>
Sorry. too late reply.
Applied to h8300-next.
Thanks.
--
Yosinori Sato
prev parent reply other threads:[~2018-07-22 14:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 21:40 [PATCH] h8300: remove unnecessary of_platform_populate call Rob Herring
2018-07-09 15:50 ` Rob Herring
2018-07-22 14:11 ` Yoshinori Sato [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87effvfjij.wl-ysato@users.sourceforge.jp \
--to=ysato@users.sourceforge.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=uclinux-h8-devel@lists.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.