From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 12/31] drm/i915: Reduce spinlock hold time during notify_ring() interrupt Date: Wed, 27 Jun 2018 17:01:20 +0300 Message-ID: <87efgsuy4v.fsf@gaia.fi.intel.com> References: <20180625094842.8499-1-chris@chris-wilson.co.uk> <20180625094842.8499-12-chris@chris-wilson.co.uk> <87h8lov0kt.fsf@gaia.fi.intel.com> <153010525341.8693.5922506177100832882@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 57F296E966 for ; Wed, 27 Jun 2018 14:02:04 +0000 (UTC) In-Reply-To: <153010525341.8693.5922506177100832882@mail.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gUXVvdGlu ZyBNaWthIEt1b3BwYWxhICgyMDE4LTA2LTI3IDE0OjA4OjM0KQo+PiBDaHJpcyBXaWxzb24gPGNo cmlzQGNocmlzLXdpbHNvbi5jby51az4gd3JpdGVzOgo+PiAKPj4gPiBCeSB0YWtpbmcgYWR2YW50 YWdlIG9mIHRoZSBSQ1UgcHJvdGVjdGlvbiBvZiB0aGUgdGFzayBzdHJ1Y3QsIHdlIGNhbiBmaW5k Cj4+ID4gdGhlIGFwcHJvcHJpYXRlIHNpZ25hbGVyIHVuZGVyIHRoZSBzcGlubG9jayBhbmQgdGhl biByZWxlYXNlIHRoZSBzcGlubG9jawo+PiA+IGJlZm9yZSB3YWtpbmcgdGhlIHRhc2sgYW5kIHNp Z25hbGluZyB0aGUgZmVuY2UuCj4+ID4KPj4gPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24g PGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPj4gPiAtLS0KPj4gPiAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9pcnEuYyB8IDMzICsrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLQo+ PiA+ICAxIGZpbGUgY2hhbmdlZCwgMjIgaW5zZXJ0aW9ucygrKSwgMTEgZGVsZXRpb25zKC0pCj4+ ID4KPj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPj4gPiBpbmRleCAzMTZkMGIwOGQ0MGYuLjUz ZGFkNDhmOTJjZSAxMDA2NDQKPj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2ly cS5jCj4+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+PiA+IEBAIC0x MTQ1LDIxICsxMTQ1LDIzIEBAIHN0YXRpYyB2b2lkIGlyb25sYWtlX3Jwc19jaGFuZ2VfaXJxX2hh bmRsZXIoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+PiA+ICAKPj4gPiAgc3Rh dGljIHZvaWQgbm90aWZ5X3Jpbmcoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+PiA+ ICB7Cj4+ID4gKyAgICAgY29uc3QgdTMyIHNlcW5vID0gaW50ZWxfZW5naW5lX2dldF9zZXFubyhl bmdpbmUpOwo+PiA+ICAgICAgIHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJxID0gTlVMTDsKPj4gPiAr ICAgICBzdHJ1Y3QgdGFza19zdHJ1Y3QgKnRzayA9IE5VTEw7Cj4+ID4gICAgICAgc3RydWN0IGlu dGVsX3dhaXQgKndhaXQ7Cj4+ID4gIAo+PiA+IC0gICAgIGlmICghZW5naW5lLT5icmVhZGNydW1i cy5pcnFfYXJtZWQpCj4+ID4gKyAgICAgaWYgKHVubGlrZWx5KCFlbmdpbmUtPmJyZWFkY3J1bWJz LmlycV9hcm1lZCkpCj4+ID4gICAgICAgICAgICAgICByZXR1cm47Cj4+ID4KPj4gCj4+IE9rLCBz byBkdWUgdG8gdW5saWtlbGluZXNzLCB5b3UgZ2V0IHRoZSBzZXFubyBlYXJseS4KPj4gCj4+ID4g ICAgICAgYXRvbWljX2luYygmZW5naW5lLT5pcnFfY291bnQpOwo+PiA+IC0gICAgIHNldF9iaXQo RU5HSU5FX0lSUV9CUkVBRENSVU1CLCAmZW5naW5lLT5pcnFfcG9zdGVkKTsKPj4gPiArCj4+ID4g KyAgICAgcmN1X3JlYWRfbG9jaygpOwo+PiAKPj4gQXMgSSB1bmRlcnN0YW5kIGZyb20gaXJjIGRp c2N1c3Npb24sIHdlIGhhdmUgb3VyIG93biBjb25zdAo+PiBvciBzdGFibGUgY29weSBvZiB0YXNr IHN0cnVjdCBmcm9tIG5vdyBvbi4KPj4gPiAgCj4+ID4gICAgICAgc3Bpbl9sb2NrKCZlbmdpbmUt PmJyZWFkY3J1bWJzLmlycV9sb2NrKTsKPj4gPiAgICAgICB3YWl0ID0gZW5naW5lLT5icmVhZGNy dW1icy5pcnFfd2FpdDsKPj4gPiAgICAgICBpZiAod2FpdCkgewo+PiA+IC0gICAgICAgICAgICAg Ym9vbCB3YWtldXAgPSBlbmdpbmUtPmlycV9zZXFub19iYXJyaWVyOwo+PiA+IC0KPj4gPiAtICAg ICAgICAgICAgIC8qIFdlIHVzZSBhIGNhbGxiYWNrIGZyb20gdGhlIGRtYS1mZW5jZSB0byBzdWJt aXQKPj4gPiArICAgICAgICAgICAgIC8qCj4+ID4gKyAgICAgICAgICAgICAgKiBXZSB1c2UgYSBj YWxsYmFjayBmcm9tIHRoZSBkbWEtZmVuY2UgdG8gc3VibWl0Cj4+ID4gICAgICAgICAgICAgICAg KiByZXF1ZXN0cyBhZnRlciB3YWl0aW5nIG9uIG91ciBvd24gcmVxdWVzdHMuIFRvCj4+ID4gICAg ICAgICAgICAgICAgKiBlbnN1cmUgbWluaW11bSBkZWxheSBpbiBxdWV1aW5nIHRoZSBuZXh0IHJl cXVlc3QgdG8KPj4gPiAgICAgICAgICAgICAgICAqIGhhcmR3YXJlLCBzaWduYWwgdGhlIGZlbmNl IG5vdyByYXRoZXIgdGhhbiB3YWl0IGZvcgo+PiA+IEBAIC0xMTcwLDE5ICsxMTcyLDIzIEBAIHN0 YXRpYyB2b2lkIG5vdGlmeV9yaW5nKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPj4g PiAgICAgICAgICAgICAgICAqIGFuZCB0byBoYW5kbGUgY29hbGVzY2luZyBvZiBtdWx0aXBsZSBz ZXFubyB1cGRhdGVzCj4+ID4gICAgICAgICAgICAgICAgKiBhbmQgbWFueSB3YWl0ZXJzLgo+PiA+ ICAgICAgICAgICAgICAgICovCj4+ID4gLSAgICAgICAgICAgICBpZiAoaTkxNV9zZXFub19wYXNz ZWQoaW50ZWxfZW5naW5lX2dldF9zZXFubyhlbmdpbmUpLAo+PiA+IC0gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHdhaXQtPnNlcW5vKSkgewo+PiA+ICsgICAgICAgICAgICAgaWYg KGk5MTVfc2Vxbm9fcGFzc2VkKHNlcW5vLCB3YWl0LT5zZXFubykpIHsKPj4gPiAgICAgICAgICAg ICAgICAgICAgICAgc3RydWN0IGk5MTVfcmVxdWVzdCAqd2FpdGVyID0gd2FpdC0+cmVxdWVzdDsK Pj4gPiAgCj4+ID4gLSAgICAgICAgICAgICAgICAgICAgIHdha2V1cCA9IHRydWU7Cj4+ID4gICAg ICAgICAgICAgICAgICAgICAgIGlmICghdGVzdF9iaXQoRE1BX0ZFTkNFX0ZMQUdfU0lHTkFMRURf QklULAo+PiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZ3YWl0ZXItPmZl bmNlLmZsYWdzKSAmJgo+PiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgaW50ZWxfd2FpdF9j aGVja19yZXF1ZXN0KHdhaXQsIHdhaXRlcikpCj4+ID4gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgcnEgPSBpOTE1X3JlcXVlc3RfZ2V0KHdhaXRlcik7Cj4+ID4gLSAgICAgICAgICAgICB9 Cj4+ID4gIAo+PiA+IC0gICAgICAgICAgICAgaWYgKHdha2V1cCkKPj4gPiAtICAgICAgICAgICAg ICAgICAgICAgd2FrZV91cF9wcm9jZXNzKHdhaXQtPnRzayk7Cj4+ID4gKyAgICAgICAgICAgICAg ICAgICAgIHRzayA9IHdhaXQtPnRzazsKPj4gPiArICAgICAgICAgICAgIH0gZWxzZSB7Cj4+ID4g KyAgICAgICAgICAgICAgICAgICAgIGlmIChlbmdpbmUtPmlycV9zZXFub19iYXJyaWVyICYmCj4+ ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICBpOTE1X3NlcW5vX3Bhc3NlZChzZXFubywgd2Fp dC0+c2Vxbm8gLSAxKSkgewo+PiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNldF9i aXQoRU5HSU5FX0lSUV9CUkVBRENSVU1CLAo+PiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgJmVuZ2luZS0+aXJxX3Bvc3RlZCk7Cj4+ID4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgdHNrID0gd2FpdC0+dHNrOwo+PiAKPj4gSG1tLCB5b3UgYXJlIG9wdGltaXN0 aWMgdGhhdCB0aGUgbGF0ZW5jeSBvZiB3YWtldXAgd2lsbCBiZSBvbiBwYXIKPj4gb3IgZ3JlYXRl ciB0aGFuIHRoZSBuZXh0IHJlcXVlc3QgY29tcGxldGlvbj8KPj4gCj4+IEFuZCB3YWl0IHNpZGUg bm90aWNlcyB0b28gdGhhdCB3ZSBhcmUgY2xvc2UgYW5kIHNwaW5zLAo+PiBpbnN0ZWFkIG9mIGdv aW5nIGJhY2sgdG8gc2xlZXA/Cj4KPiBEb24ndCBmb3JnZXQgdGhpcyBpcyB0aGUgbWlzc2VkIGJy ZWFkY3J1bWIgbWl0aWdhdGlvbiBmb3IgZ2VuNS1nZW43LCBhbmQKPiBvbmx5IGZvciBpdC4gVGhl IGludGVudCBpcyB0byBrZWVwIHRoYXQgYXdheSBmcm9tIHRoZSBwYXRocyB0aGF0IGRvIG5vdAo+ IG5lZWQgdGhlIGV4dHJhIGRlbGF5cy4KPgoKTG9va3Mgc2Vuc2libGUgb3B0aW1pemF0aW9uLiBC dXQgSSB3b3VsZCBzdHJpcCBpdCBvdXQgZnJvbSB0aGlzCnBhdGNoIHRvIGl0J3Mgb3duLCB0byBr ZWVwIHRoZSBjb250ZW50IGluIHN5bmMgd2l0aCB0aGUgY29tbWl0IG1lc3NhZ2UuCgotTWlrYQpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZngg bWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK