From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37488) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fToAy-0000kO-2Y for qemu-devel@nongnu.org; Fri, 15 Jun 2018 08:50:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fToAt-0006TE-7M for qemu-devel@nongnu.org; Fri, 15 Jun 2018 08:50:00 -0400 Received: from oxygen.pond.sub.org ([144.76.244.19]:35520) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fToAt-0006SU-13 for qemu-devel@nongnu.org; Fri, 15 Jun 2018 08:49:55 -0400 From: Markus Armbruster References: <20180615014249.22730-1-peterx@redhat.com> <20180615014249.22730-2-peterx@redhat.com> Date: Fri, 15 Jun 2018 14:49:52 +0200 Message-ID: <87efh81afj.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 1/6] chardev: comment details for CLOSED event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: qemu-devel@nongnu.org, Kevin Wolf , Peter Maydell , Fam Zheng , Eric Auger , John Snow , Max Reitz , Christian Borntraeger , "Dr . David Alan Gilbert" , Stefan Hajnoczi , Paolo Bonzini , =?utf-8?Q?M?= =?utf-8?Q?arc-Andr=C3=A9?= Lureau , Markus Armbruster Peter Xu writes: > It was unclear before on what does the CLOSED event mean. Meanwhile we > add a TODO to fix up the CLOSED event in the future when the in/out > ports are different for a chardev. > > CC: Paolo Bonzini > CC: "Marc-Andr=C3=A9 Lureau" > CC: Stefan Hajnoczi > CC: Markus Armbruster > Signed-off-by: Peter Xu > --- > include/chardev/char.h | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/include/chardev/char.h b/include/chardev/char.h > index 04de45795e..6f0576e214 100644 > --- a/include/chardev/char.h > +++ b/include/chardev/char.h > @@ -22,7 +22,16 @@ typedef enum { > CHR_EVENT_OPENED, /* new connection established */ > CHR_EVENT_MUX_IN, /* mux-focus was set to this terminal */ > CHR_EVENT_MUX_OUT, /* mux-focus will move on */ > - CHR_EVENT_CLOSED /* connection closed */ > + CHR_EVENT_CLOSED /* connection closed. NOTE: currently this event > + * is only bound to the read port of the chardev. > + * Normally the read port and write port of a > + * chardev should be the same, but it can be > + * different, e.g., for fd chardevs, when the two > + * fds are different. So when we received the > + * CLOSED event it's still possible that the out > + * port is still open. TODO: we should only send > + * the CLOSED event when both ports are closed. > + */ > } QEMUChrEvent; >=20=20 > #define CHR_READ_BUF_LEN 4096 Undefined terms "read port" and "write port". But the header is full of undefined terms, like "front end", "back end", "data channel", "chardev peer", ... It could use a file comment to tie things together. Clearly out of scope for this series.