From: Esben Haabendal <esben.haabendal@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, alexander.levin@microsoft.com,
davem@davemloft.net
Subject: Re: Missing prerequisite for arm-dts-ls1021a-specify-tbipa-register-address.patch
Date: Tue, 29 May 2018 08:56:00 +0200 [thread overview]
Message-ID: <87efhvosqn.fsf@gmail.com> (raw)
In-Reply-To: <20180528095812.GA15540@kroah.com> (Greg KH's message of "Mon, 28 May 2018 11:58:12 +0200")
Greg KH <gregkh@linuxfoundation.org> writes:
> On Mon, May 28, 2018 at 11:49:13AM +0200, Esben Haabendal wrote:
>> Greg KH <gregkh@linuxfoundation.org> writes:
>>
>> > On Mon, May 28, 2018 at 08:20:15AM +0200, Esben Haabendal wrote:
>> >> Hi
>> >>
>> >> The arm-dts-ls1021a-specify-tbipa-register-address.patch which have just
>> >> been added to 4.4-stable, 4.9-stable, 4.14-stable and 4.16-stable trees,
>> >> relies on the 2d23129b00d2a67e58a7b17205f5ba7ec4523fd0 in order to make
>> >> sense.
>> >>
>> >> Could 2d23129b00d2a67e58a7b17205f5ba7ec4523fd0 be added to those trees
>> >> as well?
>> >
>> > ~/linux/stable/linux-stable $ git show
>> > 2d23129b00d2a67e58a7b17205f5ba7ec4523fd0
>> > fatal: bad object 2d23129b00d2a67e58a7b17205f5ba7ec4523fd0
>> >
>> > Are you sure that is the correct git id?
>>
>> Obviously not.
>>
>> The correct id is 21481189e8ffa4016e398d46ac6d66fb0f23acc3
>>
>> Sorry about that.
>
> In looking at this patch, it just seems to be changing the way the
> information is retrieved from the hardware/dts file, and as such, does
> not seem like a viable stable kernel patch at this point in time.
>
> So I've removed the original
> arm-dts-ls1021a-specify-tbipa-register-address.patch patch from all of
> the specific kernel patch queues now.
Yes, 21481189e8ffa4016e398d46ac6d66fb0f23acc3 changes the way the TBIPA
register is accessed. But only if DTS has two register blocks, which is
not the case without 5571196135abb6d51e01592812997403c136067c.
So I think it is fair to say that it is backwards compatible, but
whether it together with 5571196135abb6d51e01592812997403c136067c is
viable for stable right now is another question.
They do change how hardware is accessed, but they changes it so that it
fixes a bug on LS1021A.
/Esben
prev parent reply other threads:[~2018-05-29 6:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-28 6:20 Missing prerequisite for arm-dts-ls1021a-specify-tbipa-register-address.patch Esben Haabendal
2018-05-28 7:55 ` Greg KH
2018-05-28 9:49 ` Esben Haabendal
2018-05-28 9:58 ` Greg KH
2018-05-29 6:56 ` Esben Haabendal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efhvosqn.fsf@gmail.com \
--to=esben.haabendal@gmail.com \
--cc=alexander.levin@microsoft.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.