From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Johannes Berg <johannes@sipsolutions.net>,
Kalle Valo <kvalo@codeaurora.org>
Cc: kbuild test robot <lkp@intel.com>,
kbuild-all@01.org, linux-wireless@vger.kernel.org,
Maya Erez <merez@codeaurora.org>
Subject: Re: [mac80211-next:master 12/14] drivers/net//wireless/ath/wil6210/debugfs.c:1245:1: warning: the frame size of 1600 bytes is larger than 1024 bytes
Date: Wed, 09 May 2018 11:36:23 +0200 [thread overview]
Message-ID: <87efil41d4.fsf@toke.dk> (raw)
In-Reply-To: <1525856418.6910.6.camel@sipsolutions.net>
Johannes Berg <johannes@sipsolutions.net> writes:
> On Wed, 2018-05-09 at 11:56 +0300, Kalle Valo wrote:
>> Johannes Berg <johannes@sipsolutions.net> writes:
>>
>> > On Wed, 2018-05-09 at 11:47 +0300, Kalle Valo wrote:
>> > >
>> > > I guess these warnings come because Toke's patch increased size of
>> > > struct cfg80211_tid_stats (which is included in struct station_info) and
>> > > both wil6210 and qtnfmac allocate a struct station_info from stack?
>> >
>> > Yes.
>> >
>> > > Can
>> > > someone send a fix for the drivers?
>> >
>> > I guess Toke/I should do that through my tree.
>>
>> IMHO the fix could go through my tree as well, less risk of conflicts in
>> drivers. AFAICS the fix (allocating station_info dynamically?) would not
>> depend on Toke's patch and could be applied separately.
>
> That's true, if you prefer that it's fine with me.
I'll send a patch.
What's the right tag to put in the commit for this?
Fixes-but-is-independent-from: ? ;)
-Toke
next prev parent reply other threads:[~2018-05-09 9:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 17:39 [mac80211-next:master 12/14] drivers/net//wireless/ath/wil6210/debugfs.c:1245:1: warning: the frame size of 1600 bytes is larger than 1024 bytes kbuild test robot
2018-05-09 8:47 ` Kalle Valo
2018-05-09 8:51 ` Johannes Berg
2018-05-09 8:56 ` Kalle Valo
2018-05-09 9:00 ` Johannes Berg
2018-05-09 9:36 ` Toke Høiland-Jørgensen [this message]
2018-05-09 9:36 ` Johannes Berg
2018-05-09 9:48 ` Kalle Valo
2018-05-09 10:07 ` Toke Høiland-Jørgensen
2018-05-09 10:14 ` Kalle Valo
2018-05-09 10:17 ` Toke Høiland-Jørgensen
2018-05-09 10:30 ` Toke Høiland-Jørgensen
2018-05-09 11:01 ` Kalle Valo
2018-05-09 11:47 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efil41d4.fsf@toke.dk \
--to=toke@toke.dk \
--cc=johannes@sipsolutions.net \
--cc=kbuild-all@01.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lkp@intel.com \
--cc=merez@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.