From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Subject: Re: [PATCH v2] drm/i915/guc: Allow preempt-client to be
 NULL
Date: Wed, 31 Jan 2018 15:14:49 +0200
Message-ID: <87efm6w4om.fsf@gaia.fi.intel.com>
References: <87mv0uw9he.fsf@gaia.fi.intel.com>
 <20180131120300.16193-1-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 000E06E4F5
 for <intel-gfx@lists.freedesktop.org>; Wed, 31 Jan 2018 13:15:08 +0000 (UTC)
In-Reply-To: <20180131120300.16193-1-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gSW4gdGhl
IG5leHQgcGF0Y2gsIHdlIG1heSBvbmx5IGNvbmRpdGlvbmFsbHkgYWxsb2NhdGUgdGhlIHByZWVt
cHQtY2xpZW50Cj4gaWYgdGhlcmUgaXMgYSBnbG9iYWwgcHJlZW1wdCBjb250ZXh0IGFuZCBzbyB3
ZSBuZWVkIHRvIGJlIHByZXBhcmVkIGluCj4gY2FzZSB0aGUgcHJlZW1wdC1jbGllbnQgaXRzZWxm
IGlzIE5VTEwuCj4KPiB2MjogR3JlcCBmb3IgbW9yZSBwcmVlbXB0X2NsaWVudC4KPgo+IFNpZ25l
ZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBN
aWNoYWwgV2luaWFyc2tpIDxtaWNoYWwud2luaWFyc2tpQGludGVsLmNvbT4KPiBDYzogQXJrYWRp
dXN6IEhpbGVyIDxhcmthZGl1c3ouaGlsZXJAaW50ZWwuY29tPgo+IENjOiBEYW5pZWxlIENlcmFv
bG8gU3B1cmlvIDxkYW5pZWxlLmNlcmFvbG9zcHVyaW9AaW50ZWwuY29tPgo+IENjOiBNaWNoZWwg
VGhpZXJyeSA8bWljaGVsLnRoaWVycnlAaW50ZWwuY29tPgo+IENjOiBNaWNoYWwgV2FqZGVjemtv
IDxtaWNoYWwud2FqZGVjemtvQGludGVsLmNvbT4KClJldmlld2VkLWJ5OiBNaWthIEt1b3BwYWxh
IDxtaWthLmt1b3BwYWxhQGxpbnV4LmludGVsLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2k5MTVfZGVidWdmcy5jICAgICAgICAgfCAgOCArKysrKy0tLQo+ICBkcml2ZXJzL2dw
dS9kcm0vaTkxNS9pbnRlbF9ndWNfc3VibWlzc2lvbi5jIHwgMjcgKysrKysrKysrKysrKysrKyst
LS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9pbnRlbF9ndWMuYyAg
fCAyMCArKysrKysrKysrKy0tLS0tLS0tLQo+ICAzIGZpbGVzIGNoYW5nZWQsIDMzIGluc2VydGlv
bnMoKyksIDIyIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2k5MTVfZGVidWdmcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMK
PiBpbmRleCAzODQ5ZGVkMzU0ZTMuLjllNDRhZGVmMzBmMCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz
L2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L2k5MTVfZGVidWdmcy5jCj4gQEAgLTIzMzgsNyArMjMzOCw2IEBAIHN0YXRpYyBpbnQgaTkxNV9n
dWNfaW5mbyhzdHJ1Y3Qgc2VxX2ZpbGUgKm0sIHZvaWQgKmRhdGEpCj4gIAkJcmV0dXJuIC1FTk9E
RVY7Cj4gIAo+ICAJR0VNX0JVR19PTighZ3VjLT5leGVjYnVmX2NsaWVudCk7Cj4gLQlHRU1fQlVH
X09OKCFndWMtPnByZWVtcHRfY2xpZW50KTsKPiAgCj4gIAlzZXFfcHJpbnRmKG0sICJEb29yYmVs
bCBtYXA6XG4iKTsKPiAgCXNlcV9wcmludGYobSwgIlx0JSpwYlxuIiwgR1VDX05VTV9ET09SQkVM
TFMsIGd1Yy0+ZG9vcmJlbGxfYml0bWFwKTsKPiBAQCAtMjM0Niw4ICsyMzQ1LDExIEBAIHN0YXRp
YyBpbnQgaTkxNV9ndWNfaW5mbyhzdHJ1Y3Qgc2VxX2ZpbGUgKm0sIHZvaWQgKmRhdGEpCj4gIAo+
ICAJc2VxX3ByaW50ZihtLCAiXG5HdUMgZXhlY2J1ZiBjbGllbnQgQCAlcDpcbiIsIGd1Yy0+ZXhl
Y2J1Zl9jbGllbnQpOwo+ICAJaTkxNV9ndWNfY2xpZW50X2luZm8obSwgZGV2X3ByaXYsIGd1Yy0+
ZXhlY2J1Zl9jbGllbnQpOwo+IC0Jc2VxX3ByaW50ZihtLCAiXG5HdUMgcHJlZW1wdCBjbGllbnQg
QCAlcDpcbiIsIGd1Yy0+cHJlZW1wdF9jbGllbnQpOwo+IC0JaTkxNV9ndWNfY2xpZW50X2luZm8o
bSwgZGV2X3ByaXYsIGd1Yy0+cHJlZW1wdF9jbGllbnQpOwo+ICsJaWYgKGd1Yy0+cHJlZW1wdF9j
bGllbnQpIHsKPiArCQlzZXFfcHJpbnRmKG0sICJcbkd1QyBwcmVlbXB0IGNsaWVudCBAICVwOlxu
IiwKPiArCQkJICAgZ3VjLT5wcmVlbXB0X2NsaWVudCk7Cj4gKwkJaTkxNV9ndWNfY2xpZW50X2lu
Zm8obSwgZGV2X3ByaXYsIGd1Yy0+cHJlZW1wdF9jbGllbnQpOwo+ICsJfQo+ICAKPiAgCWk5MTVf
Z3VjX2xvZ19pbmZvKG0sIGRldl9wcml2KTsKPiAgCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1
L2RybS9pOTE1L2ludGVsX2d1Y19zdWJtaXNzaW9uLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
bnRlbF9ndWNfc3VibWlzc2lvbi5jCj4gaW5kZXggMWYzYTg3ODZiYmRjLi40ZWE2NWRmMDVlMDIg
MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX3N1Ym1pc3Npb24u
Ywo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19zdWJtaXNzaW9uLmMKPiBA
QCAtODMyLDEwICs4MzIsMTIgQEAgc3RhdGljIGludCBndWNfY2xpZW50c19kb29yYmVsbF9pbml0
KHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPiAgCWlmIChyZXQpCj4gIAkJcmV0dXJuIHJldDsKPiAg
Cj4gLQlyZXQgPSBjcmVhdGVfZG9vcmJlbGwoZ3VjLT5wcmVlbXB0X2NsaWVudCk7Cj4gLQlpZiAo
cmV0KSB7Cj4gLQkJZGVzdHJveV9kb29yYmVsbChndWMtPmV4ZWNidWZfY2xpZW50KTsKPiAtCQly
ZXR1cm4gcmV0Owo+ICsJaWYgKGd1Yy0+cHJlZW1wdF9jbGllbnQpIHsKPiArCQlyZXQgPSBjcmVh
dGVfZG9vcmJlbGwoZ3VjLT5wcmVlbXB0X2NsaWVudCk7Cj4gKwkJaWYgKHJldCkgewo+ICsJCQlk
ZXN0cm95X2Rvb3JiZWxsKGd1Yy0+ZXhlY2J1Zl9jbGllbnQpOwo+ICsJCQlyZXR1cm4gcmV0Owo+
ICsJCX0KPiAgCX0KPiAgCj4gIAlyZXR1cm4gMDsKPiBAQCAtODQ4LDggKzg1MCwxMSBAQCBzdGF0
aWMgdm9pZCBndWNfY2xpZW50c19kb29yYmVsbF9maW5pKHN0cnVjdCBpbnRlbF9ndWMgKmd1YykK
PiAgCSAqIEluc3RlYWQgb2YgdHJ5aW5nIChpbiB2YWluKSB0byBjb21tdW5pY2F0ZSB3aXRoIGl0
LCBsZXQncyBqdXN0Cj4gIAkgKiBjbGVhbnVwIHRoZSBkb29yYmVsbCBIVyBhbmQgb3VyIGludGVy
bmFsIHN0YXRlLgo+ICAJICovCj4gLQlfX2Rlc3Ryb3lfZG9vcmJlbGwoZ3VjLT5wcmVlbXB0X2Ns
aWVudCk7Cj4gLQlfX3VwZGF0ZV9kb29yYmVsbF9kZXNjKGd1Yy0+cHJlZW1wdF9jbGllbnQsIEdV
Q19ET09SQkVMTF9JTlZBTElEKTsKPiArCWlmIChndWMtPnByZWVtcHRfY2xpZW50KSB7Cj4gKwkJ
X19kZXN0cm95X2Rvb3JiZWxsKGd1Yy0+cHJlZW1wdF9jbGllbnQpOwo+ICsJCV9fdXBkYXRlX2Rv
b3JiZWxsX2Rlc2MoZ3VjLT5wcmVlbXB0X2NsaWVudCwKPiArCQkJCSAgICAgICBHVUNfRE9PUkJF
TExfSU5WQUxJRCk7Cj4gKwl9Cj4gIAlfX2Rlc3Ryb3lfZG9vcmJlbGwoZ3VjLT5leGVjYnVmX2Ns
aWVudCk7Cj4gIAlfX3VwZGF0ZV9kb29yYmVsbF9kZXNjKGd1Yy0+ZXhlY2J1Zl9jbGllbnQsIEdV
Q19ET09SQkVMTF9JTlZBTElEKTsKPiAgfQo+IEBAIC05OTgsMTAgKzEwMDMsMTEgQEAgc3RhdGlj
IHZvaWQgZ3VjX2NsaWVudHNfZGVzdHJveShzdHJ1Y3QgaW50ZWxfZ3VjICpndWMpCj4gIHsKPiAg
CXN0cnVjdCBpbnRlbF9ndWNfY2xpZW50ICpjbGllbnQ7Cj4gIAo+IC0JY2xpZW50ID0gZmV0Y2hf
YW5kX3plcm8oJmd1Yy0+ZXhlY2J1Zl9jbGllbnQpOwo+IC0JZ3VjX2NsaWVudF9mcmVlKGNsaWVu
dCk7Cj4gLQo+ICAJY2xpZW50ID0gZmV0Y2hfYW5kX3plcm8oJmd1Yy0+cHJlZW1wdF9jbGllbnQp
Owo+ICsJaWYgKGNsaWVudCkKPiArCQlndWNfY2xpZW50X2ZyZWUoY2xpZW50KTsKPiArCj4gKwlj
bGllbnQgPSBmZXRjaF9hbmRfemVybygmZ3VjLT5leGVjYnVmX2NsaWVudCk7Cj4gIAlndWNfY2xp
ZW50X2ZyZWUoY2xpZW50KTsKPiAgfQo+ICAKPiBAQCAtMTE2MCw3ICsxMTY2LDggQEAgaW50IGlu
dGVsX2d1Y19zdWJtaXNzaW9uX2VuYWJsZShzdHJ1Y3QgaW50ZWxfZ3VjICpndWMpCj4gIAlHRU1f
QlVHX09OKCFndWMtPmV4ZWNidWZfY2xpZW50KTsKPiAgCj4gIAlndWNfcmVzZXRfd3EoZ3VjLT5l
eGVjYnVmX2NsaWVudCk7Cj4gLQlndWNfcmVzZXRfd3EoZ3VjLT5wcmVlbXB0X2NsaWVudCk7Cj4g
KwlpZiAoZ3VjLT5wcmVlbXB0X2NsaWVudCkKPiArCQlndWNfcmVzZXRfd3EoZ3VjLT5wcmVlbXB0
X2NsaWVudCk7Cj4gIAo+ICAJZXJyID0gaW50ZWxfZ3VjX3NhbXBsZV9mb3JjZXdha2UoZ3VjKTsK
PiAgCWlmIChlcnIpCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0
cy9pbnRlbF9ndWMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9pbnRlbF9ndWMu
Ywo+IGluZGV4IDNmOTAxNjQ2NmRlYS4uZmI3NGUyY2Y4YTBhIDEwMDY0NAo+IC0tLSBhL2RyaXZl
cnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9pbnRlbF9ndWMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1
L2RybS9pOTE1L3NlbGZ0ZXN0cy9pbnRlbF9ndWMuYwo+IEBAIC04Nyw3ICs4Nyw3IEBAIHN0YXRp
YyBpbnQgdmFsaWRhdGVfY2xpZW50KHN0cnVjdCBpbnRlbF9ndWNfY2xpZW50ICpjbGllbnQsCj4g
IAo+ICBzdGF0aWMgYm9vbCBjbGllbnRfZG9vcmJlbGxfaW5fc3luYyhzdHJ1Y3QgaW50ZWxfZ3Vj
X2NsaWVudCAqY2xpZW50KQo+ICB7Cj4gLQlyZXR1cm4gZG9vcmJlbGxfb2soY2xpZW50LT5ndWMs
IGNsaWVudC0+ZG9vcmJlbGxfaWQpOwo+ICsJcmV0dXJuICFjbGllbnQgfHwgZG9vcmJlbGxfb2so
Y2xpZW50LT5ndWMsIGNsaWVudC0+ZG9vcmJlbGxfaWQpOwo+ICB9Cj4gIAo+ICAvKgo+IEBAIC0x
MzcsNyArMTM3LDYgQEAgc3RhdGljIGludCBpZ3RfZ3VjX2NsaWVudHModm9pZCAqYXJncykKPiAg
CQlnb3RvIHVubG9jazsKPiAgCX0KPiAgCUdFTV9CVUdfT04oIWd1Yy0+ZXhlY2J1Zl9jbGllbnQp
Owo+IC0JR0VNX0JVR19PTighZ3VjLT5wcmVlbXB0X2NsaWVudCk7Cj4gIAo+ICAJZXJyID0gdmFs
aWRhdGVfY2xpZW50KGd1Yy0+ZXhlY2J1Zl9jbGllbnQsCj4gIAkJCSAgICAgIEdVQ19DTElFTlRf
UFJJT1JJVFlfS01EX05PUk1BTCwgZmFsc2UpOwo+IEBAIC0xNDYsMTYgKzE0NSwxOCBAQCBzdGF0
aWMgaW50IGlndF9ndWNfY2xpZW50cyh2b2lkICphcmdzKQo+ICAJCWdvdG8gb3V0Owo+ICAJfQo+
ICAKPiAtCWVyciA9IHZhbGlkYXRlX2NsaWVudChndWMtPnByZWVtcHRfY2xpZW50LAo+IC0JCQkg
ICAgICBHVUNfQ0xJRU5UX1BSSU9SSVRZX0tNRF9ISUdILCB0cnVlKTsKPiAtCWlmIChlcnIpIHsK
PiAtCQlwcl9lcnIoInByZWVtcHQgY2xpZW50IHZhbGlkYXRpb24gZmFpbGVkXG4iKTsKPiAtCQln
b3RvIG91dDsKPiArCWlmIChndWMtPnByZWVtcHRfY2xpZW50KSB7Cj4gKwkJZXJyID0gdmFsaWRh
dGVfY2xpZW50KGd1Yy0+cHJlZW1wdF9jbGllbnQsCj4gKwkJCQkgICAgICBHVUNfQ0xJRU5UX1BS
SU9SSVRZX0tNRF9ISUdILCB0cnVlKTsKPiArCQlpZiAoZXJyKSB7Cj4gKwkJCXByX2VycigicHJl
ZW1wdCBjbGllbnQgdmFsaWRhdGlvbiBmYWlsZWRcbiIpOwo+ICsJCQlnb3RvIG91dDsKPiArCQl9
Cj4gIAl9Cj4gIAo+ICAJLyogZWFjaCBjbGllbnQgc2hvdWxkIG5vdyBoYXZlIHJlc2VydmVkIGEg
ZG9vcmJlbGwgKi8KPiAgCWlmICghaGFzX2Rvb3JiZWxsKGd1Yy0+ZXhlY2J1Zl9jbGllbnQpIHx8
Cj4gLQkgICAgIWhhc19kb29yYmVsbChndWMtPnByZWVtcHRfY2xpZW50KSkgewo+ICsJICAgIChn
dWMtPnByZWVtcHRfY2xpZW50ICYmICFoYXNfZG9vcmJlbGwoZ3VjLT5wcmVlbXB0X2NsaWVudCkp
KSB7Cj4gIAkJcHJfZXJyKCJndWNfY2xpZW50c19jcmVhdGUgZGlkbid0IHJlc2VydmUgZG9vcmJl
bGxzXG4iKTsKPiAgCQllcnIgPSAtRUlOVkFMOwo+ICAJCWdvdG8gb3V0Owo+IEBAIC0yMjQsNyAr
MjI1LDggQEAgc3RhdGljIGludCBpZ3RfZ3VjX2NsaWVudHModm9pZCAqYXJncykKPiAgCSAqIGNs
aWVudHMgZHVyaW5nIHVubG9hZC4KPiAgCSAqLwo+ICAJZGVzdHJveV9kb29yYmVsbChndWMtPmV4
ZWNidWZfY2xpZW50KTsKPiAtCWRlc3Ryb3lfZG9vcmJlbGwoZ3VjLT5wcmVlbXB0X2NsaWVudCk7
Cj4gKwlpZiAoZ3VjLT5wcmVlbXB0X2NsaWVudCkKPiArCQlkZXN0cm95X2Rvb3JiZWxsKGd1Yy0+
cHJlZW1wdF9jbGllbnQpOwo+ICAJZ3VjX2NsaWVudHNfZGVzdHJveShndWMpOwo+ICAJZ3VjX2Ns
aWVudHNfY3JlYXRlKGd1Yyk7Cj4gIAlndWNfY2xpZW50c19kb29yYmVsbF9pbml0KGd1Yyk7Cj4g
LS0gCj4gMi4xNS4xCj4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRl
c2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m
by9pbnRlbC1nZngKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn
Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4
Cg==