Re: [Qemu-devel] [PATCH v9 04/12] migration: Start of multiple fd work

[Juan Quintela <quintela@redhat.com>]

"Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote:
> * Juan Quintela (quintela@redhat.com) wrote:

>> +static void multifd_new_channel_async(QIOTask *task, gpointer opaque)
>> +{
>> +    MultiFDSendParams *p = opaque;
>> +    QIOChannel *sioc = QIO_CHANNEL(qio_task_get_source(task));
>> +    Error *local_err;
>
> Does that need an = NULL ?


Good catch.  Fixed.

>> +    if (errp) {
>> +        MigrationState *s = migrate_get_current();
>> +        migrate_set_error(s, errp);
>> +        migrate_set_state(&s->state, MIGRATION_STATUS_ACTIVE,
>> +                          MIGRATION_STATUS_FAILED);
>
> Are we necessarily in ACTIVE at this point?   I suspect there
> are some SETUP and I wonder if there are others.

We only care about SETUP & ACTIVE.  We could still be on SETUP here as
far as I can see.  Fixed for both send and recv size.

Later, Juan.