From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next-queue PATCH v7 4/6] net/sched: Introduce Credit Based Shaper (CBS) qdisc
Date: Fri, 13 Oct 2017 10:12:18 -0700 [thread overview]
Message-ID: <87efq7m0p9.fsf@intel.com> (raw)
In-Reply-To: <1507862553.31614.53.camel@edumazet-glaptop3.roam.corp.google.com>
Hi,
Eric Dumazet <eric.dumazet@gmail.com> writes:
[...]
>
> Your mixing of s64 and u64 is disturbing.
>
> do_div() handles u64, not s64.
>
> div64_s64() might be needed in place of do_div()
I wasn't very comfortable about the signal juggling either. Didn't know
about div64_s64(), looks much better. Will fix, thanks.
Cheers,
--
Vinicius
WARNING: multiple messages have this Message-ID (diff)
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
andre.guedes@intel.com, ivan.briano@intel.com,
jesus.sanchez-palencia@intel.com, boon.leong.ong@intel.com,
richardcochran@gmail.com, henrik@austad.us,
levipearson@gmail.com, rodney.cummings@ni.com
Subject: Re: [next-queue PATCH v7 4/6] net/sched: Introduce Credit Based Shaper (CBS) qdisc
Date: Fri, 13 Oct 2017 10:12:18 -0700 [thread overview]
Message-ID: <87efq7m0p9.fsf@intel.com> (raw)
In-Reply-To: <1507862553.31614.53.camel@edumazet-glaptop3.roam.corp.google.com>
Hi,
Eric Dumazet <eric.dumazet@gmail.com> writes:
[...]
>
> Your mixing of s64 and u64 is disturbing.
>
> do_div() handles u64, not s64.
>
> div64_s64() might be needed in place of do_div()
I wasn't very comfortable about the signal juggling either. Didn't know
about div64_s64(), looks much better. Will fix, thanks.
Cheers,
next prev parent reply other threads:[~2017-10-13 17:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 0:39 [Intel-wired-lan] [next-queue PATCH v7 0/6] TSN: Add qdisc based config interface for CBS Vinicius Costa Gomes
2017-10-13 0:39 ` Vinicius Costa Gomes
2017-10-13 0:40 ` [Intel-wired-lan] [next-queue PATCH v7 1/6] net/sched: Check for null dev_queue on create flow Vinicius Costa Gomes
2017-10-13 0:40 ` Vinicius Costa Gomes
2017-10-13 0:40 ` [Intel-wired-lan] [next-queue PATCH v7 2/6] net/sched: Change behavior of mq select_queue() Vinicius Costa Gomes
2017-10-13 0:40 ` Vinicius Costa Gomes
2017-10-13 0:40 ` [Intel-wired-lan] [next-queue PATCH v7 3/6] net/sched: Add select_queue() class_ops for mqprio Vinicius Costa Gomes
2017-10-13 0:40 ` Vinicius Costa Gomes
2017-10-13 0:40 ` [Intel-wired-lan] [next-queue PATCH v7 4/6] net/sched: Introduce Credit Based Shaper (CBS) qdisc Vinicius Costa Gomes
2017-10-13 0:40 ` Vinicius Costa Gomes
2017-10-13 2:42 ` [Intel-wired-lan] " Eric Dumazet
2017-10-13 2:42 ` Eric Dumazet
2017-10-13 17:12 ` Vinicius Costa Gomes [this message]
2017-10-13 17:12 ` Vinicius Costa Gomes
2017-10-13 19:59 ` [Intel-wired-lan] " Ivan Khoronzhuk
2017-10-13 19:59 ` Ivan Khoronzhuk
2017-10-13 22:54 ` [Intel-wired-lan] " Vinicius Costa Gomes
2017-10-13 22:54 ` Vinicius Costa Gomes
2017-10-16 9:14 ` [Intel-wired-lan] " David Laight
2017-10-16 9:14 ` David Laight
2017-10-16 22:13 ` [Intel-wired-lan] " Vinicius Costa Gomes
2017-10-16 22:13 ` Vinicius Costa Gomes
2017-10-13 0:40 ` [Intel-wired-lan] [next-queue PATCH v7 5/6] net/sched: Add support for HW offloading for CBS Vinicius Costa Gomes
2017-10-13 0:40 ` Vinicius Costa Gomes
2017-10-13 0:40 ` [Intel-wired-lan] [next-queue PATCH v7 6/6] igb: Add support for CBS offload Vinicius Costa Gomes
2017-10-13 0:40 ` Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efq7m0p9.fsf@intel.com \
--to=vinicius.gomes@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.