From: Kalle Valo <kvalo@codeaurora.org>
To: Xinming Hu <huxm@marvell.com>
Cc: Arend van Spriel <arend.vanspriel@broadcom.com>,
Xinming Hu <huxinming820@gmail.com>,
Linux Wireless <linux-wireless@vger.kernel.org>,
Brian Norris <briannorris@google.com>,
Dmitry Torokhov <dtor@google.com>,
"rajatja\@google.com" <rajatja@google.com>,
Zhiyuan Yang <yangzy@marvell.com>, Tim Song <songtao@marvell.com>,
Cathy Luo <cluo@marvell.com>, Ganapathi Bhat <gbhat@marvell.com>
Subject: Re: [PATCH] mwifiex: add device specific ioctl handler
Date: Wed, 20 Sep 2017 14:43:07 +0300 [thread overview]
Message-ID: <87efr1a94k.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <429692343ed64d759eef2aa014a87fbb@SC-EXCH02.marvell.com> (Xinming Hu's message of "Wed, 20 Sep 2017 10:04:22 +0000")
Xinming Hu <huxm@marvell.com> writes:
>> You could look at
>> nl80211 vendor commands, but that is also under scrutiny if common wifi
>> functionality is provided by it. I am pretty sure Kalle has his ideas about this :-)
>>
>
> Yes, the new utility should use nl80211 interface.
> But we have lots of legacy utility based on ioctl, it will be helpful
> to reduce massive work on refactoring.
That's not an excuse to implement bad interfaces. It's not really that
hard to convert ioctl based tools to use nl80211 testmode command, I
even have myself done that.
--
Kalle Valo
next prev parent reply other threads:[~2017-09-20 11:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 10:04 Re: [PATCH] mwifiex: add device specific ioctl handler Xinming Hu
2017-09-20 11:43 ` Kalle Valo [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-09-20 6:44 Xinming Hu
2017-09-20 8:06 ` Souptick Joarder
2017-09-20 8:39 ` Arend van Spriel
2017-09-20 11:38 ` Kalle Valo
2017-09-23 2:29 ` kbuild test robot
2017-09-23 3:01 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efr1a94k.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=briannorris@google.com \
--cc=cluo@marvell.com \
--cc=dtor@google.com \
--cc=gbhat@marvell.com \
--cc=huxinming820@gmail.com \
--cc=huxm@marvell.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rajatja@google.com \
--cc=songtao@marvell.com \
--cc=yangzy@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.