Re: [PATCH v3 1/2] drm/bridge: Add Cadence DSI driver

From: Eric Anholt <eric@anholt.net>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Cyprian Wronka <cwronka@cadence.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Simon Hatliff <hatliff@cadence.com>,
	dri-devel@lists.freedesktop.org,
	Richard Sproul <sproul@cadence.com>,
	Rob Herring <robh+dt@kernel.org>,
	Alan Douglas <adouglas@cadence.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Jyri Sarha <jsarha@ti.com>, Kumar Gala <galak@codeaurora.org>,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Neil Webb <neilw@cadence.com>
Subject: Re: [PATCH v3 1/2] drm/bridge: Add Cadence DSI driver
Date: Fri, 01 Sep 2017 11:32:32 -0700	[thread overview]
Message-ID: <87efrql16n.fsf@anholt.net> (raw)
In-Reply-To: <20170901082016.3b5e445e@bbrezillon>

[-- Attachment #1.1: Type: text/plain, Size: 1342 bytes --]

Boris Brezillon <boris.brezillon@free-electrons.com> writes:

> Hi Eric,
>
> On Thu, 31 Aug 2017 10:03:23 -0700
> Eric Anholt <eric@anholt.net> wrote:
>
>> Boris Brezillon <boris.brezillon@free-electrons.com> writes:
>> > +			      VID_DATATYPE(MIPI_DSI_PACKED_PIXEL_STREAM_16);
>> > +			break;
>> > +
>> > +		default:
>> > +			dev_err(dsi->base.dev, "Unsupported DSI format\n");
>> > +			return;
>> > +		}  
>> 
>> > +static irqreturn_t cdns_dsi_interrupt(int irq, void *data)
>> > +{
>> > +	struct cdns_dsi *dsi = data;
>> > +	irqreturn_t ret = IRQ_NONE;
>> > +	u32 flag, ctl;
>> > +
>> > +	flag = readl(dsi->regs + DIRECT_CMD_STS_FLAG);
>> > +	if (flag) {
>> > +		ctl = readl(dsi->regs + DIRECT_CMD_STS_CTL);
>> > +		ctl &= ~flag;
>> > +		writel(ctl, dsi->regs + DIRECT_CMD_STS_CTL);  
>> 
>> Are you meant to just write flag to DIRECT_CMD_STS_CLEAR, maybe?
>
> Actually, I want to keep the status flag untouched, I'm just masking the
> interrupt to not be interrupted until the waiter has cleared the
> status flags.
>
> I'm doing that because the user may want to wait for several different
> events (error, done, timeout, ...), and I'm not doing the check in the
> interrupt handler. Instead, I'm just waking up the waiter and let him
> check the status flag himself.

Oh, OK.  That sounds good.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel