All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Michael Neuling <mikey@neuling.org>, linuxppc-dev@lists.ozlabs.org
Cc: benh@kernel.crashing.org, paulus@samba.org, sam.bobroff@au1.ibm.com
Subject: Re: [PATCH] powernv: Properly mask POWER9 DD1 PVR for different chip types
Date: Wed, 07 Jun 2017 17:24:40 +1000	[thread overview]
Message-ID: <87efuwp8ef.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20170607041145.3581-1-mikey@neuling.org>

Michael Neuling <mikey@neuling.org> writes:

> Bits 48:51 in the PVR for POWER9 represent different chip types (scale
> up vs out and 12 vs 24 core). Current chips have 0 here, but could be
> non-zero in the future.
>
> This changes the POWER9 DD1 mask to correctly ignore these bits 48:51.
>
> Signed-off-by: Michael Neuling <mikey@neuling.org>
> ---
>  arch/powerpc/kernel/cputable.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Presumably we should backport this?

cheers

> diff --git a/arch/powerpc/kernel/cputable.c b/arch/powerpc/kernel/cputable.c
> index 9b3e88b1a9..89dcd94237 100644
> --- a/arch/powerpc/kernel/cputable.c
> +++ b/arch/powerpc/kernel/cputable.c
> @@ -526,8 +526,8 @@ static struct cpu_spec __initdata cpu_specs[] = {
>  		.machine_check_early	= __machine_check_early_realmode_p8,
>  		.platform		= "power8",
>  	},
> -	{	/* Power9 DD1*/
> -		.pvr_mask		= 0xffffff00,
> +	{	/* Power9 DD1. Bits 48:51 represent chip type so mask these */
> +		.pvr_mask		= 0xffff0f00,
>  		.pvr_value		= 0x004e0100,
>  		.cpu_name		= "POWER9 (raw)",
>  		.cpu_features		= CPU_FTRS_POWER9_DD1,
> -- 
> 2.11.0

  reply	other threads:[~2017-06-07  7:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-07  4:11 [PATCH] powernv: Properly mask POWER9 DD1 PVR for different chip types Michael Neuling
2017-06-07  7:24 ` Michael Ellerman [this message]
2017-06-08  0:44   ` Michael Neuling
2017-06-08  3:44     ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87efuwp8ef.fsf@concordia.ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=benh@kernel.crashing.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mikey@neuling.org \
    --cc=paulus@samba.org \
    --cc=sam.bobroff@au1.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.