From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3wjKnQ1FN3zDq5b for ; Wed, 7 Jun 2017 17:24:42 +1000 (AEST) From: Michael Ellerman To: Michael Neuling , linuxppc-dev@lists.ozlabs.org Cc: benh@kernel.crashing.org, paulus@samba.org, sam.bobroff@au1.ibm.com Subject: Re: [PATCH] powernv: Properly mask POWER9 DD1 PVR for different chip types In-Reply-To: <20170607041145.3581-1-mikey@neuling.org> References: <20170607041145.3581-1-mikey@neuling.org> Date: Wed, 07 Jun 2017 17:24:40 +1000 Message-ID: <87efuwp8ef.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Michael Neuling writes: > Bits 48:51 in the PVR for POWER9 represent different chip types (scale > up vs out and 12 vs 24 core). Current chips have 0 here, but could be > non-zero in the future. > > This changes the POWER9 DD1 mask to correctly ignore these bits 48:51. > > Signed-off-by: Michael Neuling > --- > arch/powerpc/kernel/cputable.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Presumably we should backport this? cheers > diff --git a/arch/powerpc/kernel/cputable.c b/arch/powerpc/kernel/cputable.c > index 9b3e88b1a9..89dcd94237 100644 > --- a/arch/powerpc/kernel/cputable.c > +++ b/arch/powerpc/kernel/cputable.c > @@ -526,8 +526,8 @@ static struct cpu_spec __initdata cpu_specs[] = { > .machine_check_early = __machine_check_early_realmode_p8, > .platform = "power8", > }, > - { /* Power9 DD1*/ > - .pvr_mask = 0xffffff00, > + { /* Power9 DD1. Bits 48:51 represent chip type so mask these */ > + .pvr_mask = 0xffff0f00, > .pvr_value = 0x004e0100, > .cpu_name = "POWER9 (raw)", > .cpu_features = CPU_FTRS_POWER9_DD1, > -- > 2.11.0