All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: make-wifi-fast@lists.bufferbloat.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3] mac80211: Dynamically set CoDel parameters per station
Date: Fri, 19 May 2017 11:27:38 +0200	[thread overview]
Message-ID: <87efvldwmt.fsf@alrua-kau> (raw)
In-Reply-To: <1495029987.2442.19.camel@sipsolutions.net> (Johannes Berg's message of "Wed, 17 May 2017 16:06:27 +0200")

Johannes Berg <johannes@sipsolutions.net> writes:

> On Thu, 2017-04-06 at 11:38 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wrote:
>> CoDel can be too aggressive if a station sends at a very low rate,
>> leading reduced throughput. This gets worse the more stations are
>> present, as each station gets more bursty the longer the round-robin
>> scheduling between stations takes.
>>=20
> [...]
>
> I've applied this now (with some minor fixups) - the whole discussion
> didn't really conclude in anything, and we can just try it.

Okidoki. FWIW, the reason I never got any further was that my
experiments with other approaches proved somewhat inconclusive. Partly
because a reorganisation of my testbed has caused the physical
conditions to change which has caused the original problem to be less
severe.

So yeah, some wider testing would be good, and I agree that it is low
risk. I'll revisit this myself at some point after I get my testbed
rebased on a new kernel and figure out why the physical conditions
changed... :)

-Toke

      reply	other threads:[~2017-05-19  9:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-10 19:33 [PATCH] mac80211: Dynamically set CoDel parameters per station Toke Høiland-Jørgensen
     [not found] ` <CAGhGL2D8Hfed0VTsinnCbkK31dGTc=bYjzpPfrcLRnp+x6O3sA@mail.gmail.com>
2016-09-10 20:09   ` [Make-wifi-fast] " Toke Høiland-Jørgensen
2016-09-11  3:16   ` Loganaden Velvindron
2016-09-11  0:09 ` kbuild test robot
2017-04-05 16:18 ` [PATCH v2] " Toke Høiland-Jørgensen
2017-04-06  7:56   ` kbuild test robot
2017-04-06  8:45   ` kbuild test robot
2017-04-06  9:38   ` [PATCH v3] " Toke Høiland-Jørgensen
2017-04-06 10:51     ` [Make-wifi-fast] " Eric Dumazet
2017-04-06 15:58       ` Toke Høiland-Jørgensen
2017-04-13 18:26         ` Dave Taht
2017-05-17 14:06     ` Johannes Berg
2017-05-19  9:27       ` Toke Høiland-Jørgensen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87efvldwmt.fsf@alrua-kau \
    --to=toke@toke.dk \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=make-wifi-fast@lists.bufferbloat.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.