From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1] mmc: pci: only compile on platforms that need it
Date: Wed, 15 Feb 2017 09:13:53 +0200 [thread overview]
Message-ID: <87efz0orim.fsf@linux.intel.com> (raw)
In-Reply-To: <70426883-f964-d201-a1bb-ded903186b1a@samsung.com>
Hi,
Jaehoon Chung <jh80.chung@samsung.com> writes:
> On 02/13/2017 11:56 PM, Andy Shevchenko wrote:
>> From: Felipe Balbi <felipe.balbi@linux.intel.com>
>>
>> We should only compile pci_mmc.c on platforms that actually need
>> this. Some platforms are using generic sdhci through driver model.
>>
>> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> ---
>> drivers/mmc/Makefile | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/Makefile b/drivers/mmc/Makefile
>> index 49413dfaf1..26db92e582 100644
>> --- a/drivers/mmc/Makefile
>> +++ b/drivers/mmc/Makefile
>> @@ -36,7 +36,9 @@ obj-$(CONFIG_MVEBU_MMC) += mvebu_mmc.o
>> obj-$(CONFIG_MMC_OMAP_HS) += omap_hsmmc.o
>> obj-$(CONFIG_MMC_MXC) += mxcmmc.o
>> obj-$(CONFIG_MMC_MXS) += mxsmmc.o
>> -obj-$(CONFIG_X86) += pci_mmc.o
>> +obj-$(CONFIG_INTEL_BAYTRAIL) += pci_mmc.o
>> +obj-$(CONFIG_INTEL_QUARK) += pci_mmc.o
>> +obj-$(CONFIG_INTEL_QUEENSBAY) += pci_mmc.o
>
> How about adding new CONFIG_MMC_X86_PCI for this.
>
> obj-$(CONFIG_MMC_X86_PCI) += pci_mmc.o
>
> Of course, you need to modify Kconfig file.
doable, no problems for me.
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170215/2dff4c44/attachment.sig>
prev parent reply other threads:[~2017-02-15 7:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170213145642epcas5p203104bcafa169c40915ef98f691d0863@epcas5p2.samsung.com>
2017-02-13 14:56 ` [U-Boot] [PATCH v1] mmc: pci: only compile on platforms that need it Andy Shevchenko
2017-02-15 4:26 ` Jaehoon Chung
2017-02-15 7:13 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efz0orim.fsf@linux.intel.com \
--to=felipe.balbi@linux.intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.