From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1cZZxo-0004Ua-V1 for mharc-qemu-trivial@gnu.org; Fri, 03 Feb 2017 04:15:29 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42236) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZZxm-0004Sd-Pc for qemu-trivial@nongnu.org; Fri, 03 Feb 2017 04:15:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZZxl-00032x-RX for qemu-trivial@nongnu.org; Fri, 03 Feb 2017 04:15:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40604) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cZZxg-0002zi-Lg; Fri, 03 Feb 2017 04:15:20 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CD3F2C04BD33; Fri, 3 Feb 2017 09:15:20 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-50.ams2.redhat.com [10.36.116.50]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v139FJAG006067 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 3 Feb 2017 04:15:20 -0500 Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id F0D411138646; Fri, 3 Feb 2017 10:15:17 +0100 (CET) From: Markus Armbruster To: Thomas Huth Cc: Alistair Francis , qemu-devel@nongnu.org, qemu-trivial@nongnu.org, Peter Maydell References: <1485778972-20924-1-git-send-email-thuth@redhat.com> <87lgtnd4k0.fsf@dusky.pond.sub.org> Date: Fri, 03 Feb 2017 10:15:17 +0100 In-Reply-To: <87lgtnd4k0.fsf@dusky.pond.sub.org> (Markus Armbruster's message of "Fri, 03 Feb 2017 10:09:03 +0100") Message-ID: <87efzfbpp6.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 03 Feb 2017 09:15:20 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] hw/core/or-irq: Mark the device with cannot_instantiate_with_device_add_yet X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Feb 2017 09:15:27 -0000 Markus Armbruster writes: > Thomas Huth writes: > >> The "or-irq" device needs to be wired up in source code, there is no >> way the user can add this device with the "-device" parameter or the >> "device_add" monitor command yet. Well, the user can (I tried), but it won't do squat then. >> Signed-off-by: Thomas Huth >> --- >> v2: Changed patch description and comment >> >> hw/core/or-irq.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/hw/core/or-irq.c b/hw/core/or-irq.c >> index 1ac090d..808c8d1 100644 >> --- a/hw/core/or-irq.c >> +++ b/hw/core/or-irq.c >> @@ -89,6 +89,9 @@ static void or_irq_class_init(ObjectClass *klass, void *data) >> dc->props = or_irq_properties; >> dc->realize = or_irq_realize; >> dc->vmsd = &vmstate_or_irq; >> + >> + /* Reason: Needs to be wired up in source code, e.g. see stm32f205_soc.c */ > > This line is a bit long, and it could be shortened easily: drop "in > source code", or replace it by "to work". This is how similar comments > elsewhere are phrased. > >> + dc->cannot_instantiate_with_device_add_yet = true; >> } >> >> static const TypeInfo or_irq_type_info = { > > Preferably with the comment touched up: Commit message, too. > Reviewed-by: Markus Armbruster From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42212) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZZxk-0004R9-RQ for qemu-devel@nongnu.org; Fri, 03 Feb 2017 04:15:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZZxg-00030A-RR for qemu-devel@nongnu.org; Fri, 03 Feb 2017 04:15:24 -0500 From: Markus Armbruster References: <1485778972-20924-1-git-send-email-thuth@redhat.com> <87lgtnd4k0.fsf@dusky.pond.sub.org> Date: Fri, 03 Feb 2017 10:15:17 +0100 In-Reply-To: <87lgtnd4k0.fsf@dusky.pond.sub.org> (Markus Armbruster's message of "Fri, 03 Feb 2017 10:09:03 +0100") Message-ID: <87efzfbpp6.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2] hw/core/or-irq: Mark the device with cannot_instantiate_with_device_add_yet List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: Alistair Francis , qemu-devel@nongnu.org, qemu-trivial@nongnu.org, Peter Maydell Markus Armbruster writes: > Thomas Huth writes: > >> The "or-irq" device needs to be wired up in source code, there is no >> way the user can add this device with the "-device" parameter or the >> "device_add" monitor command yet. Well, the user can (I tried), but it won't do squat then. >> Signed-off-by: Thomas Huth >> --- >> v2: Changed patch description and comment >> >> hw/core/or-irq.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/hw/core/or-irq.c b/hw/core/or-irq.c >> index 1ac090d..808c8d1 100644 >> --- a/hw/core/or-irq.c >> +++ b/hw/core/or-irq.c >> @@ -89,6 +89,9 @@ static void or_irq_class_init(ObjectClass *klass, void *data) >> dc->props = or_irq_properties; >> dc->realize = or_irq_realize; >> dc->vmsd = &vmstate_or_irq; >> + >> + /* Reason: Needs to be wired up in source code, e.g. see stm32f205_soc.c */ > > This line is a bit long, and it could be shortened easily: drop "in > source code", or replace it by "to work". This is how similar comments > elsewhere are phrased. > >> + dc->cannot_instantiate_with_device_add_yet = true; >> } >> >> static const TypeInfo or_irq_type_info = { > > Preferably with the comment touched up: Commit message, too. > Reviewed-by: Markus Armbruster