From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751157AbdAMGmL (ORCPT ); Fri, 13 Jan 2017 01:42:11 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:56020 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750700AbdAMGmJ (ORCPT ); Fri, 13 Jan 2017 01:42:09 -0500 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 44F7560388 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Greg Kroah-Hartman Cc: Willy Tarreau , lkml@pengaru.com, Dmitry Osipenko , Larry Finger , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Ping-Ke Shih Subject: Re: [PATCH 4.9 003/116] rtlwifi: Fix enter/exit power_save References: <20170106213908.681421800@linuxfoundation.org> <20170106213908.862747180@linuxfoundation.org> <18ad247d-470c-8cfb-e455-7fc11abcc6b0@gmail.com> <20170110204024.GA5274@kroah.com> <20170110212327.GH9125@shells.gnugeneration.com> <20170110215156.GC5258@1wt.eu> <20170112073212.GA21816@kroah.com> Date: Fri, 13 Jan 2017 08:42:03 +0200 In-Reply-To: <20170112073212.GA21816@kroah.com> (Greg Kroah-Hartman's message of "Thu, 12 Jan 2017 08:32:12 +0100") Message-ID: <87eg07o404.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greg Kroah-Hartman writes: > On Tue, Jan 10, 2017 at 10:51:56PM +0100, Willy Tarreau wrote: >> On Tue, Jan 10, 2017 at 03:23:27PM -0600, lkml@pengaru.com wrote: >> > On Tue, Jan 10, 2017 at 09:40:24PM +0100, Greg Kroah-Hartman wrote: >> > > On Tue, Jan 10, 2017 at 08:40:28PM +0300, Dmitry Osipenko wrote: >> > > > Hello, this patch causes a kernel panic with the rtl8192cu driver. >> > > >> > > Ick, not good! Does this cause a problem in Linus's tree as well? >> > > >> > >> > http://lkml.iu.edu/hypermail/linux/kernel/1701.1/00228.html >> >> OK the pending patch is here and not yet upstream : >> >> http://marc.info/?l=linux-wireless&m=148234081512703&w=2 >> >> It fixes ba9f93f82aba (patch 3/116) so better postpone it until >> the patch above gets merged. > > Yes, I've reverted this now and will wait for this fixup to hit Linus's > tree. Larry, can you remind me to include the original patch in the > stable tree when this fixup is merged? Linus pulled it now: commit 60f59ce0278557f7896d5158ae6d12a4855a72cc Author: Larry Finger Date: Wed Dec 21 11:18:55 2016 -0600 rtlwifi: rtl_usb: Fix missing entry in USB driver's private data These drivers need to be able to reference "struct ieee80211_hw" from the driver's private data, and vice versa. The USB driver failed to store the address of ieee80211_hw in the private data. Although this bug has been present for a long time, it was not exposed until commit ba9f93f82aba ("rtlwifi: Fix enter/exit power_save"). Fixes: ba9f93f82aba ("rtlwifi: Fix enter/exit power_save") Signed-off-by: Larry Finger Signed-off-by: Kalle Valo -- Kalle Valo