From: Nicolai Stange <nicstange@gmail.com>
To: Nicolai Stange <nicstange@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
Chaitanya Kulkarni <chaitanya.kulkarni@hgst.com>,
Shaun Tancheff <shaun.tancheff@seagate.com>,
Damien Le Moal <damien.lemoal@hgst.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: fix unintended fallthrough in generic_make_request_checks()
Date: Tue, 06 Dec 2016 01:04:54 +0100 [thread overview]
Message-ID: <87eg1l53dl.fsf@gmail.com> (raw)
In-Reply-To: <20161204135639.7016-1-nicstange@gmail.com> (Nicolai Stange's message of "Sun, 4 Dec 2016 14:56:39 +0100")
Nicolai Stange <nicstange@gmail.com> writes:
> ---
> Applicable to next-20161202.
>
> Note that after this patch, I'm seeing a single
> EXT4-fs (dm-1): Delayed block allocation failed for inode 2625094 at
> logical offset 2032 with max blocks 2 with error 121
> with 121 == EREMOTEIO
>
> This is because my SATA sda reports 0x20 (invalid command) back
> in response to 0x41 (WRITE_SAME).
>
> After this has happened, sd_done() disables "write same" once and for
> all, hence only this single message.
>
> I expect this to get fixed by
> https://patchwork.kernel.org/patch/9321963/
Just FYI: Not really, the (supposedly) corresponding commit has already
been in linux-next when I was testing: commit 0ce1b18c42a5 ("libata:
Some drives failing on SCT Write Same").
I sent separate patch for this issue:
http://lkml.kernel.org/r/20161205235638.11539-1-nicstange@gmail.com
Regards,
Nicolai
prev parent reply other threads:[~2016-12-06 0:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-04 13:56 [PATCH] block: fix unintended fallthrough in generic_make_request_checks() Nicolai Stange
2016-12-05 12:37 ` Christoph Hellwig
2016-12-05 14:55 ` Jens Axboe
2016-12-06 0:04 ` Nicolai Stange [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg1l53dl.fsf@gmail.com \
--to=nicstange@gmail.com \
--cc=axboe@kernel.dk \
--cc=chaitanya.kulkarni@hgst.com \
--cc=damien.lemoal@hgst.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaun.tancheff@seagate.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.