From: Markus Armbruster <armbru@redhat.com>
To: ashish mittal <ashmit602@gmail.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
Kevin Wolf <kwolf@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Venkatesha.Mg@veritas.com,
Ashish Mittal <ashish.mittal@veritas.com>,
Fam Zheng <famz@redhat.com>, Jeff Cody <jcody@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
Rakesh Ranjan <Rakesh.Ranjan@veritas.com>,
Ketan Nilangekar <Ketan.Nilangekar@veritas.com>,
Abhijit Dey <Abhijit.Dey@veritas.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Buddhi.Madhav@veritas.com
Subject: Re: [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"
Date: Wed, 16 Nov 2016 10:04:27 +0100 [thread overview]
Message-ID: <87eg2bokx0.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <CAAo6VWN9uO9-jjEfHxLHCBE5V5tr5Sx52tGY5vu3g8JgcCRqvQ@mail.gmail.com> (ashish mittal's message of "Tue, 15 Nov 2016 12:39:25 -0800")
ashish mittal <ashmit602@gmail.com> writes:
> Thanks for concluding on this.
>
> I will rearrange the qnio_api.h header accordingly as follows:
>
> +#include "qemu/osdep.h"
Headers should not include osdep.h.
> +#include <qnio/qnio_api.h> <=== after osdep.h
> +#include "block/block_int.h"
Including block_int.h in a header is problematic. Are you sure you need
it? Will qnio/qnio_api.h ever be included outside block/?
> +#include "qapi/qmp/qerror.h"
> +#include "qapi/qmp/qdict.h"
> +#include "qapi/qmp/qstring.h"
> +#include "trace.h"
> +#include "qemu/uri.h"
> +#include "qapi/error.h"
> +#include "qemu/error-report.h" <==== remove
In general, headers should include what they need, but no more.
next prev parent reply other threads:[~2016-11-16 9:04 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 0:59 [Qemu-devel] [PATCH v6 0/2] block/vxhs: Add Veritas HyperScale VxHS block device support Ashish Mittal
2016-11-08 0:59 ` [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new block device type called "vxhs" Ashish Mittal
2016-11-14 15:07 ` Stefan Hajnoczi
2016-11-14 15:49 ` Fam Zheng
2016-11-14 16:50 ` Stefan Hajnoczi
2016-11-14 18:03 ` Fam Zheng
2016-11-14 19:06 ` Eric Blake
2016-11-15 2:04 ` Fam Zheng
2016-11-15 10:18 ` Stefan Hajnoczi
2016-11-15 12:44 ` Fam Zheng
2016-11-15 14:45 ` Stefan Hajnoczi
2016-11-15 15:00 ` Fam Zheng
2016-11-15 19:20 ` Stefan Hajnoczi
2016-11-15 20:39 ` ashish mittal
2016-11-15 20:40 ` Stefan Hajnoczi
2016-11-16 9:04 ` Markus Armbruster [this message]
2016-11-16 9:49 ` Fam Zheng
2016-11-16 11:27 ` Stefan Hajnoczi
2016-11-16 17:05 ` ashish mittal
2017-02-01 1:55 ` ashish mittal
2017-02-02 10:08 ` Stefan Hajnoczi
2017-02-08 21:23 ` ashish mittal
2016-11-15 15:52 ` Eric Blake
2016-11-15 7:49 ` Markus Armbruster
2016-11-15 20:49 ` ashish mittal
2016-11-17 16:01 ` Daniel P. Berrange
2016-11-08 0:59 ` [Qemu-devel] [PATCH v6 2/2] block/vxhs.c: Add qemu-iotests for new block device type "vxhs" Ashish Mittal
2016-11-08 20:44 ` Jeff Cody
2017-02-07 23:12 ` ashish mittal
2017-02-13 13:37 ` Stefan Hajnoczi
2017-02-13 16:32 ` Jeff Cody
2017-02-13 22:36 ` Ketan Nilangekar
2017-02-13 23:23 ` Jeff Cody
2017-02-14 3:02 ` Ketan Nilangekar
2017-02-14 7:43 ` ashish mittal
2017-02-14 16:35 ` Jeff Cody
2017-02-14 16:51 ` Daniel P. Berrange
2017-02-14 17:05 ` Jeff Cody
2017-02-14 18:12 ` Jeff Cody
2017-02-14 18:28 ` ashish mittal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eg2bokx0.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=Abhijit.Dey@veritas.com \
--cc=Buddhi.Madhav@veritas.com \
--cc=Ketan.Nilangekar@veritas.com \
--cc=Rakesh.Ranjan@veritas.com \
--cc=Venkatesha.Mg@veritas.com \
--cc=ashish.mittal@veritas.com \
--cc=ashmit602@gmail.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.