From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41459)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1bhWyJ-00059A-FT
	for qemu-devel@nongnu.org; Wed, 07 Sep 2016 03:08:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1bhWyD-0006Pj-KZ
	for qemu-devel@nongnu.org; Wed, 07 Sep 2016 03:08:34 -0400
Received: from mail-wm0-x229.google.com ([2a00:1450:400c:c09::229]:35828)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1bhWyC-0006Of-S6
	for qemu-devel@nongnu.org; Wed, 07 Sep 2016 03:08:29 -0400
Received: by mail-wm0-x229.google.com with SMTP id i204so69878996wma.0
	for <qemu-devel@nongnu.org>; Wed, 07 Sep 2016 00:08:28 -0700 (PDT)
References: <1470929064-4092-1-git-send-email-alex.bennee@linaro.org>
	<1470929064-4092-9-git-send-email-alex.bennee@linaro.org>
	<ef386cec-28cd-b136-6853-109ec256e87b@twiddle.net>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <ef386cec-28cd-b136-6853-109ec256e87b@twiddle.net>
Date: Wed, 07 Sep 2016 08:08:25 +0100
Message-ID: <87eg4wyyom.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [RFC v4 08/28] translate-all: Add
 assert_(memory|tb)_lock annotations
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: mttcg@greensocs.com, qemu-devel@nongnu.org, fred.konrad@greensocs.com, a.rigo@virtualopensystems.com, cota@braap.org, bobby.prani@gmail.com, nikunj@linux.vnet.ibm.com, peter.maydell@linaro.org, claudio.fontana@huawei.com, Peter Crosthwaite <crosthwaite.peter@gmail.com>, jan.kiszka@siemens.com, mark.burton@greensocs.com, serge.fdrv@gmail.com, pbonzini@redhat.com


Richard Henderson <rth@twiddle.net> writes:

> On 08/11/2016 08:24 AM, Alex Bennée wrote:
>> This adds calls to the assert_(memory|tb)_lock for all public APIs which
>> are documented as needing them held for linux-user mode. The asserts are
>> NOPs for system-mode although these will be converted when MTTCG is
>> enabled.
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>
>
> Reviewed-by: Richard Henderson <rth@twiddle.net>
>
>> @@ -1111,7 +1121,7 @@ static void build_page_bitmap(PageDesc *p)
>>              tb_end = tb_start + tb->size;
>>              if (tb_end > TARGET_PAGE_SIZE) {
>>                  tb_end = TARGET_PAGE_SIZE;
>> -            }
>> +             }
>>          } else {
>
> Introducing a whitespace error?

Oops, that sneaked in.

--
Alex Bennée