From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKMSe-00007U-V6 for qemu-devel@nongnu.org; Tue, 05 Jul 2016 05:16:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKMSa-00045y-Rd for qemu-devel@nongnu.org; Tue, 05 Jul 2016 05:16:08 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:7521) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKMSa-00045q-JK for qemu-devel@nongnu.org; Tue, 05 Jul 2016 05:16:04 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u659Flii016071 for ; Tue, 5 Jul 2016 05:16:03 -0400 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 23x9s2rn0t-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 05 Jul 2016 05:16:03 -0400 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 5 Jul 2016 10:16:01 +0100 From: Sascha Silbe In-Reply-To: References: <20160628014747.20971-1-famz@redhat.com> <87k2h0ldni.fsf@oc4731375738.ibm.com> Date: Tue, 05 Jul 2016 11:15:55 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Message-Id: <87eg78la2c.fsf@oc4731375738.ibm.com> Subject: Re: [Qemu-devel] [PATCH] quorum: Only compile when supported List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org, Max Reitz Dear Alberto, Alberto Garcia writes: > On Tue 05 Jul 2016 09:58:25 AM CEST, Sascha Silbe wrote: > >> The quorum driver needs SHA256 which was introduced in gnutls 2.11.1. > > Are you sure about that? > > * Version 1.7.4 (released 2007-02-05) > > [...] > > ** API and ABI modifications: > GNUTLS_MAC_SHA256, [...] You are right, I misinterpreted the gnutls 2.11.1 NEWS entry. It added the RSA_NULL_SHA256 cipher suite, not the SHA256 hash algorithm. So the existing configure check is good enough, no need to bump the required gnutls version. Sascha --=20 Softwareentwicklung Sascha Silbe, Niederhofenstra=C3=9Fe 5/1, 71229 Leonberg https://se-silbe.de/ USt-IdNr. DE281696641