From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1bDUZN-0006R6-BY for kexec@lists.infradead.org; Thu, 16 Jun 2016 10:30:41 +0000 From: Vitaly Kuznetsov Subject: Re: [PATCH] Revert "mm: rename _count, field of the struct page, to _refcount" References: <1466068966-24620-1-git-send-email-vkuznets@redhat.com> <20160616093235.GA14640@infradead.org> Date: Thu, 16 Jun 2016 12:30:16 +0200 In-Reply-To: <20160616093235.GA14640@infradead.org> (Christoph Hellwig's message of "Thu, 16 Jun 2016 02:32:35 -0700") Message-ID: <87eg7xfmtj.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Christoph Hellwig Cc: Stephen Rothwell , linux-doc@vger.kernel.org, Hugh Dickins , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Ingo Molnar , linux-mm@kvack.org, Joonsoo Kim , Andrew Morton , Vlastimil Babka Christoph Hellwig writes: > On Thu, Jun 16, 2016 at 11:22:46AM +0200, Vitaly Kuznetsov wrote: >> _count -> _refcount rename in commit 0139aa7b7fa12 ("mm: rename _count, >> field of the struct page, to _refcount") broke kdump. makedumpfile(8) does >> stuff like READ_MEMBER_OFFSET("page._count", page._count) and fails. While >> it is definitely possible to fix this particular tool I'm not sure about >> other tools which might be doing the same. >> >> I suggest we remember the "we don't break userspace" rule and revert for >> 4.7 while it's not too late. > > Err, sorry - this is not "userspace". It's crazy crap digging into > kernel internal structure. > > The rename was absolutely useful, so fix up your stinking pike in kdump. Ok, sure, I'll send a patch to it. I was worried about other tools out there which e.g. inspect /proc/vmcore. As it is something we support some conservatism around it is justified. -- Vitaly _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f199.google.com (mail-qk0-f199.google.com [209.85.220.199]) by kanga.kvack.org (Postfix) with ESMTP id F351C6B025E for ; Thu, 16 Jun 2016 06:30:21 -0400 (EDT) Received: by mail-qk0-f199.google.com with SMTP id z142so127186137qkb.0 for ; Thu, 16 Jun 2016 03:30:21 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id 12si25858652qtw.33.2016.06.16.03.30.21 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Jun 2016 03:30:21 -0700 (PDT) From: Vitaly Kuznetsov Subject: Re: [PATCH] Revert "mm: rename _count, field of the struct page, to _refcount" References: <1466068966-24620-1-git-send-email-vkuznets@redhat.com> <20160616093235.GA14640@infradead.org> Date: Thu, 16 Jun 2016 12:30:16 +0200 In-Reply-To: <20160616093235.GA14640@infradead.org> (Christoph Hellwig's message of "Thu, 16 Jun 2016 02:32:35 -0700") Message-ID: <87eg7xfmtj.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Hellwig Cc: linux-mm@kvack.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Joonsoo Kim , Andrew Morton , Stephen Rothwell , Vlastimil Babka , Hugh Dickins , Ingo Molnar Christoph Hellwig writes: > On Thu, Jun 16, 2016 at 11:22:46AM +0200, Vitaly Kuznetsov wrote: >> _count -> _refcount rename in commit 0139aa7b7fa12 ("mm: rename _count, >> field of the struct page, to _refcount") broke kdump. makedumpfile(8) does >> stuff like READ_MEMBER_OFFSET("page._count", page._count) and fails. While >> it is definitely possible to fix this particular tool I'm not sure about >> other tools which might be doing the same. >> >> I suggest we remember the "we don't break userspace" rule and revert for >> 4.7 while it's not too late. > > Err, sorry - this is not "userspace". It's crazy crap digging into > kernel internal structure. > > The rename was absolutely useful, so fix up your stinking pike in kdump. Ok, sure, I'll send a patch to it. I was worried about other tools out there which e.g. inspect /proc/vmcore. As it is something we support some conservatism around it is justified. -- Vitaly -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754148AbcFPKaY (ORCPT ); Thu, 16 Jun 2016 06:30:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44922 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752158AbcFPKaV (ORCPT ); Thu, 16 Jun 2016 06:30:21 -0400 From: Vitaly Kuznetsov To: Christoph Hellwig Cc: linux-mm@kvack.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Joonsoo Kim , Andrew Morton , Stephen Rothwell , Vlastimil Babka , Hugh Dickins , Ingo Molnar Subject: Re: [PATCH] Revert "mm: rename _count, field of the struct page, to _refcount" References: <1466068966-24620-1-git-send-email-vkuznets@redhat.com> <20160616093235.GA14640@infradead.org> Date: Thu, 16 Jun 2016 12:30:16 +0200 In-Reply-To: <20160616093235.GA14640@infradead.org> (Christoph Hellwig's message of "Thu, 16 Jun 2016 02:32:35 -0700") Message-ID: <87eg7xfmtj.fsf@vitty.brq.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 16 Jun 2016 10:30:20 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christoph Hellwig writes: > On Thu, Jun 16, 2016 at 11:22:46AM +0200, Vitaly Kuznetsov wrote: >> _count -> _refcount rename in commit 0139aa7b7fa12 ("mm: rename _count, >> field of the struct page, to _refcount") broke kdump. makedumpfile(8) does >> stuff like READ_MEMBER_OFFSET("page._count", page._count) and fails. While >> it is definitely possible to fix this particular tool I'm not sure about >> other tools which might be doing the same. >> >> I suggest we remember the "we don't break userspace" rule and revert for >> 4.7 while it's not too late. > > Err, sorry - this is not "userspace". It's crazy crap digging into > kernel internal structure. > > The rename was absolutely useful, so fix up your stinking pike in kdump. Ok, sure, I'll send a patch to it. I was worried about other tools out there which e.g. inspect /proc/vmcore. As it is something we support some conservatism around it is justified. -- Vitaly