From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Date: Mon, 14 Mar 2016 00:10:45 +0000 Subject: Re: [patch] drm/vc4: Return -EFAULT on copy_from_user() failure Message-Id: <87egbd537e.fsf@eliezer.anholt.net> MIME-Version: 1 Content-Type: multipart/mixed; boundary="=-=-=" List-Id: References: <20160308120941.GD28684@mwanda> In-Reply-To: <20160308120941.GD28684@mwanda> To: Dan Carpenter , David Airlie Cc: Daniel Vetter , "Luis R. Rodriguez" , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrew Morton --=-=-= Content-Type: text/plain Dan Carpenter writes: > The copy_from_user() function returns the number of bytes not copied but > we want to return a negative error code. > > Fixes: 463873d57014 ('drm/vc4: Add an API for creating GPU shaders in GEM BOs.') > Signed-off-by: Dan Carpenter Pulled. Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJW5gGFAAoJELXWKTbR/J7o4S8QAKmM81nOWI/Ii32y0ti0r2xt Eqr5UW1QsIi+JGI+g7lsv0m5z1k5ya7lS4gRxOcB4iwZfAzkVwdxLWwiyzk59jkk a5FiYmBa/WigZ33wCdpg5Oc07BNRtSNnaYa1l9r2arxYUr8YGks/XnQ0I1XIq0e5 osgMG4WIBHyiYn7e7WIpjpVcD28AoGO+DJQdJH6ssyTBKBMYXRx/S3/YgeVbLe7p /BGMeTZY6ScSCPNtGA2VY0JufSy8JabmA1Nl6lFSAYDuN/vmB38j/M/gZnjBZgi/ VxpuA/nIpJwWYDyxnPtW2DpD9WZaZHn6+tSGtRHhjVcHj6KJt7OZq9bmY4IM20qB pOaMxORrU0QRQ82JglyVymI5kRbHM5a5liLnQALsIjg3Zwkt+eJqtk+0Mmfj/9TP H9D7rQTep/JBxx2Lfvx3R36lhJpg5rJiNoUa61b3cS1pcqI/dLewCzE/ULKXIaHj wmmCvK2m9L/Dozgqs6M1eU6skZRH5L8VM4YrR7jFxh6ZbNl+CxPrAhBY8BP4Yctf PKEUwqL5sK/tL63qI8dEOtYNDO7SFJJYYmpMQj3j4ERBeqCB4uoFmmU9uKUJildA 8VUMvRJ+E0ktujnoPoSkRN/t7G4jtoAH0RMlXwXXYpQQzhxrCmzXgj/tt5AXXJFJ ksQkUDD4Ti+DfJrtFln7 =PMmb -----END PGP SIGNATURE----- --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [patch] drm/vc4: Return -EFAULT on copy_from_user() failure Date: Sun, 13 Mar 2016 17:10:45 -0700 Message-ID: <87egbd537e.fsf@eliezer.anholt.net> References: <20160308120941.GD28684@mwanda> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0755567302==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 6824B895E7 for ; Mon, 14 Mar 2016 01:17:44 +0000 (UTC) In-Reply-To: <20160308120941.GD28684@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dan Carpenter , David Airlie Cc: Daniel Vetter , "Luis R. Rodriguez" , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrew Morton List-Id: dri-devel@lists.freedesktop.org --===============0755567302== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Dan Carpenter writes: > The copy_from_user() function returns the number of bytes not copied but > we want to return a negative error code. > > Fixes: 463873d57014 ('drm/vc4: Add an API for creating GPU shaders in GEM BOs.') > Signed-off-by: Dan Carpenter Pulled. Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJW5gGFAAoJELXWKTbR/J7o4S8QAKmM81nOWI/Ii32y0ti0r2xt Eqr5UW1QsIi+JGI+g7lsv0m5z1k5ya7lS4gRxOcB4iwZfAzkVwdxLWwiyzk59jkk a5FiYmBa/WigZ33wCdpg5Oc07BNRtSNnaYa1l9r2arxYUr8YGks/XnQ0I1XIq0e5 osgMG4WIBHyiYn7e7WIpjpVcD28AoGO+DJQdJH6ssyTBKBMYXRx/S3/YgeVbLe7p /BGMeTZY6ScSCPNtGA2VY0JufSy8JabmA1Nl6lFSAYDuN/vmB38j/M/gZnjBZgi/ VxpuA/nIpJwWYDyxnPtW2DpD9WZaZHn6+tSGtRHhjVcHj6KJt7OZq9bmY4IM20qB pOaMxORrU0QRQ82JglyVymI5kRbHM5a5liLnQALsIjg3Zwkt+eJqtk+0Mmfj/9TP H9D7rQTep/JBxx2Lfvx3R36lhJpg5rJiNoUa61b3cS1pcqI/dLewCzE/ULKXIaHj wmmCvK2m9L/Dozgqs6M1eU6skZRH5L8VM4YrR7jFxh6ZbNl+CxPrAhBY8BP4Yctf PKEUwqL5sK/tL63qI8dEOtYNDO7SFJJYYmpMQj3j4ERBeqCB4uoFmmU9uKUJildA 8VUMvRJ+E0ktujnoPoSkRN/t7G4jtoAH0RMlXwXXYpQQzhxrCmzXgj/tt5AXXJFJ ksQkUDD4Ti+DfJrtFln7 =PMmb -----END PGP SIGNATURE----- --=-=-=-- --===============0755567302== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0755567302==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752875AbcCNBRq (ORCPT ); Sun, 13 Mar 2016 21:17:46 -0400 Received: from anholt.net ([50.246.234.109]:54967 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750901AbcCNBRp (ORCPT ); Sun, 13 Mar 2016 21:17:45 -0400 From: Eric Anholt To: Dan Carpenter , David Airlie Cc: "Luis R. Rodriguez" , Daniel Vetter , Andrew Morton , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] drm/vc4: Return -EFAULT on copy_from_user() failure In-Reply-To: <20160308120941.GD28684@mwanda> References: <20160308120941.GD28684@mwanda> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Sun, 13 Mar 2016 17:10:45 -0700 Message-ID: <87egbd537e.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Dan Carpenter writes: > The copy_from_user() function returns the number of bytes not copied but > we want to return a negative error code. > > Fixes: 463873d57014 ('drm/vc4: Add an API for creating GPU shaders in GEM BOs.') > Signed-off-by: Dan Carpenter Pulled. Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJW5gGFAAoJELXWKTbR/J7o4S8QAKmM81nOWI/Ii32y0ti0r2xt Eqr5UW1QsIi+JGI+g7lsv0m5z1k5ya7lS4gRxOcB4iwZfAzkVwdxLWwiyzk59jkk a5FiYmBa/WigZ33wCdpg5Oc07BNRtSNnaYa1l9r2arxYUr8YGks/XnQ0I1XIq0e5 osgMG4WIBHyiYn7e7WIpjpVcD28AoGO+DJQdJH6ssyTBKBMYXRx/S3/YgeVbLe7p /BGMeTZY6ScSCPNtGA2VY0JufSy8JabmA1Nl6lFSAYDuN/vmB38j/M/gZnjBZgi/ VxpuA/nIpJwWYDyxnPtW2DpD9WZaZHn6+tSGtRHhjVcHj6KJt7OZq9bmY4IM20qB pOaMxORrU0QRQ82JglyVymI5kRbHM5a5liLnQALsIjg3Zwkt+eJqtk+0Mmfj/9TP H9D7rQTep/JBxx2Lfvx3R36lhJpg5rJiNoUa61b3cS1pcqI/dLewCzE/ULKXIaHj wmmCvK2m9L/Dozgqs6M1eU6skZRH5L8VM4YrR7jFxh6ZbNl+CxPrAhBY8BP4Yctf PKEUwqL5sK/tL63qI8dEOtYNDO7SFJJYYmpMQj3j4ERBeqCB4uoFmmU9uKUJildA 8VUMvRJ+E0ktujnoPoSkRN/t7G4jtoAH0RMlXwXXYpQQzhxrCmzXgj/tt5AXXJFJ ksQkUDD4Ti+DfJrtFln7 =PMmb -----END PGP SIGNATURE----- --=-=-=--