From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48532) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOqo2-0006FF-Uw for qemu-devel@nongnu.org; Thu, 28 Jan 2016 12:56:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aOqnz-0008QA-Lj for qemu-devel@nongnu.org; Thu, 28 Jan 2016 12:56:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60140) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOqnz-0008PO-GX for qemu-devel@nongnu.org; Thu, 28 Jan 2016 12:56:27 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id A38EA3B12C2 for ; Thu, 28 Jan 2016 17:56:25 +0000 (UTC) From: Markus Armbruster References: <1453219845-30939-1-git-send-email-eblake@redhat.com> Date: Thu, 28 Jan 2016 18:56:22 +0100 In-Reply-To: <1453219845-30939-1-git-send-email-eblake@redhat.com> (Eric Blake's message of "Tue, 19 Jan 2016 09:10:08 -0700") Message-ID: <87egd1egft.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v9 00/37] qapi visitor cleanups (post-introspection cleanups subset E) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org, Eduardo Habkost Eric Blake writes: > Based on qemu.git master. Pending prerequisites: > + Not a strong dependency, but for qapi-tests to consistently pass, > I needed a race fixed: > https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg01827.html Commit a174da3. Series needs a rebase now. I figure there are enough actionable review insights to warrant a full respin. However, the series' length makes review taxing. Could you try to split off an easier part for hopefully quick merging? Non-easy topics, from memory: * Retrofitting a contract to visitors. * Shall we require visit_end_FOO() even after error? I have to admit review dampened my enthusiasm for this idea. * PATCH 30+ [...]