From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHDt8-0003HI-9Q for qemu-devel@nongnu.org; Thu, 07 Jan 2016 11:58:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHDt5-0002hA-IS for qemu-devel@nongnu.org; Thu, 07 Jan 2016 11:58:14 -0500 Received: from e23smtp04.au.ibm.com ([202.81.31.146]:59231) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHDt4-0002h4-Vj for qemu-devel@nongnu.org; Thu, 07 Jan 2016 11:58:11 -0500 Received: from localhost by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 8 Jan 2016 02:58:08 +1000 Received: from d23relay10.au.ibm.com (d23relay10.au.ibm.com [9.190.26.77]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 3DA6D2CE8054 for ; Fri, 8 Jan 2016 03:58:05 +1100 (EST) Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay10.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u07GvuWf55902258 for ; Fri, 8 Jan 2016 03:58:05 +1100 Received: from d23av02.au.ibm.com (localhost [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u07GvWOV023723 for ; Fri, 8 Jan 2016 03:57:32 +1100 From: "Aneesh Kumar K.V" In-Reply-To: <1452020761-24457-21-git-send-email-wei.liu2@citrix.com> References: <1452020761-24457-1-git-send-email-wei.liu2@citrix.com> <1452020761-24457-21-git-send-email-wei.liu2@citrix.com> Date: Thu, 07 Jan 2016 22:27:13 +0530 Message-ID: <87egdtqqdy.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 20/22] 9pfs: break out generic code from virtio-9p.{c, h} List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wei Liu , qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Greg Kurz Wei Liu writes: > The vast majority of code in virtio-9p.c is actually generic code. > Rename that file to 9p.c and move virtio specific code to > virtio-9p-device.c. Rename virtio-9p.h to 9p.h and split out virtio > specific code to new virtio-9p.h. > > Finally fix up virtio-pci.h header file inclusion. > > Note that V9fsState and V9fsPDU are still tied to virtio at the moment. > They will be handled later. Can you split this to smaller patches as done for others. > > Signed-off-by: Wei Liu -aneesh