From: Felipe Balbi <balbi@ti.com>
To: "Felipe F. Tonello" <eu@felipetonello.com>, <linux-usb@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Robert Baldyga <r.baldyga@samsung.com>,
Clemens Ladisch <clemens@ladisch.de>
Subject: Re: [PATCH 1/2] usb: gadget: f_midi: refactor state machine
Date: Tue, 22 Dec 2015 11:49:06 -0600 [thread overview]
Message-ID: <87egeepe5p.fsf@saruman.tx.rr.com> (raw)
In-Reply-To: <1450800486-18150-1-git-send-email-eu@felipetonello.com>
[-- Attachment #1: Type: text/plain, Size: 492 bytes --]
Hi,
"Felipe F. Tonello" <eu@felipetonello.com> writes:
> This refactor includes the following:
> * Cleaner state machine code;
> * Reset state if MIDI message parsed is non-conformant;
> * Fixed bug when a conformant MIDI message was followed by a non-conformant
> causing the MIDI-USB message to use old temporary data (port->data[0..1]),
> thus packing a wrong MIDI-USB request.
we don't do more than one logical thing per patch. Please split this up.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2015-12-22 17:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 16:08 [PATCH 1/2] usb: gadget: f_midi: refactor state machine Felipe F. Tonello
2015-12-22 16:08 ` [PATCH 2/2] usb: gadget: f_midi: added spinlock on transmit function Felipe F. Tonello
2015-12-25 8:03 ` Peter Chen
2015-12-22 17:10 ` [PATCH 1/2] usb: gadget: f_midi: refactor state machine Clemens Ladisch
2015-12-23 11:50 ` Felipe Ferreri Tonello
2015-12-23 21:46 ` Clemens Ladisch
2015-12-22 17:49 ` Felipe Balbi [this message]
2015-12-23 9:19 ` Felipe Ferreri Tonello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87egeepe5p.fsf@saruman.tx.rr.com \
--to=balbi@ti.com \
--cc=clemens@ladisch.de \
--cc=eu@felipetonello.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=r.baldyga@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.