From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [PATCH v2 04/21] arm64: KVM: Implement vgic-v3 save/restore Date: Mon, 30 Nov 2015 09:59:32 +0000 Message-ID: <87egf7byez.fsf@linaro.org> References: <1448650215-15218-1-git-send-email-marc.zyngier@arm.com> <1448650215-15218-5-git-send-email-marc.zyngier@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 8E0B2410B5 for ; Mon, 30 Nov 2015 04:58:16 -0500 (EST) Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I95FFnBI4AXM for ; Mon, 30 Nov 2015 04:58:15 -0500 (EST) Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 3825D40FA6 for ; Mon, 30 Nov 2015 04:58:14 -0500 (EST) Received: by wmec201 with SMTP id c201so130386931wme.1 for ; Mon, 30 Nov 2015 01:59:34 -0800 (PST) In-reply-to: <1448650215-15218-5-git-send-email-marc.zyngier@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu To: Marc Zyngier Cc: kvm@vger.kernel.org, Ard Biesheuvel , Catalin Marinas , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org List-Id: kvmarm@lists.cs.columbia.edu Ck1hcmMgWnluZ2llciA8bWFyYy56eW5naWVyQGFybS5jb20+IHdyaXRlczoKCj4gSW1wbGVtZW50 IHRoZSB2Z2ljLXYzIHNhdmUgcmVzdG9yZSBhcyBhIGRpcmVjdCB0cmFuc2xhdGlvbiBvZgo+IHRo ZSBhc3NlbWJseSBjb2RlIHZlcnNpb24uCj4KPiBTaWduZWQtb2ZmLWJ5OiBNYXJjIFp5bmdpZXIg PG1hcmMuenluZ2llckBhcm0uY29tPgo+IC0tLQo+ICBhcmNoL2FybTY0L2t2bS9oeXAvTWFrZWZp bGUgICAgIHwgICAxICsKPiAgYXJjaC9hcm02NC9rdm0vaHlwL2h5cC5oICAgICAgICB8ICAgMyAr Cj4gIGFyY2gvYXJtNjQva3ZtL2h5cC92Z2ljLXYzLXNyLmMgfCAyMjIgKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKwo+ICAzIGZpbGVzIGNoYW5nZWQsIDIyNiBpbnNlcnRp b25zKCspCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBhcmNoL2FybTY0L2t2bS9oeXAvdmdpYy12My1z ci5jCj4KPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9rdm0vaHlwL01ha2VmaWxlIGIvYXJjaC9h cm02NC9rdm0vaHlwL01ha2VmaWxlCj4gaW5kZXggZDhkNTk2OC4uZDFlMzhjZSAxMDA2NDQKPiAt LS0gYS9hcmNoL2FybTY0L2t2bS9oeXAvTWFrZWZpbGUKPiArKysgYi9hcmNoL2FybTY0L2t2bS9o eXAvTWFrZWZpbGUKPiBAQCAtMywzICszLDQgQEAKPiAgIwo+Cj4gIG9iai0kKENPTkZJR19LVk1f QVJNX0hPU1QpICs9IHZnaWMtdjItc3Iubwo+ICtvYmotJChDT05GSUdfS1ZNX0FSTV9IT1NUKSAr PSB2Z2ljLXYzLXNyLm8KPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9rdm0vaHlwL2h5cC5oIGIv YXJjaC9hcm02NC9rdm0vaHlwL2h5cC5oCj4gaW5kZXggNzhmMjVjNC4uYTMxY2I2ZSAxMDA2NDQK PiAtLS0gYS9hcmNoL2FybTY0L2t2bS9oeXAvaHlwLmgKPiArKysgYi9hcmNoL2FybTY0L2t2bS9o eXAvaHlwLmgKPiBAQCAtMzAsNSArMzAsOCBAQAo+ICB2b2lkIF9fdmdpY192Ml9zYXZlX3N0YXRl KHN0cnVjdCBrdm1fdmNwdSAqdmNwdSk7Cj4gIHZvaWQgX192Z2ljX3YyX3Jlc3RvcmVfc3RhdGUo c3RydWN0IGt2bV92Y3B1ICp2Y3B1KTsKPgo+ICt2b2lkIF9fdmdpY192M19zYXZlX3N0YXRlKHN0 cnVjdCBrdm1fdmNwdSAqdmNwdSk7Cj4gK3ZvaWQgX192Z2ljX3YzX3Jlc3RvcmVfc3RhdGUoc3Ry dWN0IGt2bV92Y3B1ICp2Y3B1KTsKPiArCj4gICNlbmRpZiAvKiBfX0FSTTY0X0tWTV9IWVBfSF9f ICovCj4KPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9rdm0vaHlwL3ZnaWMtdjMtc3IuYyBiL2Fy Y2gvYXJtNjQva3ZtL2h5cC92Z2ljLXYzLXNyLmMKPiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+IGlu ZGV4IDAwMDAwMDAuLmI0OTBkYjUKPiAtLS0gL2Rldi9udWxsCj4gKysrIGIvYXJjaC9hcm02NC9r dm0vaHlwL3ZnaWMtdjMtc3IuYwo+IEBAIC0wLDAgKzEsMjIyIEBACj4gKy8qCj4gKyAqIENvcHly aWdodCAoQykgMjAxMi0yMDE1IC0gQVJNIEx0ZAo+ICsgKiBBdXRob3I6IE1hcmMgWnluZ2llciA8 bWFyYy56eW5naWVyQGFybS5jb20+Cj4gKyAqCj4gKyAqIFRoaXMgcHJvZ3JhbSBpcyBmcmVlIHNv ZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5Cj4gKyAqIGl0IHVu ZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgdmVyc2lvbiAy IGFzCj4gKyAqIHB1Ymxpc2hlZCBieSB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLgo+ICsg Kgo+ICsgKiBUaGlzIHByb2dyYW0gaXMgZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3 aWxsIGJlIHVzZWZ1bCwKPiArICogYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2 ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YKPiArICogTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5F U1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZQo+ICsgKiBHTlUgR2VuZXJhbCBQ dWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgo+ICsgKgo+ICsgKiBZb3Ugc2hvdWxkIGhh dmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQo+ICsg KiBhbG9uZyB3aXRoIHRoaXMgcHJvZ3JhbS4gIElmIG5vdCwgc2VlIDxodHRwOi8vd3d3LmdudS5v cmcvbGljZW5zZXMvPi4KPiArICovCj4gKwo+ICsjaW5jbHVkZSA8bGludXgvY29tcGlsZXIuaD4K PiArI2luY2x1ZGUgPGxpbnV4L2lycWNoaXAvYXJtLWdpYy12My5oPgoKVGhpcyBpbmNsdWRlIHN0 YXJ0cyBzcGl0dGluZyBvdXQgY29tcGlsZXIgd2FybmluZ3MgZHVlIHRvIHVzZSBvZgp1bmRlZmlu ZWQgYmFycmllciBwcmltaXRpdmVzLiBJJ20gbm90IHN1cmUgd2hlcmUgdGhlIGJlc3QgcGxhY2Ug dG86CgogI2luY2x1ZGUgPGFzbS9iYXJyaWVyLmg+Cgppcy4gSSBhZGRlZCBpdCB0bzoKCiAgYXJj aC9hcm02NC9pbmNsdWRlL2FzbS9hcmNoX2dpY3YzLmgKCj4gKyNpbmNsdWRlIDxsaW51eC9rdm1f aG9zdC5oPgo+ICsKPiArI2luY2x1ZGUgPGFzbS9rdm1fbW11Lmg+Cj4gKwo+ICsjaW5jbHVkZSAi aHlwLmgiCj4gKwo+ICsvKgo+ICsgKiBXZSBzdG9yZSBMUnMgaW4gcmV2ZXJzZSBvcmRlciB0byBs ZXQgdGhlIENQVSBkZWFsIHdpdGggc3RyZWFtaW5nCj4gKyAqIGFjY2Vzcy4gVXNlIHRoaXMgbWFj cm8gdG8gbWFrZSBpdCBsb29rIHNhbmVyLi4uCj4gKyAqLwo+ICsjZGVmaW5lIExSX09GRlNFVChu KQkoMTUgLSBuKQo+ICsKPiArI2RlZmluZSByZWFkX2dpY3JlZyhyKQkJCQkJCQlcCj4gKwkoewkJ CQkJCQkJXAo+ICsJCXU2NCByZWc7CQkJCQkJXAo+ICsJCWFzbSB2b2xhdGlsZSgibXJzX3MgJTAs ICIgX19zdHJpbmdpZnkocikgOiAiPXIiIChyZWcpKTsJXAo+ICsJCXJlZzsJCQkJCQkJXAo+ICsJ fSkKPiArCj4gKyNkZWZpbmUgd3JpdGVfZ2ljcmVnKHYscikJCQkJCQlcCj4gKwlkbyB7CQkJCQkJ CQlcCj4gKwkJdTY0IF9fdmFsID0gKHYpOwkJCQkJXAo+ICsJCWFzbSB2b2xhdGlsZSgibXNyX3Mg IiBfX3N0cmluZ2lmeShyKSAiLCAlMCIgOiA6ICJyIiAoX192YWwpKTtcCj4gKwl9IHdoaWxlICgw KQo+ICsKPiArLyogdmNwdSBpcyBhbHJlYWR5IGluIHRoZSBIWVAgVkEgc3BhY2UgKi8KPiArdm9p ZCBfX2h5cF90ZXh0IF9fdmdpY192M19zYXZlX3N0YXRlKHN0cnVjdCBrdm1fdmNwdSAqdmNwdSkK PiArewo+ICsJc3RydWN0IHZnaWNfdjNfY3B1X2lmICpjcHVfaWYgPSAmdmNwdS0+YXJjaC52Z2lj X2NwdS52Z2ljX3YzOwo+ICsJdTY0IHZhbDsKPiArCXUzMiBucl9sciwgbnJfcHJpOwo+ICsKPiAr CS8qCj4gKwkgKiBNYWtlIHN1cmUgc3RvcmVzIHRvIHRoZSBHSUMgdmlhIHRoZSBtZW1vcnkgbWFw cGVkIGludGVyZmFjZQo+ICsJICogYXJlIG5vdyB2aXNpYmxlIHRvIHRoZSBzeXN0ZW0gcmVnaXN0 ZXIgaW50ZXJmYWNlLgo+ICsJICovCj4gKwlkc2Ioc3QpOwo+ICsKPiArCWNwdV9pZi0+dmdpY192 bWNyICA9IHJlYWRfZ2ljcmVnKElDSF9WTUNSX0VMMik7Cj4gKwljcHVfaWYtPnZnaWNfbWlzciAg PSByZWFkX2dpY3JlZyhJQ0hfTUlTUl9FTDIpOwo+ICsJY3B1X2lmLT52Z2ljX2Vpc3IgID0gcmVh ZF9naWNyZWcoSUNIX0VJU1JfRUwyKTsKPiArCWNwdV9pZi0+dmdpY19lbHJzciA9IHJlYWRfZ2lj cmVnKElDSF9FTFNSX0VMMik7Cj4gKwo+ICsJd3JpdGVfZ2ljcmVnKDAsIElDSF9IQ1JfRUwyKTsK PiArCXZhbCA9IHJlYWRfZ2ljcmVnKElDSF9WVFJfRUwyKTsKPiArCW5yX2xyID0gdmFsICYgMHhm Owo+ICsJbnJfcHJpID0gKCh1MzIpdmFsID4+IDI5KSArIDE7Cj4gKwo+ICsJc3dpdGNoIChucl9s cikgewo+ICsJY2FzZSAxNToKPiArCQljcHVfaWYtPnZnaWNfbHJbTFJfT0ZGU0VUKDE1KV0gPSBy ZWFkX2dpY3JlZyhJQ0hfTFIxNV9FTDIpOwo+ICsJY2FzZSAxNDoKPiArCQljcHVfaWYtPnZnaWNf bHJbTFJfT0ZGU0VUKDE0KV0gPSByZWFkX2dpY3JlZyhJQ0hfTFIxNF9FTDIpOwo+ICsJY2FzZSAx MzoKPiArCQljcHVfaWYtPnZnaWNfbHJbTFJfT0ZGU0VUKDEzKV0gPSByZWFkX2dpY3JlZyhJQ0hf TFIxM19FTDIpOwo+ICsJY2FzZSAxMjoKPiArCQljcHVfaWYtPnZnaWNfbHJbTFJfT0ZGU0VUKDEy KV0gPSByZWFkX2dpY3JlZyhJQ0hfTFIxMl9FTDIpOwo+ICsJY2FzZSAxMToKPiArCQljcHVfaWYt PnZnaWNfbHJbTFJfT0ZGU0VUKDExKV0gPSByZWFkX2dpY3JlZyhJQ0hfTFIxMV9FTDIpOwo+ICsJ Y2FzZSAxMDoKPiArCQljcHVfaWYtPnZnaWNfbHJbTFJfT0ZGU0VUKDEwKV0gPSByZWFkX2dpY3Jl ZyhJQ0hfTFIxMF9FTDIpOwo+ICsJY2FzZSA5Ogo+ICsJCWNwdV9pZi0+dmdpY19scltMUl9PRkZT RVQoOSldID0gcmVhZF9naWNyZWcoSUNIX0xSOV9FTDIpOwo+ICsJY2FzZSA4Ogo+ICsJCWNwdV9p Zi0+dmdpY19scltMUl9PRkZTRVQoOCldID0gcmVhZF9naWNyZWcoSUNIX0xSOF9FTDIpOwo+ICsJ Y2FzZSA3Ogo+ICsJCWNwdV9pZi0+dmdpY19scltMUl9PRkZTRVQoNyldID0gcmVhZF9naWNyZWco SUNIX0xSN19FTDIpOwo+ICsJY2FzZSA2Ogo+ICsJCWNwdV9pZi0+dmdpY19scltMUl9PRkZTRVQo NildID0gcmVhZF9naWNyZWcoSUNIX0xSNl9FTDIpOwo+ICsJY2FzZSA1Ogo+ICsJCWNwdV9pZi0+ dmdpY19scltMUl9PRkZTRVQoNSldID0gcmVhZF9naWNyZWcoSUNIX0xSNV9FTDIpOwo+ICsJY2Fz ZSA0Ogo+ICsJCWNwdV9pZi0+dmdpY19scltMUl9PRkZTRVQoNCldID0gcmVhZF9naWNyZWcoSUNI X0xSNF9FTDIpOwo+ICsJY2FzZSAzOgo+ICsJCWNwdV9pZi0+dmdpY19scltMUl9PRkZTRVQoMyld ID0gcmVhZF9naWNyZWcoSUNIX0xSM19FTDIpOwo+ICsJY2FzZSAyOgo+ICsJCWNwdV9pZi0+dmdp Y19scltMUl9PRkZTRVQoMildID0gcmVhZF9naWNyZWcoSUNIX0xSMl9FTDIpOwo+ICsJY2FzZSAx Ogo+ICsJCWNwdV9pZi0+dmdpY19scltMUl9PRkZTRVQoMSldID0gcmVhZF9naWNyZWcoSUNIX0xS MV9FTDIpOwo+ICsJY2FzZSAwOgo+ICsJCWNwdV9pZi0+dmdpY19scltMUl9PRkZTRVQoMCldID0g cmVhZF9naWNyZWcoSUNIX0xSMF9FTDIpOwo+ICsJfQo+ICsKPiArCXN3aXRjaCAobnJfcHJpKSB7 Cj4gKwljYXNlIDc6Cj4gKwkJY3B1X2lmLT52Z2ljX2FwMHJbM10gPSByZWFkX2dpY3JlZyhJQ0hf QVAwUjNfRUwyKTsKPiArCQljcHVfaWYtPnZnaWNfYXAwclsyXSA9IHJlYWRfZ2ljcmVnKElDSF9B UDBSMl9FTDIpOwo+ICsJY2FzZSA2Ogo+ICsJCWNwdV9pZi0+dmdpY19hcDByWzFdID0gcmVhZF9n aWNyZWcoSUNIX0FQMFIxX0VMMik7Cj4gKwlkZWZhdWx0Ogo+ICsJCWNwdV9pZi0+dmdpY19hcDBy WzBdID0gcmVhZF9naWNyZWcoSUNIX0FQMFIwX0VMMik7Cj4gKwl9Cj4gKwo+ICsJc3dpdGNoIChu cl9wcmkpIHsKPiArCWNhc2UgNzoKPiArCQljcHVfaWYtPnZnaWNfYXAxclszXSA9IHJlYWRfZ2lj cmVnKElDSF9BUDFSM19FTDIpOwo+ICsJCWNwdV9pZi0+dmdpY19hcDFyWzJdID0gcmVhZF9naWNy ZWcoSUNIX0FQMVIyX0VMMik7Cj4gKwljYXNlIDY6Cj4gKwkJY3B1X2lmLT52Z2ljX2FwMXJbMV0g PSByZWFkX2dpY3JlZyhJQ0hfQVAxUjFfRUwyKTsKPiArCWRlZmF1bHQ6Cj4gKwkJY3B1X2lmLT52 Z2ljX2FwMXJbMF0gPSByZWFkX2dpY3JlZyhJQ0hfQVAxUjBfRUwyKTsKPiArCX0KPiArCj4gKwl3 cml0ZV9naWNyZWcocmVhZF9naWNyZWcoSUNDX1NSRV9FTDIpIHwgSUNDX1NSRV9FTDJfRU5BQkxF LAo+ICsJCSAgICAgSUNDX1NSRV9FTDIpOwo+ICsJaXNiKCk7Cj4gKwl3cml0ZV9naWNyZWcoMSwg SUNDX1NSRV9FTDEpOwo+ICt9Cj4gKwo+ICt2b2lkIF9faHlwX3RleHQgX192Z2ljX3YzX3Jlc3Rv cmVfc3RhdGUoc3RydWN0IGt2bV92Y3B1ICp2Y3B1KQo+ICt7Cj4gKwlzdHJ1Y3QgdmdpY192M19j cHVfaWYgKmNwdV9pZiA9ICZ2Y3B1LT5hcmNoLnZnaWNfY3B1LnZnaWNfdjM7Cj4gKwl1NjQgdmFs Owo+ICsJdTMyIG5yX2xyLCBucl9wcmk7Cj4gKwo+ICsJLyogTWFrZSBzdXJlIFNSRSBpcyB2YWxp ZCBiZWZvcmUgd3JpdGluZyB0aGUgb3RoZXIgcmVnaXN0ZXJzICovCj4gKwl3cml0ZV9naWNyZWco Y3B1X2lmLT52Z2ljX3NyZSwgSUNDX1NSRV9FTDEpOwo+ICsJaXNiKCk7Cj4gKwo+ICsJd3JpdGVf Z2ljcmVnKGNwdV9pZi0+dmdpY19oY3IsIElDSF9IQ1JfRUwyKTsKPiArCXdyaXRlX2dpY3JlZyhj cHVfaWYtPnZnaWNfdm1jciwgSUNIX1ZNQ1JfRUwyKTsKPiArCj4gKwl2YWwgPSByZWFkX2dpY3Jl ZyhJQ0hfVlRSX0VMMik7Cj4gKwlucl9sciA9IHZhbCAmIDB4ZjsKPiArCW5yX3ByaSA9ICgodTMy KXZhbCA+PiAyOSkgKyAxOwo+ICsKPiArCXN3aXRjaCAobnJfcHJpKSB7Cj4gKwljYXNlIDc6Cj4g KwkJIHdyaXRlX2dpY3JlZyhjcHVfaWYtPnZnaWNfYXAxclszXSwgSUNIX0FQMVIzX0VMMik7Cj4g KwkJIHdyaXRlX2dpY3JlZyhjcHVfaWYtPnZnaWNfYXAxclsyXSwgSUNIX0FQMVIyX0VMMik7Cj4g KwljYXNlIDY6Cj4gKwkJIHdyaXRlX2dpY3JlZyhjcHVfaWYtPnZnaWNfYXAxclsxXSwgSUNIX0FQ MVIxX0VMMik7Cj4gKwlkZWZhdWx0Ogo+ICsJCSB3cml0ZV9naWNyZWcoY3B1X2lmLT52Z2ljX2Fw MXJbMF0sIElDSF9BUDFSMF9FTDIpOwo+ICsJfQo+ICsKPiArCXN3aXRjaCAobnJfcHJpKSB7Cj4g KwljYXNlIDc6Cj4gKwkJIHdyaXRlX2dpY3JlZyhjcHVfaWYtPnZnaWNfYXAwclszXSwgSUNIX0FQ MFIzX0VMMik7Cj4gKwkJIHdyaXRlX2dpY3JlZyhjcHVfaWYtPnZnaWNfYXAwclsyXSwgSUNIX0FQ MFIyX0VMMik7Cj4gKwljYXNlIDY6Cj4gKwkJIHdyaXRlX2dpY3JlZyhjcHVfaWYtPnZnaWNfYXAw clsxXSwgSUNIX0FQMFIxX0VMMik7Cj4gKwlkZWZhdWx0Ogo+ICsJCSB3cml0ZV9naWNyZWcoY3B1 X2lmLT52Z2ljX2FwMHJbMF0sIElDSF9BUDBSMF9FTDIpOwo+ICsJfQo+ICsKPiArCXN3aXRjaCAo bnJfbHIpIHsKPiArCWNhc2UgMTU6Cj4gKwkJd3JpdGVfZ2ljcmVnKGNwdV9pZi0+dmdpY19scltM Ul9PRkZTRVQoMTUpXSwgSUNIX0xSMTVfRUwyKTsKPiArCWNhc2UgMTQ6Cj4gKwkJd3JpdGVfZ2lj cmVnKGNwdV9pZi0+dmdpY19scltMUl9PRkZTRVQoMTQpXSwgSUNIX0xSMTRfRUwyKTsKPiArCWNh c2UgMTM6Cj4gKwkJd3JpdGVfZ2ljcmVnKGNwdV9pZi0+dmdpY19scltMUl9PRkZTRVQoMTMpXSwg SUNIX0xSMTNfRUwyKTsKPiArCWNhc2UgMTI6Cj4gKwkJd3JpdGVfZ2ljcmVnKGNwdV9pZi0+dmdp Y19scltMUl9PRkZTRVQoMTIpXSwgSUNIX0xSMTJfRUwyKTsKPiArCWNhc2UgMTE6Cj4gKwkJd3Jp dGVfZ2ljcmVnKGNwdV9pZi0+dmdpY19scltMUl9PRkZTRVQoMTEpXSwgSUNIX0xSMTFfRUwyKTsK PiArCWNhc2UgMTA6Cj4gKwkJd3JpdGVfZ2ljcmVnKGNwdV9pZi0+dmdpY19scltMUl9PRkZTRVQo MTApXSwgSUNIX0xSMTBfRUwyKTsKPiArCWNhc2UgOToKPiArCQl3cml0ZV9naWNyZWcoY3B1X2lm LT52Z2ljX2xyW0xSX09GRlNFVCg5KV0sIElDSF9MUjlfRUwyKTsKPiArCWNhc2UgODoKPiArCQl3 cml0ZV9naWNyZWcoY3B1X2lmLT52Z2ljX2xyW0xSX09GRlNFVCg4KV0sIElDSF9MUjhfRUwyKTsK PiArCWNhc2UgNzoKPiArCQl3cml0ZV9naWNyZWcoY3B1X2lmLT52Z2ljX2xyW0xSX09GRlNFVCg3 KV0sIElDSF9MUjdfRUwyKTsKPiArCWNhc2UgNjoKPiArCQl3cml0ZV9naWNyZWcoY3B1X2lmLT52 Z2ljX2xyW0xSX09GRlNFVCg2KV0sIElDSF9MUjZfRUwyKTsKPiArCWNhc2UgNToKPiArCQl3cml0 ZV9naWNyZWcoY3B1X2lmLT52Z2ljX2xyW0xSX09GRlNFVCg1KV0sIElDSF9MUjVfRUwyKTsKPiAr CWNhc2UgNDoKPiArCQl3cml0ZV9naWNyZWcoY3B1X2lmLT52Z2ljX2xyW0xSX09GRlNFVCg0KV0s IElDSF9MUjRfRUwyKTsKPiArCWNhc2UgMzoKPiArCQl3cml0ZV9naWNyZWcoY3B1X2lmLT52Z2lj X2xyW0xSX09GRlNFVCgzKV0sIElDSF9MUjNfRUwyKTsKPiArCWNhc2UgMjoKPiArCQl3cml0ZV9n aWNyZWcoY3B1X2lmLT52Z2ljX2xyW0xSX09GRlNFVCgyKV0sIElDSF9MUjJfRUwyKTsKPiArCWNh c2UgMToKPiArCQl3cml0ZV9naWNyZWcoY3B1X2lmLT52Z2ljX2xyW0xSX09GRlNFVCgxKV0sIElD SF9MUjFfRUwyKTsKPiArCWNhc2UgMDoKPiArCQl3cml0ZV9naWNyZWcoY3B1X2lmLT52Z2ljX2xy W0xSX09GRlNFVCgwKV0sIElDSF9MUjBfRUwyKTsKPiArCX0KPiArCj4gKwkvKgo+ICsJICogRW5z dXJlIHRoYXQgdGhlIGFib3ZlIHdpbGwgaGF2ZSByZWFjaGVkIHRoZQo+ICsJICogKHJlKWRpc3Ry aWJ1dG9ycy4gVGhpcyBlbnN1cmUgdGhlIGd1ZXN0IHdpbGwgcmVhZCB0aGUKPiArCSAqIGNvcnJl Y3QgdmFsdWVzIGZyb20gdGhlIG1lbW9yeS1tYXBwZWQgaW50ZXJmYWNlLgo+ICsJICovCj4gKwlp c2IoKTsKPiArCWRzYihzeSk7Cj4gKwo+ICsJLyoKPiArCSAqIFByZXZlbnQgdGhlIGd1ZXN0IGZy b20gdG91Y2hpbmcgdGhlIEdJQyBzeXN0ZW0gcmVnaXN0ZXJzIGlmCj4gKwkgKiBTUkUgaXNuJ3Qg ZW5hYmxlZCBmb3IgR0lDdjMgZW11bGF0aW9uLgo+ICsJICovCj4gKwlpZiAoIWNwdV9pZi0+dmdp Y19zcmUpIHsKPiArCQl3cml0ZV9naWNyZWcocmVhZF9naWNyZWcoSUNDX1NSRV9FTDIpICYgfklD Q19TUkVfRUwyX0VOQUJMRSwKPiArCQkJICAgICBJQ0NfU1JFX0VMMik7Cj4gKwl9Cj4gK30KPiAr Cj4gK3U2NCBfX2h5cF90ZXh0IF9fdmdpY192M19yZWFkX2ljaF92dHJfZWwyKHZvaWQpCj4gK3sK PiArCXJldHVybiByZWFkX2dpY3JlZyhJQ0hfVlRSX0VMMik7Cj4gK30KCgotLQpBbGV4IEJlbm7D qWUKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka3ZtYXJt IG1haWxpbmcgbGlzdAprdm1hcm1AbGlzdHMuY3MuY29sdW1iaWEuZWR1Cmh0dHBzOi8vbGlzdHMu Y3MuY29sdW1iaWEuZWR1L21haWxtYW4vbGlzdGluZm8va3ZtYXJtCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: alex.bennee@linaro.org (Alex =?utf-8?Q?Benn=C3=A9e?=) Date: Mon, 30 Nov 2015 09:59:32 +0000 Subject: [PATCH v2 04/21] arm64: KVM: Implement vgic-v3 save/restore In-Reply-To: <1448650215-15218-5-git-send-email-marc.zyngier@arm.com> References: <1448650215-15218-1-git-send-email-marc.zyngier@arm.com> <1448650215-15218-5-git-send-email-marc.zyngier@arm.com> Message-ID: <87egf7byez.fsf@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Marc Zyngier writes: > Implement the vgic-v3 save restore as a direct translation of > the assembly code version. > > Signed-off-by: Marc Zyngier > --- > arch/arm64/kvm/hyp/Makefile | 1 + > arch/arm64/kvm/hyp/hyp.h | 3 + > arch/arm64/kvm/hyp/vgic-v3-sr.c | 222 ++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 226 insertions(+) > create mode 100644 arch/arm64/kvm/hyp/vgic-v3-sr.c > > diff --git a/arch/arm64/kvm/hyp/Makefile b/arch/arm64/kvm/hyp/Makefile > index d8d5968..d1e38ce 100644 > --- a/arch/arm64/kvm/hyp/Makefile > +++ b/arch/arm64/kvm/hyp/Makefile > @@ -3,3 +3,4 @@ > # > > obj-$(CONFIG_KVM_ARM_HOST) += vgic-v2-sr.o > +obj-$(CONFIG_KVM_ARM_HOST) += vgic-v3-sr.o > diff --git a/arch/arm64/kvm/hyp/hyp.h b/arch/arm64/kvm/hyp/hyp.h > index 78f25c4..a31cb6e 100644 > --- a/arch/arm64/kvm/hyp/hyp.h > +++ b/arch/arm64/kvm/hyp/hyp.h > @@ -30,5 +30,8 @@ > void __vgic_v2_save_state(struct kvm_vcpu *vcpu); > void __vgic_v2_restore_state(struct kvm_vcpu *vcpu); > > +void __vgic_v3_save_state(struct kvm_vcpu *vcpu); > +void __vgic_v3_restore_state(struct kvm_vcpu *vcpu); > + > #endif /* __ARM64_KVM_HYP_H__ */ > > diff --git a/arch/arm64/kvm/hyp/vgic-v3-sr.c b/arch/arm64/kvm/hyp/vgic-v3-sr.c > new file mode 100644 > index 0000000..b490db5 > --- /dev/null > +++ b/arch/arm64/kvm/hyp/vgic-v3-sr.c > @@ -0,0 +1,222 @@ > +/* > + * Copyright (C) 2012-2015 - ARM Ltd > + * Author: Marc Zyngier > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program. If not, see . > + */ > + > +#include > +#include This include starts spitting out compiler warnings due to use of undefined barrier primitives. I'm not sure where the best place to: #include is. I added it to: arch/arm64/include/asm/arch_gicv3.h > +#include > + > +#include > + > +#include "hyp.h" > + > +/* > + * We store LRs in reverse order to let the CPU deal with streaming > + * access. Use this macro to make it look saner... > + */ > +#define LR_OFFSET(n) (15 - n) > + > +#define read_gicreg(r) \ > + ({ \ > + u64 reg; \ > + asm volatile("mrs_s %0, " __stringify(r) : "=r" (reg)); \ > + reg; \ > + }) > + > +#define write_gicreg(v,r) \ > + do { \ > + u64 __val = (v); \ > + asm volatile("msr_s " __stringify(r) ", %0" : : "r" (__val));\ > + } while (0) > + > +/* vcpu is already in the HYP VA space */ > +void __hyp_text __vgic_v3_save_state(struct kvm_vcpu *vcpu) > +{ > + struct vgic_v3_cpu_if *cpu_if = &vcpu->arch.vgic_cpu.vgic_v3; > + u64 val; > + u32 nr_lr, nr_pri; > + > + /* > + * Make sure stores to the GIC via the memory mapped interface > + * are now visible to the system register interface. > + */ > + dsb(st); > + > + cpu_if->vgic_vmcr = read_gicreg(ICH_VMCR_EL2); > + cpu_if->vgic_misr = read_gicreg(ICH_MISR_EL2); > + cpu_if->vgic_eisr = read_gicreg(ICH_EISR_EL2); > + cpu_if->vgic_elrsr = read_gicreg(ICH_ELSR_EL2); > + > + write_gicreg(0, ICH_HCR_EL2); > + val = read_gicreg(ICH_VTR_EL2); > + nr_lr = val & 0xf; > + nr_pri = ((u32)val >> 29) + 1; > + > + switch (nr_lr) { > + case 15: > + cpu_if->vgic_lr[LR_OFFSET(15)] = read_gicreg(ICH_LR15_EL2); > + case 14: > + cpu_if->vgic_lr[LR_OFFSET(14)] = read_gicreg(ICH_LR14_EL2); > + case 13: > + cpu_if->vgic_lr[LR_OFFSET(13)] = read_gicreg(ICH_LR13_EL2); > + case 12: > + cpu_if->vgic_lr[LR_OFFSET(12)] = read_gicreg(ICH_LR12_EL2); > + case 11: > + cpu_if->vgic_lr[LR_OFFSET(11)] = read_gicreg(ICH_LR11_EL2); > + case 10: > + cpu_if->vgic_lr[LR_OFFSET(10)] = read_gicreg(ICH_LR10_EL2); > + case 9: > + cpu_if->vgic_lr[LR_OFFSET(9)] = read_gicreg(ICH_LR9_EL2); > + case 8: > + cpu_if->vgic_lr[LR_OFFSET(8)] = read_gicreg(ICH_LR8_EL2); > + case 7: > + cpu_if->vgic_lr[LR_OFFSET(7)] = read_gicreg(ICH_LR7_EL2); > + case 6: > + cpu_if->vgic_lr[LR_OFFSET(6)] = read_gicreg(ICH_LR6_EL2); > + case 5: > + cpu_if->vgic_lr[LR_OFFSET(5)] = read_gicreg(ICH_LR5_EL2); > + case 4: > + cpu_if->vgic_lr[LR_OFFSET(4)] = read_gicreg(ICH_LR4_EL2); > + case 3: > + cpu_if->vgic_lr[LR_OFFSET(3)] = read_gicreg(ICH_LR3_EL2); > + case 2: > + cpu_if->vgic_lr[LR_OFFSET(2)] = read_gicreg(ICH_LR2_EL2); > + case 1: > + cpu_if->vgic_lr[LR_OFFSET(1)] = read_gicreg(ICH_LR1_EL2); > + case 0: > + cpu_if->vgic_lr[LR_OFFSET(0)] = read_gicreg(ICH_LR0_EL2); > + } > + > + switch (nr_pri) { > + case 7: > + cpu_if->vgic_ap0r[3] = read_gicreg(ICH_AP0R3_EL2); > + cpu_if->vgic_ap0r[2] = read_gicreg(ICH_AP0R2_EL2); > + case 6: > + cpu_if->vgic_ap0r[1] = read_gicreg(ICH_AP0R1_EL2); > + default: > + cpu_if->vgic_ap0r[0] = read_gicreg(ICH_AP0R0_EL2); > + } > + > + switch (nr_pri) { > + case 7: > + cpu_if->vgic_ap1r[3] = read_gicreg(ICH_AP1R3_EL2); > + cpu_if->vgic_ap1r[2] = read_gicreg(ICH_AP1R2_EL2); > + case 6: > + cpu_if->vgic_ap1r[1] = read_gicreg(ICH_AP1R1_EL2); > + default: > + cpu_if->vgic_ap1r[0] = read_gicreg(ICH_AP1R0_EL2); > + } > + > + write_gicreg(read_gicreg(ICC_SRE_EL2) | ICC_SRE_EL2_ENABLE, > + ICC_SRE_EL2); > + isb(); > + write_gicreg(1, ICC_SRE_EL1); > +} > + > +void __hyp_text __vgic_v3_restore_state(struct kvm_vcpu *vcpu) > +{ > + struct vgic_v3_cpu_if *cpu_if = &vcpu->arch.vgic_cpu.vgic_v3; > + u64 val; > + u32 nr_lr, nr_pri; > + > + /* Make sure SRE is valid before writing the other registers */ > + write_gicreg(cpu_if->vgic_sre, ICC_SRE_EL1); > + isb(); > + > + write_gicreg(cpu_if->vgic_hcr, ICH_HCR_EL2); > + write_gicreg(cpu_if->vgic_vmcr, ICH_VMCR_EL2); > + > + val = read_gicreg(ICH_VTR_EL2); > + nr_lr = val & 0xf; > + nr_pri = ((u32)val >> 29) + 1; > + > + switch (nr_pri) { > + case 7: > + write_gicreg(cpu_if->vgic_ap1r[3], ICH_AP1R3_EL2); > + write_gicreg(cpu_if->vgic_ap1r[2], ICH_AP1R2_EL2); > + case 6: > + write_gicreg(cpu_if->vgic_ap1r[1], ICH_AP1R1_EL2); > + default: > + write_gicreg(cpu_if->vgic_ap1r[0], ICH_AP1R0_EL2); > + } > + > + switch (nr_pri) { > + case 7: > + write_gicreg(cpu_if->vgic_ap0r[3], ICH_AP0R3_EL2); > + write_gicreg(cpu_if->vgic_ap0r[2], ICH_AP0R2_EL2); > + case 6: > + write_gicreg(cpu_if->vgic_ap0r[1], ICH_AP0R1_EL2); > + default: > + write_gicreg(cpu_if->vgic_ap0r[0], ICH_AP0R0_EL2); > + } > + > + switch (nr_lr) { > + case 15: > + write_gicreg(cpu_if->vgic_lr[LR_OFFSET(15)], ICH_LR15_EL2); > + case 14: > + write_gicreg(cpu_if->vgic_lr[LR_OFFSET(14)], ICH_LR14_EL2); > + case 13: > + write_gicreg(cpu_if->vgic_lr[LR_OFFSET(13)], ICH_LR13_EL2); > + case 12: > + write_gicreg(cpu_if->vgic_lr[LR_OFFSET(12)], ICH_LR12_EL2); > + case 11: > + write_gicreg(cpu_if->vgic_lr[LR_OFFSET(11)], ICH_LR11_EL2); > + case 10: > + write_gicreg(cpu_if->vgic_lr[LR_OFFSET(10)], ICH_LR10_EL2); > + case 9: > + write_gicreg(cpu_if->vgic_lr[LR_OFFSET(9)], ICH_LR9_EL2); > + case 8: > + write_gicreg(cpu_if->vgic_lr[LR_OFFSET(8)], ICH_LR8_EL2); > + case 7: > + write_gicreg(cpu_if->vgic_lr[LR_OFFSET(7)], ICH_LR7_EL2); > + case 6: > + write_gicreg(cpu_if->vgic_lr[LR_OFFSET(6)], ICH_LR6_EL2); > + case 5: > + write_gicreg(cpu_if->vgic_lr[LR_OFFSET(5)], ICH_LR5_EL2); > + case 4: > + write_gicreg(cpu_if->vgic_lr[LR_OFFSET(4)], ICH_LR4_EL2); > + case 3: > + write_gicreg(cpu_if->vgic_lr[LR_OFFSET(3)], ICH_LR3_EL2); > + case 2: > + write_gicreg(cpu_if->vgic_lr[LR_OFFSET(2)], ICH_LR2_EL2); > + case 1: > + write_gicreg(cpu_if->vgic_lr[LR_OFFSET(1)], ICH_LR1_EL2); > + case 0: > + write_gicreg(cpu_if->vgic_lr[LR_OFFSET(0)], ICH_LR0_EL2); > + } > + > + /* > + * Ensure that the above will have reached the > + * (re)distributors. This ensure the guest will read the > + * correct values from the memory-mapped interface. > + */ > + isb(); > + dsb(sy); > + > + /* > + * Prevent the guest from touching the GIC system registers if > + * SRE isn't enabled for GICv3 emulation. > + */ > + if (!cpu_if->vgic_sre) { > + write_gicreg(read_gicreg(ICC_SRE_EL2) & ~ICC_SRE_EL2_ENABLE, > + ICC_SRE_EL2); > + } > +} > + > +u64 __hyp_text __vgic_v3_read_ich_vtr_el2(void) > +{ > + return read_gicreg(ICH_VTR_EL2); > +} -- Alex Benn?e