From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37849)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZmM3H-0003zT-Hb
	for qemu-devel@nongnu.org; Wed, 14 Oct 2015 09:25:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZmM3D-00077e-Hn
	for qemu-devel@nongnu.org; Wed, 14 Oct 2015 09:25:06 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56918)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1ZmM3D-00077U-Ca
	for qemu-devel@nongnu.org; Wed, 14 Oct 2015 09:25:03 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1435756353-4150-1-git-send-email-drjones@redhat.com>
	<20150924093119.GA11859@vader>
	<20150924135004.GC3486@hawk.localdomain>
	<20150929093946.GA30238@vader> <20151014090337.GA13329@vader>
	<20151014124118.GA24085@hawk.localdomain>
Date: Wed, 14 Oct 2015 15:25:00 +0200
In-Reply-To: <20151014124118.GA24085@hawk.localdomain> (Andrew Jones's message
	of "Wed, 14 Oct 2015 14:41:18 +0200")
Message-ID: <87eggxzioj.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH] libseccomp: add cacheflush to whitelist
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andrew Jones <drjones@redhat.com>
Cc: pmoore@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org

Andrew Jones <drjones@redhat.com> writes:

> On Wed, Oct 14, 2015 at 11:03:37AM +0200, Eduardo Otubo wrote:
>> On Tue, Sep 29, 2015 at 11=39=46AM +0200, Eduardo Otubo wrote:
>> > On Thu, Sep 24, 2015 at 03=50=04PM +0200, Andrew Jones wrote:
>> > > On Thu, Sep 24, 2015 at 11:31:19AM +0200, Eduardo Otubo wrote:
>> > > > On Wed, Jul 01, 2015 at 09=12=33AM -0400, Andrew Jones wrote:
[...]
>> > > > > diff --git a/qemu-seccomp.c b/qemu-seccomp.c
>> > > > > index f9de0d3390feb..33644a4e3c3d3 100644
>> > > > > --- a/qemu-seccomp.c
>> > > > > +++ b/qemu-seccomp.c
>> > > > > @@ -237,7 +237,8 @@ static const struct QemuSeccompSyscall seccomp_whitelist[] = {
>> > > > >      { SCMP_SYS(fadvise64), 240 },
>> > > > >      { SCMP_SYS(inotify_init1), 240 },
>> > > > >      { SCMP_SYS(inotify_add_watch), 240 },
>> > > > > -    { SCMP_SYS(mbind), 240 }
>> > > > > +    { SCMP_SYS(mbind), 240 },
>> > > > > +    { SCMP_SYS(cacheflush), 240 },
>> 
>> FYI: I had to fixed this minor mistake (using comma at the end of the
>> list) before applying your patch.
>
> Does that violate a QEMU coding style? Because I actually put it there
> on purpose so the next addition wouldn't have to modify the line (by
> adding a comma), making git-blame more difficult to use.

We have trailing commas all over the place, for precisely the reason you
gave.  I recommend to put it right back.